June 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > ok(GetLastError() == ERROR_SUCCESS || broken(GetLastError() == ERROR_INVALID_PARAMETER) /* some win8 machines */, > "Unexpected error %lu.\n", GetLastError()); > > + /* test long file path, the length of the long_dest is larger than MAX_PATH. */ > + if (is_enabled_long_path()) > + { > + wcscpy(long_path_1, temp_path); > + wcscat(long_path_1, a); > + SetLastError(0xdeadbeef); > + ret = CopyFileExW(source, long_path_1, NULL, NULL, NULL, 0); > + ok(ret, "Expected CopyFileExW successed, but got %ld, copy %s -> %s\n", GetLastError(), wine_dbgstr_w(source), wine_dbgstr_w(long_path_1)); `successed` is a typo. Let's use "CopyFileExW(%s, %s) failed, error %lu.\n" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106692

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > + { > + rovi.dwOSVersionInfoSize = sizeof(rovi); > + if (pRtlGetVersion && S_OK == pRtlGetVersion(&rovi)) > + trace("windows version: win %ld, build %ld\n", rovi.dwMajorVersion, rovi.dwBuildNumber); > + } > + > + return rovi.dwMajorVersion >= 10 && rovi.dwBuildNumber >= 14393; > +} > + > +static BOOL is_reg_enable_long_path(void) > +{ > + static DWORD LongPathEnabled = -1; > + > + DWORD ret; > + HKEY hkey; > + DWORD type, size = sizeof(LongPathEnabled); You can put ret, type, and size on the same line and initialise size after RegOpenKeyExA succeeds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106691

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > ok(ret, "DeleteFileA: error %ld\n", GetLastError()); > } > > +/* Windows 10, version 1607, building number 14393, Redstone, August 2, 2016 */ > +static BOOL is_win10_1607_or_later(void) > +{ > + static RTL_OSVERSIONINFOEXW rovi = { 0 }; Add a newline after variable declaration. Same at other places. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106690

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > static void (WINAPI *pRtlFreeUnicodeString)(PUNICODE_STRING); > static BOOL (WINAPI *pSetFileCompletionNotificationModes)(HANDLE, UCHAR); > static HANDLE (WINAPI *pFindFirstStreamW)(LPCWSTR filename, STREAM_INFO_LEVELS infolevel, void *data, DWORD flags); > +static NTSTATUS(WINAPI* pRtlGetVersion)(PRTL_OSVERSIONINFOEXW); Change it to "static NTSTATUS (WINAPI *pRtlGetVersion)(PRTL_OSVERSIONINFOEXW);" for style consistency. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106689

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernelbase/file.c: > SetLastError( ERROR_INVALID_PARAMETER ); > return FALSE; > } > + > + if (!RtlGetCurrentPeb()->IsLongPathAwareProcess && wcsncmp(source, L"\\\\?\\", 4) && wcslen(source) >= MAX_PATH ) Let reorder the conditions to `wcslen(source) >= MAX_PATH && wcsncmp(source, L"\\\\?\\", 4) && !RtlGetCurrentPeb()->IsLongPathAwareProcess)`. I find it clearer this way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106688

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > SetLastError(0xdeadbeef); > retok = CopyFileExA(long_path_1, long_path_2, NULL, NULL, NULL, 0); > ok(retok, "CopyFileExA failed, got %ld, copy %s -> %s failed\n", GetLastError(), long_path_1, long_path_2); > + Avoid white-space changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106687

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/ntdll/actctx.c: > + TRACE("windows version: win %ld, build %ld\n", rovi.dwMajorVersion, rovi.dwBuildNumber); > + } > + else > + { > + ERR("RtlGetVersion failed\n"); > + rovi.dwMajorVersion = 0; > + rovi.dwBuildNumber = 0; > + } > + } > + > + return rovi.dwMajorVersion >= 10 && rovi.dwBuildNumber >= 14393; > +} > + > +NTSTATUS query_dword_option( HANDLE hkey, LPCWSTR name, LONG *value ); > + > +static BOOL is_longpath_enabled_in_reg(void) Let's rename it to is_reg_long_path_enabled() -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106686

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/ntdll/actctx.c: > + if (RtlGetVersion(&rovi) == ERROR_SUCCESS) > + { > + TRACE("windows version: win %ld, build %ld\n", rovi.dwMajorVersion, rovi.dwBuildNumber); > + } > + else > + { > + ERR("RtlGetVersion failed\n"); > + rovi.dwMajorVersion = 0; > + rovi.dwBuildNumber = 0; > + } > + } > + > + return rovi.dwMajorVersion >= 10 && rovi.dwBuildNumber >= 14393; > +} > + > +NTSTATUS query_dword_option( HANDLE hkey, LPCWSTR name, LONG *value ); Put this in ntdll_misc.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106685

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/wine_test.manifest: > <?xml version="1.0" encoding="UTF-8" standalone="yes"?> > -<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> > - <assemblyIdentity version="1.0.0.0" name="Wine.Test"/> Let's activate this manifest dynamically so that it doesn't affect other tests. For example, you can see kernel32/tests/actctx.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106684

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > + SIZE_T size; > + > + if (buffer[0] == 0) > + { > + memset( buffer, 0xcc, sizeof(buffer) ); > + ret = QueryActCtxSettingsW( 0, NULL, namespace2016W, longPathAwareW, buffer, lstrlenW(trueW) + 1, &size ); > + if (ret && size == lstrlenW(trueW) + 1) > + { > + trace("in app manifest LongPathAware: %s\n", debugstr_w(buffer)); > + } > + } > + > + return lstrcmpiW(buffer, trueW) == 0; > +} > + > +static BOOL is_enabled_long_path(void) Let's rename them to is_reg_long_path_enabled() and is_manifest_long_path_enabled(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106683

1 0