June 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c: > +} > + > +static BOOL is_app_enabled_long_path(void) > +{ > + static WCHAR buffer[10] = { 0 }; > + static const WCHAR *trueW = L"true"; > + static const WCHAR *longPathAwareW = L"longPathAware"; > + static const WCHAR *namespace2016W = L"http://schemas.microsoft.com/SMI/2016/WindowsSettings"; > + > + BOOL ret; > + SIZE_T size; > + > + if (buffer[0] == 0) > + { > + memset( buffer, 0xcc, sizeof(buffer) ); > + ret = QueryActCtxSettingsW( 0, NULL, namespace2016W, longPathAwareW, buffer, lstrlenW(trueW) + 1, &size ); You can use literal Unicode strings. For example, QueryActCtxSettingsW( 0, NULL, L"http://schemas.microsoft.com/SMI/2016/WindowsSettings", ...) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106682

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) June 16, 2025

June 16, 2025

On Wed May 28 14:34:06 2025 +0000, Zhiyi Zhang wrote: > The Windows 10 tests are still failing. Could you investigate that? I see these win10 test failures on other MRs as well. So they're not related to this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106680

1 0

[PATCH v3 0/5] MR8291: winex11: Drop pixmap-based child window workaround.
by Rémi Bernon June 16, 2025

June 16, 2025

Updating the GL drawables on/offscreen dynamically, similarly to how we do it for Vulkan, and in order to ultimately converge and factor both GL and VK client surfaces. -- v3: winex11: Rename context drawables to draw / read. winex11: Drop pixmap-based child window workaround. winex11: Update drawable size and offscreen when presenting. winex11: Update every window GL drawable on resize / reparent. winex11: Update GL drawable offscreen status instead of recreating. https://gitlab.winehq.org/wine/wine/-/merge_requests/8291

1 6

[PATCH v3 0/2] MR8293: kernelbase: SetFileInformationByHandle pass FileRenameInfoEx to NtSetInformationFile
by Michael Stopa (＠stomy) June 16, 2025

June 16, 2025

FileRenameInfoEx is already handled by NtSetInformationFile, SetFileInformationByHandle need only pass it through correctly. As of version 5.3, Apple's Metal Developer Tools are dependent on SetFileInformationByHandle to handle FileRenameInfoEx in this fashion. -- v3: kernelbase: pass FileRenameInfoEx to NtSetInformationFile kernel32/tests: SetFileInfo should accept FileRenameInfoEx https://gitlab.winehq.org/wine/wine/-/merge_requests/8293

2 3

[PATCH v20 0/3] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) June 16, 2025

June 16, 2025

In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that. -- v20: cmd: Allow '+' as delimiter for tab-completion, e.g. 'copy file+file2'. https://gitlab.winehq.org/wine/wine/-/merge_requests/8200

2 4

[PATCH 0/1] MR8312: rpcrt4/tests: Fix out-of-bound write in test_pointer_marshal.
by Yuxuan Shui (＠yshui) June 15, 2025

June 15, 2025

In case of FC_POINTER_DEREF, we write a pointer into mem, so we need to allocate at least sizeof(pointer). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8312

3 2

[PATCH v4 0/3] MR8195: widl: Always use NdrClientCall2() for interpreted stubs.
by Nikolay Sivov (＠nsivov) June 15, 2025

June 15, 2025

NdrClientCall() should only be used in 32-bit mode when Oi or Oic stub optimizations are used. Currently our interpreted mode targets Oicf mode and other levels are not supported. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: include: Add errlup.idl. widl: Do not write "const" modifiers for _PARAM_STRUCT fields. widl: Always use NdrClientCall2() for interpreted stubs. https://gitlab.winehq.org/wine/wine/-/merge_requests/8195

4 5

[PATCH v7 0/7] MR6892: dlls/propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) June 15, 2025

June 15, 2025

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v7: dlls/propsys: Implement IPropertyDescription for several known system properties. dlls/propsys: Add IPropertyDescription stub for system defined properties. dlls/propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. dlls/propsys: Add stubs for PSGetNameFromPropertyKey. dlls/propsys: Add stubs for PropertySystem. dlls/propsys/tests: Add conformance tests for PSGetPropertyKeyFromName. dlls/propsys/tests: Add conformance tests for getting PropertyDescriptions from PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 7

[PATCH v5 0/1] MR8237: kernelbase: Implement HeapSummary
by Julius Bettin (＠ningvin) June 15, 2025

June 15, 2025

I tripped over this function while trying to run a game, so I thought I would have a go at it :-) The implementation is very similar to what is done in `Local32Info16` already. Regarding the place to put the function: I am not sure about the exact relationship between `kernel32` and `kernelbase`, but as most of the heap related functions are implemented in `kernelbase` I opted to add it to the latter. The tests reside in the `kernel32` directory though. The tests are currently pretty basic as I was a bit hesitant to compare against hard coded sizes for reserved / committed memory (that could break if someone made changes to the heap implementation). Also, I am not entirely sure about the semantics of the `cbMaxReserve` field. I opted to always set it to the same value as `cbReserved`, which seems *good enough™*. Let me know if this needs improvement! -- v5: kernelbase: Implement HeapSummary https://gitlab.winehq.org/wine/wine/-/merge_requests/8237

2 1

[PATCH v39 0/6] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) June 15, 2025

June 15, 2025

-- v39: wintypes: Add stubs for IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet. wintypes: Add stubs for IMap<HSTRING, IInspectable *> to PropertySet. wintypes: Add stubs for IObservableMap<HSTRING, IInspectable *> to PropertySet. wintypes: Add stubs for Windows.Foundation.Collections.PropertySet. wintypes/tests: Add conformance tests for Windows.Foundation.Collections.PropertySet. include: Add Windows.Foundation.Collections.PropertySet runtime class. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

2 11