June 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR8272: kerberos: EncryptMessage() should fail if context doesn't support confidentiality.
by Dmitry Timoshkov (＠dmitry) June 11, 2025

June 11, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8272

3 4

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Alexandre Julliard (＠julliard) June 11, 2025

June 11, 2025

On Wed Jun 11 01:09:53 2025 +0000, Elizabeth Figura wrote: > But the patch is going to be edited before committing anyway, whether > the generated changes are included or not, so I don't see the issue? The generated files will be updated on commit, but if there's a conflict the MR won't apply cleanly. And in general I refrain from merging MRs that cause conflicts because that makes it too easy to screw something up. So not including generated files is not a requirement, but it increases the chances that the MR can go in smoothly. Of course it also depends on the file, conflicts are not very likely with `include/Makefile.in`, but are pretty much guaranteed with `ntsyscalls.h` or `server_protocol.h`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106208

1 0

[PATCH 0/1] MR8268: comdlg32/tests: Add broken to PrintDlg{A,W} tests.
by Bernhard Übelacker June 11, 2025

June 11, 2025

Followup to 2ca6741d57 and cd96c69876. [Test pattern page](https://test.winehq.org/data/patterns.html#comdlg32:printdlg) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=158591) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8268

1 3

[PATCH 0/1] MR8276: wbemprox: Pass current directory correctly to CreateProcessW() in process_create().
by Paul Gofman (＠gofman) June 11, 2025

June 11, 2025

Now that is passed as environment block variable. Which generally works but not very well. Fixes environment variables being stripped of in games started by FunCom launcher. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8276

3 3

[PATCH 0/5] MR8254: msi: Fix installing 64 bit library from 32 bit installer if 32 bit version of it is loaded into installer.
by Paul Gofman (＠gofman) June 11, 2025

June 11, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8254

3 12

[PATCH v2 0/1] MR8242: libs/musl: Force built-in rint for i386.
by Daniel Lehman (＠dlehman25) June 11, 2025

June 11, 2025

https://gitlab.winehq.org/wine/wine/-/merge_requests/7748#note_105461 huge thanks to @bernhardu for narrowing it down. does this work for you? -- v2: libs/musl: Base rounding constant on precision mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/8242

2 2

[PATCH v2 0/2] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) June 11, 2025

June 11, 2025

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- v2: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer. winegstreamer: Signal eos on disconnect. https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 3

[PATCH 0/1] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) June 11, 2025

June 11, 2025

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 1

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Elizabeth Figura (＠zfigura) June 11, 2025

June 11, 2025

On Tue Jun 10 23:46:26 2025 +0000, Jinoh Kang wrote: > Thanks for your insight. I understand, but IMHO it's a good idea not to > include generated files since they introduce unnecessary merge conflicts. > For example, adding a new syscall results in about half of > `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, > and (2) include generated files will surely conflict each other. But the patch is going to be edited before committing anyway, whether the generated changes are included or not, so I don't see the issue? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106184

1 0

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Jinoh Kang (＠iamahuman) June 10, 2025

June 10, 2025

On Tue Jun 10 18:39:40 2025 +0000, Elizabeth Figura wrote: > Where did this advice come from exactly? I've never heard Alexandre > request that people not include generated files, only that it's not > necessary, and I've seen plenty of patches accepted with generated > changes. As far as I can tell "it's not necessary" got somehow warped > into "you shouldn't" and then spread as common knowledge. Thanks for your insight. I understand, but IMHO it's a good idea not to include generated files since they introduce unnecessary merge conflicts. For example, adding a new syscall results in about half of `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, and (2) include generated files will surely conflict each other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106172

1 0