June 2025 - Wine-GitLab - list.winehq.org

[PATCH v2 0/2] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) June 10, 2025

June 10, 2025

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- v2: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer. winegstreamer: Signal eos on disconnect. https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 3

[PATCH 0/1] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) June 10, 2025

June 10, 2025

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

2 1

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Elizabeth Figura (＠zfigura) June 10, 2025

June 10, 2025

On Tue Jun 10 23:46:26 2025 +0000, Jinoh Kang wrote: > Thanks for your insight. I understand, but IMHO it's a good idea not to > include generated files since they introduce unnecessary merge conflicts. > For example, adding a new syscall results in about half of > `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, > and (2) include generated files will surely conflict each other. But the patch is going to be edited before committing anyway, whether the generated changes are included or not, so I don't see the issue? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106184

1 0

Re: [PATCH v4 0/5] MR8244: combase: Add RoFailFastWithErrorContextInternal2() stub.
by Jinoh Kang (＠iamahuman) June 10, 2025

June 10, 2025

On Tue Jun 10 18:39:40 2025 +0000, Elizabeth Figura wrote: > Where did this advice come from exactly? I've never heard Alexandre > request that people not include generated files, only that it's not > necessary, and I've seen plenty of patches accepted with generated > changes. As far as I can tell "it's not necessary" got somehow warped > into "you shouldn't" and then spread as common knowledge. Thanks for your insight. I understand, but IMHO it's a good idea not to include generated files since they introduce unnecessary merge conflicts. For example, adding a new syscall results in about half of `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, and (2) include generated files will surely conflict each other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8244#note_106172

1 0

[PATCH 0/5] MR8281: amstream: More fallout from dynamic format change.
by Elizabeth Figura (＠zfigura) June 10, 2025

June 10, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8281

2 5

[PATCH 0/1] MR8279: winewayland.drv: Respond to size hints when moving out of fullscreen
by Aven Bross (＠permutationlock) June 10, 2025

June 10, 2025

Currently xdg_toplevel_config size hints are ignored if the config has state 0 to avoid spurrious re-sizing. However, if the window is currently configured with a non-zero state, e.g. it is in fullscreen, then such an event from the compositor indicates a switch to a floating window, in which case the size hint should be respected. Additionally, the check for whether the current size of a fullscreen window is compatible with the compositor requested size would always return true regardless of size. Reading the comments for `wayland_surface_config_is_compatible`, it seems that behavior is intended in the other places the function is used, so that call was replaced with a simple size comparison. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8279

2 1

[PATCH 0/1] MR8277: d3d11: Implement CreateRasterizerState2().
by Elizabeth Figura (＠zfigura) June 10, 2025

June 10, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8277

2 1

Re: [PATCH v2 0/1] MR8271: kernel32/tests: Don't call pNtCompareObjects in Windows 8. - approved
by Alexandre Julliard (＠julliard) June 10, 2025

June 10, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271

1 0

Re: [PATCH v2 0/1] MR8269: comdlg32/tests: Remove tests in printer_properties_hook_proc for A and W versions. - approved
by Alexandre Julliard (＠julliard) June 10, 2025

June 10, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8269

1 0

Re: [PATCH v2 0/1] MR8232: msvcrt: Support j modifer in scanf. - approved
by Alexandre Julliard (＠julliard) June 10, 2025

June 10, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8232

1 0