September 2025 - Wine-GitLab

Re: [PATCH v2 0/2] MR8968: setupapi: Parse a 0x prefix in SetupGetBinaryField(). - approved
by Alexandre Julliard (＠julliard) Sept. 15, 2025

Sept. 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8968

1 0

Re: [PATCH v2 0/3] MR8967: user32: Refresh MDI menus when DefMDIChildProc(WM_SETTEXT) is called. - approved
by Alexandre Julliard (＠julliard) Sept. 15, 2025

Sept. 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8967

1 0

[PATCH v5 0/2] MR8971: make_unicode: Add some halfwidth mapping exceptions.
by Bernhard Kölbl Sept. 15, 2025

Sept. 15, 2025

The nls files need regeneration, in order to get the test working. -- v5: make_unicode: Add some fullwidth mapping exceptions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8971

1 3

[PATCH v6 0/3] MR8920: cmd: Fix some TYPE command behavior (one more try).
by Joe Souza (＠JoeS209) Sept. 15, 2025

Sept. 15, 2025

Giving this one final shot. If this is not deemed acceptable, I will abandon the effort and just move on to other things, no hard feelings. This is IMO a cleaner, more conservative/less invasive change. What is fixed: - Bug #56381, "TYPE c:\windows\winhelp.exe >foo", i.e. binary mode operation. I would probably consider this the main reason for this change. I'm trying to get the compiler mentioned in the bug report working. - Ctrl-Z termination of TYPE output to the console. - "TYPE con >foo", with Ctrl-Z handling, functionally equivalent to "COPY con foo". Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56381 -- v6: cmd: Fix TYPE behavior (now uses WCMD_copy_loop). cmd: Refactor WCMD_copy_loop out of WCMD_ManualCopy, and stop copy loop at EOF for /a mode. cmd/tests: Add test to check for TYPE truncation in binary mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/8920

2 4

[PATCH v4 0/1] MR8971: make_unicode: Add some halfwidth mapping exceptions.
by Bernhard Kölbl Sept. 15, 2025

Sept. 15, 2025

The nls files need regeneration, in order to get the test working. -- v4: make_unicode: Add some halfwidth mapping exceptions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8971

2 3

Re: [PATCH v4 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Nikolay Sivov (＠nsivov) Sept. 15, 2025

Sept. 15, 2025

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c: > + ok(attr_out != NULL, "removeAttributeNode expected to set attr_out, but got NULL pointer\n"); > +} > + if (attr_out) > + { > + /* remove the same attribute again returns invalid arg */ > + hr = IXMLDOMElement_removeAttributeNode( element, attr, NULL ); > + ok(hr == E_INVALIDARG, "removeAttributeNode removed an already removed node, unexpected hr %#lx.\n", hr); > + > + /* readd removed attribute to recover previous state */ > + hr = IXMLDOMElement_setAttributeNode(element, attr_out, NULL); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + IXMLDOMAttribute_Release(attr_out); > + } > + IXMLDOMAttribute_Release(attr); > + } Please get rid of this nesting, no need to check for nulls for something that's not expected to be null. The 'attr_out' check should stay of course, until it's implemented in wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115883

1 0

Re: [PATCH v4 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Nikolay Sivov (＠nsivov) Sept. 15, 2025

Sept. 15, 2025

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c: > + /* readd removed attribute to recover previous state */ > + hr = IXMLDOMElement_setAttributeNode(element, attr_out, NULL); > + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); > + > + IXMLDOMAttribute_Release(attr_out); > + } > + IXMLDOMAttribute_Release(attr); > + } > + > SysFreeString( str ); > > + attr = NULL; > + attr_out = (IXMLDOMAttribute*)0xdeadbeef; > + hr = IXMLDOMElement_removeAttributeNode( element, attr, &attr_out ); > + todo_wine ok(hr == E_INVALIDARG, "removeAttributeNode removed a NULL pointer hr: %#lx.\n", hr); > + ok(attr_out == (IXMLDOMAttribute*)0xdeadbeef, "removeAttributeNode expected to not touch attr_out in error case, got (%p)\n", attr_out); You don't need 'attr' here, just use NULL literal for argument value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115882

1 0

[PATCH 0/1] MR8973: winex11.drv: Remove a no longer valid assert().
by Dmitry Timoshkov (＠dmitry) Sept. 15, 2025

Sept. 15, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8973

2 1

[PATCH 0/5] MR8394: Draft: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński Sept. 15, 2025

Sept. 15, 2025

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

2 16

[PATCH 0/3] MR8972: win32u: Validate the drawable surface window before reusing.
by Rémi Bernon Sept. 15, 2025

Sept. 15, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58491 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8972

1 3