September 2025 - Wine-GitLab

Re: [PATCH v2 0/1] MR8956: nls: Update character tables to Unicode 17.0.0. - approved
by Alexandre Julliard (＠julliard) Sept. 12, 2025

Sept. 12, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8956

1 0

Re: [PATCH v6 0/3] MR8951: windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). - approved
by Alexandre Julliard (＠julliard) Sept. 12, 2025

Sept. 12, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8951

1 0

[PATCH 0/4] MR8688: server: Start to expose Unix symlinks as NT reparse points.
by Elizabeth Figura (＠zfigura) Sept. 12, 2025

Sept. 12, 2025

A Wine user has requested the ability to interact with Unix symlinks from Win32 code. While the generic functionality of NT reparse points is still not implemented upstream, it will probably involve a completely different code path than this, so there does not seem to me to be any point in waiting for that to be done before submitting these patches. This does not implement all the relevant functionality. FILE_OPEN_REPARSE_POINT is now respected, but returns an fd with no fd->unix_fd. Thus far only file disposition (i.e. deletion), renaming and hardlinking are implemented, and all other operations return the no_fd_status, for which STATUS_REPARSE_POINT_NOT_RESOLVED is arbitrarily chosen. This is probably going to be controversial. As controversial patches tend to get deferred forever, I'm going to at least try to pose some questions related to concept and implementation which may be easier to answer. * Do we want to expose Unix symlinks at all? This was requested by a Wine user, and it does seem a strong argument that Wine, in general, supports some measure of integration with the host, including exposing custom interfaces for programs written to take advantage of it. We also, currently, already expose Unix *directory* symlinks via NtQueryAttributesFile(). We don't currently expose such file symlinks (and this series does not change that particular point, but it would be done by follow-up patches). In a sense we are expanding existing partial support. On the other hand, Unix symlinks which are completely opaque can be useful, and some downstream distributions (CrossOver and Proton) currently rely on them to reduce disk space usage while keeping the application unaware of a symlink (even if it were to use FILE_OPEN_REPARSE_POINT. Not that any applications are currently known that would break if this were to change, and in any case they could simply revert these patches.) * Implementation-wise, is having unix_fd == -1 a non-starter? This can be true of other real fds in some specific cases... * It's also true that this current implementation suffers from some degree of TOCTOU problems: because we only store the name and not the FD anymore, the actual underlying object at that path can change. This would not be true on Windows. Is this a problem? * One alternate approach would be to use O_PATH (Linux, FreeBSD) and O_SYMLINK (Mac). I don't see any equivalent flag for NetBSD or Solaris, so we would probably just not be able to expose this functionality there. Note that while the documentation seems to imply that O_PATH only stores the path, manual testing shows that (at least on Linux) a fd opened with O_PATH will remain pointing at the same *inode* even if it is moved or deleted. So this would avoid the aforementioned TOCTOU problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8688

5 11

[PATCH v2 0/1] MR8962: dbghelp: Fix pointer truncation issues when parsing 64-bit Mach-O binaries in a Wow64 process
by Brendan Shanks (＠bshanks) Sept. 12, 2025

Sept. 12, 2025

When running `SymInitializeW(GetCurrentProcess(), NULL, TRUE)` in a 32-bit EXE on 64-bit macOS, there are a number of syscall faults resulting from 64-bit pointers being truncated to 32 bits and then passed to `ReadProcessMemory()`. Fix these, mostly by widening variables to 64 bits. -- v2: dbghelp: Don't try to load 64-bit ELF/Mach-O debug info in a Wow64 process. https://gitlab.winehq.org/wine/wine/-/merge_requests/8962

2 2

[PATCH v2 0/4] MR8869: Draft: server: Post a WINE_WM_PRESENT for window surface present.
by Rémi Bernon Sept. 12, 2025

Sept. 12, 2025

Every 33ms on toplevel windows with a non-dummy, non-offscreen window surface. Making sure the window surfaces are flushed from their owner thread instead of any other thread that might draw to it and trigger an occasional flush. This removes the need for tracking window surfaces to additionally flush them in win32u. It will make it easier to implement GL-based window surfaces for compositing, and simplify context management. Instead of one context per window, made current on the flushing thread we can have a single context on each thread owning a window that is used to flush them. -- v2: win32u: Remove now unnecessary window surfaces list. win32u: Flush window surfaces in process_wine_present. server: Post a WINE_WM_PRESENT for window surface present. win32u: Remove unnecessary window_surface exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/8869

1 8

[PATCH 0/8] MR8965: Draft: win32u: Flush window surfaces from owner thread, while waiting for messages.
by Rémi Bernon Sept. 12, 2025

Sept. 12, 2025

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/8869 I think this would be a much lighter and less complicated approach than trying to wake the window threads with internal messages. And it should be able to avoid spurious wake ups when there's no window surfaces involved. What I'm not completely sure about is whether this is going to flush the surfaces frequently enough, and if we can assume the window thread will always either peek or wait for messages. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8965

1 8

[PATCH 0/6] MR8878: ntdll: Avoid deadlock on SIGPIPE while holding virtual_mutex or fd_cache_mutex.
by Rémi Bernon Sept. 12, 2025

Sept. 12, 2025

This manifested with https://gitlab.winehq.org/wine/wine/-/merge_requests/8875, as it adds fd_cache_mutex lock on thread init to receive the new inproc sync file descriptors. The kernel32:sync test creates a thread then immediately terminates it, which causes wineserver to close its pipe while it is initializing, triggering a SIGPIPE that is receive while the thread is within the server_init_thread call and request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8878

3 14

[PATCH 0/1] MR8964: winebuild: Use .rdata section instead of .rodata on PE targets.
by Jacek Caban (＠jacek) Sept. 12, 2025

Sept. 12, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8964

2 1

[PATCH v5 0/3] MR8951: windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Sept. 12, 2025

Sept. 12, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v5: windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). windows.media.playback.mediaplayer: Add IMediaPlayer2 stub. include: Add IMediaPlayer2 definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/8951

3 5

[PATCH 0/4] MR8963: ntdll: Add helpers to send / receive fds with a request.
by Rémi Bernon Sept. 12, 2025

Sept. 12, 2025

This will be useful if not necessary at some point for shared resources, to send / receive fds with the D3DKMT requests. There's maybe an option to use `wine_server_fd_to_handle` / `wine_server_handle_to_fd` instead, but that would require creating file objects for every resource on the server side, and that seemed a bit unnecessary. Also, on the macOS side, we will likely want to extend these helper and the fd_type enum, to include and support sending / receiving mach_port_t fd types, as shared resources are backed by those on that platform. This probably doesn't fit too well with the otherwise unix file fds and the fd cache. It's maybe a bit awkward to squeeze the fd type bits into the request header but I didn't find a good other way and increasing its size breaks the size <= 64 assumption. It could be a pointer within the request struct passed to the helper call, but it seem a bit awkward from a usage point of view: hard to make it clear that it needs to be within the request struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8963

2 11