March 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

On Tue Mar 24 09:23:40 2026 +0000, Chris Kadar wrote: > I used > https://learn.microsoft.com/en-us/windows/win32/api/compressapi/nf-compress… > for function definitions, but for function names I tried to match the > existing style. > Looking at it now, the existing style was defined by the fci.h header, > so that doesn't really make sense. I wanted to keep the change minimal > and avoid adding files, but perhaps I should do that here after all? Yes, existing exports should of course stay as is. Newer exports are different, and we can't change that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133514

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Chris Kadar (＠nspitko) March 24, 2026

March 24, 2026

On Tue Mar 24 09:13:59 2026 +0000, Nikolay Sivov wrote: > If it's not important to get application running, it's better to keep > stub to a minimum. For instance here, we don't know if this is correct, > without tests. I believe this is the minimal stub for this game to work. The call pattern I observed is that it will call Compress first with a 0 byte input buffer, expecting to get ERROR_INSUFFICIENT_BUFFER back and reads the output data size to produce a new buffer. It then re-calls the function with the corrected size and expected data written to it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133513

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Chris Kadar (＠nspitko) March 24, 2026

March 24, 2026

On Tue Mar 24 09:13:59 2026 +0000, Nikolay Sivov wrote: > Is it defined like that in some older SDK? In current SDK there is no > such symbol, and compress/decompress functions are provided with compressapi.h. I used https://learn.microsoft.com/en-us/windows/win32/api/compressapi/nf-compress… for function definitions, but for function names I tried to match the existing style. Looking at it now, the existing style was defined by the fci.h header, so that doesn't really make sense. I wanted to keep the change minimal and avoid adding files, but perhaps I should do that here after all? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133512

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

Nikolay Sivov (@nsivov) commented about dlls/cabinet/fci.c: > + PVOID buff, > + SIZE_T buffSize, > + PSIZE_T compDataSize) > +{ > + FIXME("stub\n"); > + > + *compDataSize = dataSize; > + > + if( buffSize < dataSize ) > + { > + SetLastError( ERROR_INSUFFICIENT_BUFFER ); > + return FALSE; > + } > + memcpy(buff, data, dataSize); > + return TRUE; > +} If it's not important to get application running, it's better to keep stub to a minimum. For instance here, we don't know if this is correct, without tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133509

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

Nikolay Sivov (@nsivov) commented about dlls/cabinet/fci.c: > } > + > +/*********************************************************************** > + * FCICompressorCreate (CABINET.30) > + * > + * Create a compressor handle > + * > + * PARAMS > + * algo [I] Compression algoritm to use > + * settings [I] Optional settings struct (Unused) > + * handle [IO] On success, handle. > + * > + * RETURNS > + * TRUE for success > + * FALSE for failure > + */ Personally, I would get rid of those comment headers. But if kept, they need to be up-to-date. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133508

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

Nikolay Sivov (@nsivov) commented about dlls/cabinet/cabinet.spec: > 22 cdecl FDICopy(long ptr ptr long ptr ptr ptr) > 23 cdecl FDIDestroy(long) > 24 cdecl FDITruncateCabinet(long ptr long) > +30 cdecl FCICompressorCreate() > +33 cdecl FCICompressorCompress() > +35 cdecl FCICompressorClose() > +40 cdecl FDIDecompressorCreate() > +43 cdecl FDIDecompressorDecompress() > +45 cdecl FDIDecompressorClose() Those should use stdcall. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133507

1 0

Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
by Nikolay Sivov (＠nsivov) March 24, 2026

March 24, 2026

Nikolay Sivov (@nsivov) commented about include/fci.h: > BOOL __cdecl FCIFlushFolder(HFCI, PFNFCIGETNEXTCABINET, PFNFCISTATUS); > BOOL __cdecl FCIDestroy(HFCI hfci); > > +BOOL __cdecl FCICompressorCreate( COMPRESSIONALGORITHM, void *, HFCICOMPRESSOR ); > +BOOL __cdecl FCICompressorCompress( HFCICOMPRESSOR, LPCVOID, SIZE_T, PVOID, SIZE_T, PSIZE_T ); > +BOOL __cdecl FCICompressorClose( HFCICOMPRESSOR ); > + Is it defined like that in some older SDK? In current SDK there is no such symbol, and compress/decompress functions are provided with compressapi.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133506

1 0

[PATCH 0/1] MR10416: oleaut32: Handle reference tables when processing SLTG records
by Wolfgang Hartl (＠wolfo.dev) March 24, 2026

March 24, 2026

https://bugs.winehq.org/show_bug.cgi?id=59549 When processing SLTG record structures, references to other structures were not handled correctly. That causes an error "err:typelib:sltg_get_typelib_ref Unable to find reference". I added the handling of references to the SLTG_ProcessRecord() function. as they were already in other functions available. Testing: 1) With MS Money 2000: before the bug fix several error were logged, with the fix applied the errors were gone. 2) I created a small IDL with a record type and a second nested record type that referenced the first record, compiled it to an SLTG-tlb using widl. Then I dumped the tlb before and after the fix with a small C program. The output before the fix showed the error message and a corrupted structure in the dump. After the fix, the error was not shown anymore and the nested record was fully shown. Please see details with logs in the bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10416

3 2

[PATCH v4 0/1] MR10326: mmdevapi: Avoid copying more memory than reserved in validate_fmt (ASan).
by Bernhard Übelacker March 24, 2026

March 24, 2026

The function `validate_fmt` may receive a pointer which got just reserved memory for the `WAVEFORMATEX`. Unfortunately the assignment `fmt2 = *fmt` always copies the size of `WAVEFORMATEXTENSIBLE`. CC: @giomasce (I currently cannot point to a specific commit, but this may also be related to the recent changes?) <details> <summary>ASan details [gitlab CI](https://gitlab.winehq.org/bernhardu/wine/-/jobs/237050#L2464)</summary> ``` ==qcap_test.exe==728==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0022c122 at pc 0x785f4342 bp 0x0022bf4c sp 0x0022bb1c READ of size 40 at 0x0022c122 thread T0 #0 0x785f4341 in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x778957a5 in validate_fmt /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 #2 0x77896d1e in client_IsFormatSupported /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:881:10 #3 0x783e3624 in IAudioClient_IsFormatSupported /builds/bernhardu/wine/build64/include/audioclient.h:406:12 #4 0x783e5cd7 in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:454:10 #5 0x783e5928 in WINMM_GetSupportedFormats /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:504:14 #6 0x783e553b in WINMM_InitMMDevice /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:524:35 #7 0x783e4e9b in WINMM_EnumDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:610:17 #8 0x783d30e8 in WINMM_InitMMDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:856:10 #9 0x7be4a996 in RtlRunOnceExecuteOnce /builds/bernhardu/wine/build64/../dlls/ntdll/sync.c:462:10 ... Address 0x0022c122 is located in stack of thread T0 at offset 34 in frame #0 0x783e5c0f in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:442 This frame has 2 object(s): [16, 34) 'fmt' (line 443) <== Memory access at offset 34 overflows this variable [80, 84) 'junk' (line 443) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 in validate_fmt ``` </details> -- v4: mmdevapi: Avoid copying more memory than reserved in validate_fmt (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/10326

2 3

[PATCH v34 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 24, 2026

March 24, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v34: kernel32: Fix string termination of GetModuleFileName https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2