March 2026 - Wine-GitLab - list.winehq.org

[PATCH v17 0/2] MR10295: Draft: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 24, 2026

March 24, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v17: imagehlp: Fix ImageGetDigestStream https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v28 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 24, 2026

March 24, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v28: kernel32: Fix string termination of GetModuleFileName https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2

[PATCH v16 0/2] MR10295: Draft: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) March 24, 2026

March 24, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v16: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Yongjie Yao (＠yaoyongjie) March 24, 2026

March 24, 2026

On Mon Mar 23 13:43:48 2026 +0000, Rémi Bernon wrote: > I'd move `NtUserDestroyCursor` outside of the user lock, as creation > happens outside of it as well, and introduce a `goto failed;` here to > share the error path with the other error below: > ``` > failed: > user_unlock(); > NtUserDestroyCursor( sm_icon, 0 ); > free( class ); > return 0; > ``` Good idea. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133475

1 0

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Yongjie Yao (＠yaoyongjie) March 24, 2026

March 24, 2026

On Mon Mar 23 13:43:49 2026 +0000, Rémi Bernon wrote: > I don't think that's true? With the new user_lock scope, class creation > and insertion in the process linked list happens atomically. > Symmetrically, class destruction and removal from the process class list > also happens atomically. So only scenario that > `find_shared_session_object` can fail, is some general critical error. > I don't think we care that much about what happens in that case, but it > seems to me that class pointer is exclusively owned by the calling > thread in all case until the class is inserted in the process list and > user critical section exited, and the pointer can and should always be > freed on error. Yes, you are right, with the new user_lock scope, only some critical error can cause find_shared_session_object failed, in that case, we should destroy the class, I will fixed it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133474

1 0

[PATCH v27 0/2] MR10291: Fix GetModuleFileName string termination
by Trent Waddington (＠trent.waddington) March 24, 2026

March 24, 2026

After Windows XP the string termination behavior of GetModuleFileName was changed to always terminate the path returned, even if the buffer is insufficient to contain the null terminator. -- v27: kernel32: Fix string termination of GetModuleFileName. https://gitlab.winehq.org/wine/wine/-/merge_requests/10291

2 2

[PATCH v2 0/1] MR10373: vbscript: Allow Property Let to accept VT_DISPATCH arguments.
by Francis De Brabandere (＠francisdb) March 24, 2026

March 24, 2026

When assigning an object (VT_DISPATCH) to a property, Wine looks for Property Set. If only Property Let is defined, fall back to using it with the object's default value. This allows code that uses Property Let with object arguments (which extracts the default value) to work when Property Set is not defined. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53844 -- v2: vbscript: Pass VT_DISPATCH as-is to Property Let without extracting default value. https://gitlab.winehq.org/wine/wine/-/merge_requests/10373

3 3

[PATCH v2 0/1] MR10384: vbscript: Allow hex literals with excess leading zeros.
by Francis De Brabandere (＠francisdb) March 24, 2026

March 24, 2026

Windows allows any number of leading zeros in hex literals (e.g. &H000000031 = 49). Wine rejected literals with more than 8 hex digits regardless of value. Fix by skipping leading zeros before counting significant digits, so that only actual 32-bit overflow is rejected. -- v2: vbscript: Allow hex literals with excess leading zeros. https://gitlab.winehq.org/wine/wine/-/merge_requests/10384

3 2

[PATCH 0/1] MR10387: vbscript: Invoke default property when calling object variable with empty parens.
by Francis De Brabandere (＠francisdb) March 23, 2026

March 23, 2026

When a variable holding a dispatch object is called with empty parentheses (e.g. x()), invoke the object's default property (DISPID_VALUE) instead of returning the dispatch object by reference. This matches the behavior of Windows VBScript. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10387

3 2

[PATCH v7 0/1] MR10396: vbscript: Implement IActiveScriptError::GetSourceLineText.
by Francis De Brabandere (＠francisdb) March 23, 2026

March 23, 2026

Store a reference to vbscode_t in VBScriptError and compute the source line text on demand in GetSourceLineText. Only store the source reference for compile errors, not runtime errors, matching native behavior. Also fix a memory leak in VBScriptError_Release by using clear_ei to free EXCEPINFO BSTRs. -- v7: vbscript: Implement IActiveScriptError::GetSourceLineText. https://gitlab.winehq.org/wine/wine/-/merge_requests/10396

3 2