March 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Rémi Bernon March 23, 2026

March 23, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/class.c: > - SERVER_START_REQ( destroy_class ) > - { > - req->instance = wine_server_client_ptr( instance ); > - wine_server_add_data( req, name->Buffer, name->Length ); > - wine_server_call( req ); > - } > - SERVER_END_REQ; > - free( class ); > + > + /** > + * If we fail to get the shared object, the class must be destroyed and freed by other thread, > + * so we must not free it here. > + */ > + NtUserDestroyCursor( sm_icon, 0 ); > + user_unlock(); > return 0; I don't think that's true? With the new user_lock scope, class creation and insertion in the process linked list happens atomically. Symmetrically, class destruction and removal from the process class list also happens atomically. So only scenario that `find_shared_session_object` can fail, is some general critical error. I don't think we care that much about what happens in that case, but it seems to me that class pointer is exclusively owned by the calling thread in all case until the class is inserted in the process list and user critical section exited, and the pointer can and should always be freed on error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133371

1 0

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Rémi Bernon March 23, 2026

March 23, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/class.c: > SERVER_END_REQ; > if (!ret) > { > + NtUserDestroyCursor( sm_icon, 0 ); > free( class ); > + user_unlock(); > return 0; > } I'd move `NtUserDestroyCursor` outside of the user lock, as creation happens outside of it as well, and introduce a `goto failed;` here to share the error path with the other error below: ``` failed: user_unlock(); NtUserDestroyCursor( sm_icon, 0 ); free( class ); return 0; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133370

1 0

[PATCH v13 0/7] MR10263: windows.web: Support JSON array and object parsing
by Olivia Ryan (＠olivi-r) March 23, 2026

March 23, 2026

Implements JsonArray, JsonObject value getters and extends JsonValue.Parse to support arrays and objects. -- v13: windows.web: Support boolean & number value creation windows.web: JsonObject typed getters https://gitlab.winehq.org/wine/wine/-/merge_requests/10263

3 9

[PATCH v2 0/2] MR10303: SDK compliance (2)
by eric pouech (＠epo) March 23, 2026

March 23, 2026

This serie ensures a couple of Wine include files are properly defined when included from C++ code. It mainly adds a extern "C" { ... } around the various definitions. The list of modified files has been determined by: - checking Wine headers without extern "C" instruction, while SDK one has it, - not all files matching that criteria have been patched (eg DDK files have been left out) - some files have been patched even if their current content doesn't require it (ie no variable nor extern function definition), esp. when their SDK equivalent has a lot of such definitions (so that the c++ guard is not forgotten when the header file is updated), - search criteria is also not 100% accurate (eg missing EXTERN_C macro). Been triggered by bcrypt.h failing to be used in C++ code (didn't test for the others). -- v2: include: Don't use C++ keywords. include: Add missing extern "C" wrappers. https://gitlab.winehq.org/wine/wine/-/merge_requests/10303

3 2

[PATCH 0/2] MR10428: icuuc: Prefer native.
by Hans Leidekker (＠hans) March 23, 2026

March 23, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10428

3 3

[PATCH v2 0/3] MR10388: dwrite: Fail loading unsupported COLRv1 fonts.
by Paul Gofman (＠gofman) March 23, 2026

March 23, 2026

-- v2: dwrite: Fail loading unsupported COLRv1 fonts. dwrite: Move opentype_get_font_table() up. dwrite: Fix second chance fonts handling in fallback_map_characters(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10388

3 4

[PATCH v4 0/2] MR10059: comctl32: Fix the bug when the cInitial is too large which lead to...
by Kun Yang (＠yangkun) March 23, 2026

March 23, 2026

I'm sorry I have pushed another mr for this topic due to my fault for pushing to the master branch of my forked project. This is about the failure of CreateDIBSection in ImageList_Create. Last discussion is in !10039 (https://gitlab.winehq.org/wine/wine/-/merge_requests/10039) I have made my last fix in https://gitlab.winehq.org/wine/wine/-/merge_requests/10039#note_129134. Please review it again @zhiyi . I am sorry for making a new merge request again. -- v4: comctl32: Fix the bug when the cInitial is too large which lead to CreateDIBSection fails. comctl32/tests: Add tests for the large cInitial in ImageList_CreateImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/10059

3 6

Re: [PATCH v2 0/1] MR10340: comctl32/tooltips: suppress icon and title when title is NULL or empty.
by Zhiyi Zhang (＠zhiyi) March 23, 2026

March 23, 2026

Please fix the CI failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10340#note_133352

1 0

[PATCH 0/5] MR10429: msxml3/tests: Add some more DOM tests.
by Nikolay Sivov (＠nsivov) March 23, 2026

March 23, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10429

2 5

[PATCH 0/1] MR10381: mmdevapi: Don't assume WAVEFORMATEX is a WAVEFORMATEXTENSIBLE.
by Yuxuan Shui (＠yshui) March 23, 2026

March 23, 2026

IAudioClient_IsFormatSupported is given a WAVEFORMATEX, we can't assume it's a WAVEFORMATEXTENSIBLE without checking its cbSize. For example, WINMM_TestFormat only passes a WAVEFORMATEX. Found by ASan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10381

3 4