March 2026 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10490: vbscript: Return specific error codes for integer constant and Property declarations.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

Add error productions in the bison grammar for two cases: - Expected integer constant in Dim array bounds (error 1026) e.g. Dim x("a") where a numeric value is required. - Expected Let, Set, or Get after Property keyword (error 1049) e.g. Property x without specifying the accessor type. Previously these fell through to the generic E_FAIL path in parser_error(). Now each sets the correct VBSE_EXPECTED_* error code via MAKE_VBSERROR before aborting the parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10490

2 1

[PATCH 0/1] MR10489: vbscript: Return specific error codes for missing keywords in parser.
by Francis De Brabandere (＠francisdb) March 29, 2026

March 29, 2026

Add error productions in the bison grammar for five cases where a specific keyword is expected after a recognized prefix: - Expected '=' after identifier in Const declaration (error 1011) - Expected 'To' after expression in For loop (error 1013) - Expected 'Then' after expression in If statement (error 1017) - Expected 'Case' after Select (error 1021) - Expected 'In' after identifier in For Each loop (error 1046) Previously these all fell through to the generic E_FAIL path in parser_error(). Now each sets the correct VBSE_EXPECTED_* error code via MAKE_VBSERROR before aborting the parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10489

2 1

[PATCH v2 0/1] MR10469: comctl32/imagelist: Allow for larger initial image count.
by Alistair Leslie-Hughes (＠alesliehughes) March 29, 2026

March 29, 2026

I have an application that uses 970+ as an valid initial value, and causes random crashes when restricted to 256. -- v2: comctl32/imagelist: Allow for larger initial image count. https://gitlab.winehq.org/wine/wine/-/merge_requests/10469

3 3

[PATCH 0/1] MR10469: comctl32/imagelist: Allow for larger initial image count.
by Alistair Leslie-Hughes (＠alesliehughes) March 29, 2026

March 29, 2026

I have an application that uses 970+ as an valid initial value, and causes random crashes when restricted to 256. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10469

3 4

Re: [PATCH v9 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs)
by Theodoros Chatzigiannakis (＠TChatzigiannakis) March 28, 2026

March 28, 2026

On Mon Mar 9 13:26:34 2026 +0000, Theodoros Chatzigiannakis wrote: > * I addressed the issue with the test, it should fail without the fix now. > * Regarding the tables, that distinction was indeed a bit too arbitrary. > Now it's based on detecting the actual data size mismatch. @hans Have you had a chance to take another look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10114#note_134237

1 0

[PATCH 0/1] MR10486: vbscript: Fix error character positions for Exit and Dim statements.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

For invalid Exit statements (e.g. Exit Do outside a Do loop), point the error position at the keyword after Exit (Do/For/Function/Property/Sub) instead of at Exit itself, matching Windows. For duplicate Dim declarations, store the identifier location in dim_decl_t and use it as the error position, so the error points at the duplicate name instead of the Dim keyword. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10486

2 1

[PATCH 0/1] MR10485: vbscript: Return proper errors for orphan Loop and Next keywords.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

When Loop or Next appear outside their enclosing Do/For blocks, Windows returns specific error codes: 1038 ("loop without do") and 1055 ("unexpected Next"). Detect these tokens in parser_error() and set the proper HRESULT instead of the generic E_FAIL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10485

2 1

[PATCH 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

[PATCH v2 0/4] MR10104: user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled
by Ivan Ivlev (＠iviv) March 28, 2026

March 28, 2026

Edit control does not release mouse capture after WM_LBUTTONDOWN has been processed two times in a row. This MR fixes this issue by releasing capture and setting it again on WM_LBUTTONDOWN if window was already captured. I have stumbled upon the app in which edit control process WM_LBUTTONDOWN twice on one mouse click. While in windows it causes no problem, wine edit does not release capture, so other buttons inside this app become unclickable. It happens because when WM_LBUTTONDOWN is processed twice, WM_CAPTURECHANGED is sent and bCaptureState is set to FALSE, then EDIT_WM_LButtonUp does not release capture because bCaptureState is already FALSE. Thing about tests: I have added test case for this problem to be visible. I also had to use todo_wine because SendMessageA for WM_LBUTTONDOWN and WM_LBUTTONUP returns 0 in wine and 1 in windows (which is not the case for combobox test, where SendMessageА for WM_LBUTTONDOWN also returns 1 in wine). -- v2: comctl32_v6/edit: Reset capture on WM_LBUTTONDOWN if already enabled user32/edit: Reset capture on WM_LBUTTONDOWN if already enabled comctl32/tests/edit.c: Test WM_LBUTTONDOWN processing user32/tests/edit.c: Test WM_LBUTTONDOWN processing https://gitlab.winehq.org/wine/wine/-/merge_requests/10104

3 6

[PATCH 0/1] MR10483: vbscript: Return "Illegal assignment" error for Const and function assignment.
by Francis De Brabandere (＠francisdb) March 28, 2026

March 28, 2026

Assigning to a Const variable or a function/sub name should return error 501 (Illegal assignment), not 445 (Object doesn't support this action). Change the REF_CONST and REF_FUNC cases in assign_ident() to use MAKE_VBSERROR(VBSE_ILLEGAL_ASSIGNMENT). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10483

2 1