March 2026 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

fixes https://bugs.winehq.org/show_bug.cgi?id=55006 -- v2: vbscript: Allow empty Else blocks in If statements. https://gitlab.winehq.org/wine/wine/-/merge_requests/10310

3 2

[PATCH v3 0/3] MR10059: comctl32: Fix the bug when the cInitial is too large which lead to...
by Kun Yang (＠yangkun) March 13, 2026

March 13, 2026

I'm sorry I have pushed another mr for this topic due to my fault for pushing to the master branch of my forked project. This is about the failure of CreateDIBSection in ImageList_Create. Last discussion is in !10039 (https://gitlab.winehq.org/wine/wine/-/merge_requests/10039) I have made my last fix in https://gitlab.winehq.org/wine/wine/-/merge_requests/10039#note_129134. Please review it again @zhiyi . I am sorry for making a new merge request again. -- v3: comctl32: Expand only when the range is exceeded in ImageList_Add. comctl32: Fix the bug when the cInitial is too large which lead to CreateDIBSection fails. comctl32/tests: Add tests for the large cInitial in ImageList_CreateImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/10059

2 3

[PATCH v2 0/3] MR10059: comctl32: Fix the bug when the cInitial is too large which lead to...
by Kun Yang (＠yangkun) March 13, 2026

March 13, 2026

I'm sorry I have pushed another mr for this topic due to my fault for pushing to the master branch of my forked project. This is about the failure of CreateDIBSection in ImageList_Create. Last discussion is in !10039 (https://gitlab.winehq.org/wine/wine/-/merge_requests/10039) I have made my last fix in https://gitlab.winehq.org/wine/wine/-/merge_requests/10039#note_129134. Please review it again @zhiyi . I am sorry for making a new merge request again. -- v2: comctl32: Expand only when the range is exceeded in ImageList_Add. comctl32: Fix the bug when the cInitial is too large which lead to CreateDIBSection fails. comctl32/tests: Add tests for the large cInitial in ImageList_CreateImage. https://gitlab.winehq.org/wine/wine/-/merge_requests/10059

1 1

[PATCH 0/1] MR10325: comctl32: Fix some typos in the comments.
by Nikolay Sivov (＠nsivov) March 13, 2026

March 13, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10325

3 3

Re: [PATCH v2 0/6] MR10299: libs: Import C++ standard libraries.
by Anton Baskanov (＠baskanov) March 13, 2026

March 13, 2026

On Fri Mar 13 08:31:10 2026 +0000, Michael Stefaniuc wrote: > @baskanov would be a way better reviewer for the `fluidsynth: Import > upstream release 2.4.3.` commit. > I know he worked with upstream fluidsynth. Weirdly, I get a sudden volume increase of the drums in some MIDI files. It wasn't like this before this patch. Haven't figured out what's going on exactly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10299#note_132161

1 0

[PATCH 0/3] MR10249: Typos
by Diego Colin (＠docolta) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10249

4 11

Re: [PATCH v4 0/1] MR10294: Fix start word position \\<
by Hans Leidekker (＠hans) March 13, 2026

March 13, 2026

Hans Leidekker (@hans) commented about programs/findstr/main.c: > static BOOL match_regexp(const char *str, const char *regexp, BOOL case_sensitive) > { > if (strstr(regexp, "[")) FIXME("character ranges (i.e. [abc], [^a-z]) are not supported\n"); > - if (strstr(regexp, "\\<") || strstr(regexp, "\\>")) FIXME("word position (i.e. \\< and \\>) not supported\n"); > + if (strstr(regexp, "\\<") != regexp || strstr(regexp, "\\>")) FIXME("word position (i.e. \\< and \\>) not supported\n"); Now the fixme will also printed for every regexp that where \\< doesn't occur. The condition should be something like this: `if ((strstr(regexp, "\\<") && strstr(regexp, "\\<") != regexp) || strstr(regexp, "\\>"))` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10294#note_132155

1 0

[PATCH v7 0/6] MR10126: mf: Implement Scrubbing in SAR.
by Brendan McGrath (＠redmcg) March 13, 2026

March 13, 2026

This MR adds the `IMFPresentationTimeSource` interface to SAR and adds support for scrubbing. -- v7: mf: Report seek time up until we render past this point. mf: Discard samples prior to current seek time. mf: Implement Scrubbing in SAR. mf: Check provided presentation clock has a time source. mf: Implement presentation time source for SAR. mf: Replace state variable with clock_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/10126

3 9

[PATCH 0/1] MR10323: mxsml3/tests: Add tests for put_text.
by Daniel Lehman (＠dlehman25) March 13, 2026

March 13, 2026

https://gitlab.winehq.org/wine/wine/-/merge_requests/10202#note_132045 calling IXMLDOMNode_put_text on a text node leads to xmlTextSetContent in libxml2 which duplicates the text (xmlStr[n]dup) and frees the old content before setting the new calling IXMLDOMElement_put_text on an element node leads to xmlNodeParseContent in libxml2 which sets the text on the xmlNode's child and calls xmlFreeNodeList to free the old content an IXMLDOMNode reference to that internal text node holds a pointer to that freed content and crashes on IXMLDOMNode_Release <open> <-- IXMLDOMElement_put_text -> xmlNodeParseContent frees old 'content' held by IXMLDOMNode below sesame <-- IXMLDOMNode_Release on this node double-frees 'content' freed above </open> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10323

3 2

[PATCH v2 0/4] MR10261: Fix toolbar wrapping issues
by Ivan Ivlev (＠iviv) March 13, 2026

March 13, 2026

This MR resolves two bugs with toolbar wrapping I have discovered. 1. Toolbar missing four buttons when app window is maximized (wrap should not appear at all in this case). 2. Last toolbar button disappears when window size (toolbar size) is slightly narrower then button right border. Reasons of this behavior: 1. Toolbar buttons have BTNS_AUTOSIZE style, toolbar width is set using CCS_NORESIZE and equals to widths of all autosized buttons combined. cx (button width) value in TOOLBAR_WrapToolbar is set from nButtonWidth, which contains widest button width. Since buttons in toolbar have different widths, TOOLBAR_WrapToolbar miscalculates total width, because actual buttons widths are less then nButtonWidth. This results in TOOLBAR_WrapToolbar setting TBSTATE_WRAP when it is not not needed, and since app does not paint second button row, wrapped buttons just disappear. 2. After I fixed first issue, I noticed, that last button disappears, when toolbar become narrower then its right border. Then, when toolbar right border approximately in the middle of disappeared button, wrap happens. In windows system, wrapping occurs immediately when toolbar becomes narrower. Found solutions: 1. I noticed, that TOOLBAR_LayoutToolbar calculates buttons rects differently, thats because it checks if button have BTNS_AUTOSIZE style and then calculate size. So i moved this BTNS_AUTOSIZE size calculation in separate function for it to then be used in TOOLBAR_LayoutToolbar and TOOLBAR_WrapToolbar to guarantee that cx values for specific button will be equal in both functions. 2. TOOLBAR_WrapToolbar function decides to wrap in case `if ((x + cx - (infoPtr->nButtonWidth - infoPtr->nBitmapWidth) / 2 > width).` This `(infoPtr->nButtonWidth - infoPtr->nBitmapWidth) / 2` turns out, makes this gap, where button right border (x + cx) exceed toolbar right border (width), but wrap wont appear. I did not found any reasons to make this half-button gap, so I just removed it and it solved this issue. The comment above says /\* The layout makes sure the bitmap is visible, but not the button. \*/, but it was introduced in 1999, when TOOLBAR_LayoutToolbar did not existed, and I think its irrelevant now, since layout calculates cx taking both bitmap and string into account. I wrote tests for both fixes: 1. Creates CCS_NORESIZE toolbar, then add BTNS_AUTOSIZE buttons of different widths one by one and checks if wrap happened. In normal case (in windows) wrap should only happen on fourth button, but without fix wrap happens on third. 2. Creates CCS_NORESIZE toolbar with 4 BTNS_AUTOSIZE buttons. Toolbar width at the creation is calculated beforehand and equals exactly buttons widths combined. Then test reduces toolbar width by 1 and checks if wrap happened, in normal case wrap happens, without the fix its not. -- v2: comctl32/toolbar.c: Wrap toolbar immediately after width exceeded comctl32/tests/toolbar.c: Test wrapping occurs immediately when needed https://gitlab.winehq.org/wine/wine/-/merge_requests/10261

2 4