March 2026 - Wine-GitLab - list.winehq.org

[PATCH v2 0/2] MR10305: mfmediaengine: Add IMFMediaEngineClassFactoryEx interface.
by Paul Gofman (＠gofman) March 12, 2026

March 12, 2026

-- v2: mfmediaengine: Add IMFMediaEngineClassFactoryEx interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/10305

3 5

[PATCH 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

3 3

[PATCH 0/1] MR10316: d2d1: Do not reference layer objects when recording to the command list.
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10316

2 1

[PATCH 0/1] MR10315: mfplay: Remove incorrect fixme for MFP_EVENT_TYPE_ERROR.
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

This type is already handled, no need for such message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10315

2 1

[PATCH v3 0/5] MR9777: mfplat: Implement mf d3d12 synchronization object.
by Charlotte Pabst (＠CharlottePabst) March 12, 2026

March 12, 2026

I'm also working on tests & implementation for d3d12-backed IMFMediaBuffers and sample allocators, submitting this here to receive some feedback while working on more. Sorry if the tests are too involved, perhaps they could be simplified, but since there is very little documentation on this I had to figure out a lot of minor details using tests. The use case is Fuga Melodies of Steel 3 which uses the UE5 electra decoder plugin. It expects d3d12 support in media foundation (sample allocator, media buffer, sync object). This game doesn't require implementing proper d3d12 video decoding, only that frame data is stored in a IMFMediaBuffer that is backed by a ID3D12Resource. Once finished, this feature would presumably help with other UE5 games that have similar usage patterns as well (All the code for it is in UE5, which is source-available). Other real world examples are limited, but I believe chromium and mesa have some optional code using this feature. MFCreateD3D12SynchronizationObject is (presumably) used by MFCreateDXGISurfaceBuffer to create a synchronization object for the buffer (I already have some tests that query and use the synchronization object from a d3d12-backed mediabuffer, which I will submit together with the other d3d12 buffer tests.) -- v3: mfplat: Use freelist for mfd3d12 syncobj release. mfplat/tests: Test that mfd3d12 syncobj release keeps working through multiple resets. mfplat: Implement mf d3d12 synchronization object. mfplat/tests: Add tests for mf d3d12 synchronization object. mfd3d12.h: Add some missing definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/9777

2 6

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

I'm not the one responsible for this area, but I added my comments. If there are any applications or bug reports depending on the behavior you suggest, please let us know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132030

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > + > + nt_header.FileHeader.NumberOfSections = 1; > + nt_header.FileHeader.SizeOfOptionalHeader = sizeof(IMAGE_OPTIONAL_HEADER); > + > + nt_header.OptionalHeader.SectionAlignment = page_size; > + nt_header.OptionalHeader.DllCharacteristics = IMAGE_DLLCHARACTERISTICS_NX_COMPAT | IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE; > + nt_header.OptionalHeader.FileAlignment = page_size; > + nt_header.OptionalHeader.SizeOfHeaders = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER); > + nt_header.OptionalHeader.SizeOfImage = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + page_size; > + > + create_test_dll( &dos_header, sizeof(dos_header), &nt_header, dll_name_a ); > + mod = LoadLibraryA( dll_name_a ); > + ok(mod != NULL, "can't load test dll\n"); > + if (mod != NULL) > + { > + dll_name[0] = 0; Likewise below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132029

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); It would be better to avoid using magic numbers and use `'\t'` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132028

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/loader.c: > SetLastError( RtlNtStatusToDosError( status )); > done: > TRACE( "%s\n", debugstr_wn(filename, len) ); > + if (!status || status == STATUS_BUFFER_TOO_SMALL) > + { > + if (len < size) > + filename[len] = 0; > + else if (size > 0) Consider adding a test for the false case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132027

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/loader.c: > SetLastError( RtlNtStatusToDosError( status )); > done: > TRACE( "%s\n", debugstr_wn(filename, len) ); > + if (!status || status == STATUS_BUFFER_TOO_SMALL) > + { > + if (len < size) > + filename[len] = 0; > + else if (size > 0) > + filename[size - 1] = 0; Does this also apply to the Win16 case? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132026

1 0