March 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR10518: wscript: Implement error messages, usage output, and //nologo banner.
by Jacek Caban (＠jacek) March 31, 2026

March 31, 2026

Jacek Caban (@jacek) commented about programs/wscript/tests/run.c: > + > +static void run_cscript_unknown_option_test(void) > +{ > + char stdout_buf[4096], stderr_buf[4096]; > + DWORD exit_code; > + > + exit_code = run_cscript("//nologo /unknownoption", stdout_buf, sizeof(stdout_buf), > + stderr_buf, sizeof(stderr_buf)); > + if(exit_code == ~0u) > + return; > + ok(exit_code == 1, "exit_code = %lu, expected 1\n", exit_code); > + /* On Windows, cscript reports "Unknown option" on stdout. On Wine, > + * unrecognized options are treated as filenames to allow Unix-style > + * paths (/tmp/foo.vbs), so the error will be about the file instead. */ > + ok(strstr(stdout_buf, "Unknown option") != NULL || strstr(stdout_buf, "Can not find") != NULL, > + "expected error on stdout, got: %s\n", stdout_buf); Aren't those error messages localized on Windows? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10518#note_134530

1 0

[PATCH v2 0/2] MR10521: Certsetcertificatecontextproperty cert ncrypt key handle prop id
by Benoît Legat (＠blegat) March 31, 2026

March 31, 2026

This is part of my attempt to run the [Niko Home Control programming software](https://appdb.winehq.org/objectManager.php?sClass=application&iId… under Wine. This (.NET 8 / Electron app) is performing mTLS with a [Connected controller voor Niko Home Control II](https://products.niko.eu/nl-be/article/550-00003). Doing this, it calls `CertSetCertificateContextProperty` with `CERT_NCRYPT_KEY_HANDLE_PROP_ID`. Wine currently does not implement setting this property so it falls through to the default case, with the \``FIXME("%ld: stub\n", dwPropId);` that lead me to try to implement it. This patch seems to work for the Niko Home Control app so I added test to contribute it upstream. According to [the documentation](https://learn.microsoft.com/en-us/windows/win32/api/wincrypt…, `dwKeySpec` should be set to `CERT_NCRYPT_KEY_SPEC`. This value didn't seem to be defined yet in Wine so I added its definition. [Its value seems to be \`0xffffffff\`](https://android.googlesource.com/toolchain/mingw/+/refs/heads/main/mingw-w64-v6.x/mingw-w64-headers/include/wincrypt.h#3434). I added tests. Before the changes in `dlls/crypt32/cert.c`, running the tests with `wine 11.5-1` (current version on ArchLinux) the tests give 7 failures: ``` $ wine dlls/crypt32/tests/x86_64-windows/crypt32_test-stripped.exe cert 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:CertContext_SetProperty 78: stub cert.c:553: Test failed: CertSetCertificateContextProperty failed: 80092004 cert.c:559: Test failed: CertGetCertificateContextProperty failed: 80092004 cert.c:560: Test failed: Expected hCryptProv 0xBEEF1234, got 0 cert.c:562: Test failed: Expected dwKeySpec CERT_NCRYPT_KEY_SPEC, got 2 cert.c:569: Test failed: CertGetCertificateContextProperty failed: 80092004 cert.c:570: Test failed: Expected handle 0xBEEF1234, got 0 0024:fixme:crypt:CertContext_SetProperty 78: stub cert.c:587: Test failed: CertSetCertificateContextProperty failed: 80092004 0024:fixme:crypt:CertAddCertificateLinkToStore (00007FFFFE871940, 00007FFFFE8530D8, 00000001, 00007FFFFE1FFB50): semi-stub 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"_SHOULDNOTEXIST_" not supported 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CryptVerifyCertificateSignatureEx unimplemented for NULL signer 0024:fixme:cryptasn:CRYPT_GetBuiltinEncoder Unimplemented encoder for lpszStructType OID 0 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CertGetPublicKeyLength unimplemented for DH public keys 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 7 0020:cert: 649 tests executed (0 marked as todo, 0 as flaky, 7 failures), 0 skipped. ``` After applying my patches like so ``` sudo cp dlls/crypt32/x86_64-windows/crypt32.dll /usr/lib/wine/x86_64-windows/crypt32.dll sudo cp dlls/crypt32/crypt32.so /usr/lib/wine/x86_64-unix/crypt32.so ``` I get 0 failures: ``` $ wine dlls/crypt32/tests/x86_64-windows/crypt32_test-stripped.exe cert 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:add_cert_to_store Unimplemented add disposition 0 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:CertAddCertificateLinkToStore (00007FFFFE872F70, 00007FFFFE854988, 00000001, 00007FFFFE1FFB50): semi-stub 0024:fixme:crypt:Collection_release Unimplemented flags 2 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:crypt:ProvStore_release Unimplemented flags 2 0024:fixme:crypt:CRYPT_RegCloseStore Unimplemented flags: 00000002 0024:fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"_SHOULDNOTEXIST_" not supported 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CryptVerifyCertificateSignatureEx unimplemented for NULL signer 0024:fixme:cryptasn:CRYPT_GetBuiltinEncoder Unimplemented encoder for lpszStructType OID 0 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 1 0024:fixme:crypt:CertGetPublicKeyLength unimplemented for DH public keys 0024:fixme:cryptasn:CryptDecodeObjectEx Unimplemented decoder for lpszStructType OID 7 0020:cert: 649 tests executed (0 marked as todo, 0 as flaky, 0 failures), 0 skipped. ``` Let me know if there is anything else I can do to help, this is my first contribution to this project. -- v2: Try fixing the tests to match Windows behavior https://gitlab.winehq.org/wine/wine/-/merge_requests/10521

3 4

[PATCH v7 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v7: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

[PATCH v6 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v6: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

Re: [PATCH v9 0/3] MR10114: msi: Handle unusual installer files (padding, malformed strrefs) - approved
by Hans Leidekker (＠hans) March 31, 2026

March 31, 2026

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10114

1 0

[PATCH v5 0/1] MR10363: vbscript: Support assignment to chained array index expressions.
by Francis De Brabandere (＠francisdb) March 31, 2026

March 31, 2026

Handle expressions like x(0)(1) = 5 where the left side of an assignment is a call expression whose inner expression is also a call (not a direct member). The compiler now evaluates the inner expression as a read, then emits a new OP_assign_call opcode to assign to the resulting array element or default dispatch property. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53877 _Side note: https://bugs.winehq.org/show_bug.cgi?id=58318 is a duplicate of that bug_ -- v5: vbscript: Support assignment to chained array index expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10363

2 1

Re: [PATCH v3 0/1] MR6770: [ntdll] fix unwind compilation failure for android - closed
by Alexandre Julliard (＠julliard) March 31, 2026

March 31, 2026

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6770

1 0

Re: [PATCH v3 0/1] MR6770: [ntdll] fix unwind compilation failure for android
by Alexandre Julliard (＠julliard) March 31, 2026

March 31, 2026

libunwind is no longer used since e7439f1be35f005cad6de8d84f19d2ab8f6e85b8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6770#note_134518

1 0

[PATCH v6 0/4] MR8030: Draft: wineserver: Allow NtOpenFile with read-only files.
by Joel Holdsworth (＠jhol) March 31, 2026

March 31, 2026

Co-authored-by: Bernhard Übelacker <bernhardu(a)mailbox.org> -- v6: server: Open file read-only when writing only attributes. server: Open code FILE_UNIX_READ_ACCESS flags. server: Open code FILE_UNIX_WRITE_ACCESS flags. ntdll/tests: Test opening read-only files only for read/write attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/8030

4 8

[PATCH v37 0/1] MR10192: Draft: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Vishnunithyasoundhar S (＠svishnunithyasoundhar) March 31, 2026

March 31, 2026

``` Support the \\?\ prefix by skipping it during path resolution while preserving it in the output. Added specific handling for extended UNC paths (\\?\UNC\) to mirror standard UNC behavior, ensuring these paths are treated as network shares and not local devices. Some paths that use the extended length path were filtered out as UNC paths - but not all of them are UNC. There can be UNC path that use extended length path but not all extended length paths are UNC paths. ``` Signed-off-by: Vishnunithyasoundhar S svishnunithyasoundhar(a)gmail.com -- v37: kernelbase: Handle extended length path prefix in GetLongPathNameW https://gitlab.winehq.org/wine/wine/-/merge_requests/10192

2 1