April 2026 - Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR10766: Draft: vbscript: Fix and expand test coverage for BSTR comparison.
by Francis De Brabandere (＠francisdb) April 28, 2026

April 28, 2026

Follow-up to !10314 ([Wine-Bug 56281](https://bugs.winehq.org/show_bug.cgi?id=56281)) Expanding test coverage and fixing a divergence from Windows VBScript that the original change didn't cover. -- v2: vbscript: String-compare BSTR vs VT_UI1 / VT_CY. https://gitlab.winehq.org/wine/wine/-/merge_requests/10766

2 4

[PATCH v2 0/1] MR10762: vbscript/tests: Add coverage for BSTR vs numeric comparison.
by Francis De Brabandere (＠francisdb) April 28, 2026

April 28, 2026

Add assertions for locale-invariant numeric-string forms ("+5", "-0", "05", " 5", "5 ", "5e0") and for type-mismatch errors raised when an unparseable BSTR ("abc", "", " ") is compared to a number with =, <> or a relational operator. -- v2: vbscript/tests: Add coverage for BSTR vs numeric comparison. https://gitlab.winehq.org/wine/wine/-/merge_requests/10762

2 3

[PATCH 0/1] MR10764: vbscript: Convert boolean to BSTR for BSTR vs Boolean comparison.
by Francis De Brabandere (＠francisdb) April 28, 2026

April 28, 2026

VarCmp falls into its "BSTR always greater" branch for BSTR vs VT_BOOL, so every "True" = True / "False" = False returned False on Wine. VBScript coerces the boolean to its CStr form ("True"/"False") and string-compares; comparison is binary, not locale-aware (matches "abc" > True returning True on Windows). VarBstrFromBool / VariantChangeType yield "-1"/"0" (OLE numeric convention) and don't match what VBScript uses, so the strings are hardcoded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10764

2 3

[PATCH 0/7] MR10767: msado15: _Recordset::Find and _Recordset::CursorLocation improvements.
by Piotr Caban (＠piotr) April 28, 2026

April 28, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10767

2 7

[PATCH 0/3] MR10766: Draft: vbscript: Fix and expand test coverage for BSTR comparison.
by Francis De Brabandere (＠francisdb) April 28, 2026

April 28, 2026

Follow-up to !10314 ([Wine-Bug 56281](https://bugs.winehq.org/show_bug.cgi?id=56281)) Expanding test coverage and fixing a divergence from Windows VBScript that the original change didn't cover. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10766

2 3

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

On Tue Apr 28 12:28:43 2026 +0000, Jon Koops wrote: > Thanks for the review @Mystral, I'll see if I can incorporate the > feedback. As for the style of the tests, what would you like it to look > like? I used the existing tests for dsound as a reference to implement > the new ones added here. My preference would be for something like my suggested changes, or the test immediately above yours. To be clear, there's nothing wrong on your part: I'm just a bit annoyed that there's so much old code around that makes for bad style examples :sweat_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137977

1 0

[PATCH 0/3] MR10631: usp10/tests: Update to new fallback fonts.
by समीरसिंह Sameer Singh (＠ss141309) April 28, 2026

April 28, 2026

Updated the test cases for https://gitlab.winehq.org/wine/wine/-/merge_requests/10630 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10631

2 4

[PATCH 0/2] MR10630: gdi32/uniscribe: Update fallback fonts to use Noto fonts.
by समीरसिंह Sameer Singh (＠ss141309) April 28, 2026

April 28, 2026

This aligns uniscribe with dwrite behaviour and ensures better out of the box experience for systems where Microsoft fonts are typically unavailable. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27641 Regarding the "Update the script tag for Tamil" commit, the proper solution would be to mimic dwrite and use an array for the script tags and adjust the functions accordingly. I did not do this in the hope that in the future both uniscribe and dwrite will utilise Harfbuzz. This would fix a lot more issues including this. The current solution is a band-aid, so that atleast the tests pass and the font is visible when typed. The updated tests will be in a separate MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10630

3 7

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Jon Koops (＠jonkoops) April 28, 2026

April 28, 2026

Thanks for the review @Mystral, I'll see if I can incorporate the feedback. As for the style of the tests, what would you like it to look like? I used the existing tests for dsound as a reference to implement the new ones added here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137962

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

The MR looks good in principle. It's a bit unfortunate that you happened to follow the style of older tests, which I find quite ugly, but alas. One thing that I'd like to see here is a second "instance" of the same test but checking `DirectSoundCreate8()` (see dsound8.c). It's probably unlikely that it will show different results, but this is a good time to look for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137960

1 0