April 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

On Tue Apr 28 10:49:16 2026 +0000, Jon Koops wrote: > Also note that DirectSoundDevice-\>ref can now be cleaned up, as there > isn't any actual ref counting happening anymore, it is only ever set to > 1, and then set to 0, which immediately destroys the device right after. > However, I have opted to keep that cleanup out of this PR to keep it > simple to review. I'll see if that can be handled in a follow up PR. Thumb up on that. I'll also point out that `DirectSoundDevice` is not a public API but just an internal object, so this refcounting (or lack thereof) is not going to affect anything visible outside. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137959

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + { > + rc=IDirectSoundBuffer_GetVolume(primary2,&vol); > + ok(rc==DS_OK, > + "IDirectSoundBuffer_GetVolume(primary2) failed: %08lx\n",rc); > + } > + > + /* Verify dso2's primary buffer has CTRLVOLUME */ > + ZeroMemory(&bufcaps, sizeof(bufcaps)); > + bufcaps.dwSize=sizeof(bufcaps); > + rc=IDirectSoundBuffer_GetCaps(primary2,&bufcaps); > + ok(rc==DS_OK,"IDirectSoundBuffer_GetCaps(primary2) failed: %08lx\n",rc); > + if (rc==DS_OK) { > + todo_wine > + ok(bufcaps.dwFlags & DSBCAPS_CTRLVOLUME, > + "primary2 should have DSBCAPS_CTRLVOLUME: %08lx\n",bufcaps.dwFlags); > + } ```suggestion:-9+0 memset(&caps, 0, sizeof(caps)); caps.dwSize = sizeof(caps); hr = IDirectSoundBuffer_GetCaps(primary2, &caps); ok(hr == DS_OK, "Unexpected hr %08lx\n", hr); todo_wine ok(bufcaps.dwFlags & DSBCAPS_CTRLVOLUME, "Unexpected dwFlags %08lx\n", caps.dwFlags); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137958

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + "IDirectSound_CreateSoundBuffer(dso2) failed: %08lx\n",rc); > + if (rc!=DS_OK || primary2==NULL) > + goto RELEASE1; > + > + /* Check whether the two IDirectSound objects share a primary buffer */ > + todo_wine > + ok(primary1!=primary2, > + "Two IDirectSound objects should have independent primary buffers\n"); > + > + /* GetVolume on dso2's primary buffer should succeed */ > + todo_wine > + { > + rc=IDirectSoundBuffer_GetVolume(primary2,&vol); > + ok(rc==DS_OK, > + "IDirectSoundBuffer_GetVolume(primary2) failed: %08lx\n",rc); > + } ```suggestion:-6+0 hr = IDirectSoundBuffer_GetVolume(primary2, &vol); todo_wine ok(hr == DS_OK, "Unexpected hr %08lx\n", hr); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137957

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) > + return; > + > + rc=DirectSoundCreate(NULL,&dso2,NULL); > + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) { > + IDirectSound_Release(dso1); > + return; > + } > + > + rc=IDirectSound_SetCooperativeLevel(dso1,get_hwnd(),DSSCL_PRIORITY); > + ok(rc==DS_OK,"IDirectSound_SetCooperativeLevel(dso1) failed: %08lx\n",rc); > + if (rc!=DS_OK) > + goto EXIT; It doesn't look like this can legitimately fail (i.e. we leave the test only after flagging a test failure). The `if` should go. I know that there are existing tests that do exactly the same, but those should be ideally fixed and we don't want to add more of this bad pattern. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137955

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + goto EXIT; > + > + rc=IDirectSound_SetCooperativeLevel(dso2,get_hwnd(),DSSCL_PRIORITY); > + ok(rc==DS_OK,"IDirectSound_SetCooperativeLevel(dso2) failed: %08lx\n",rc); > + if (rc!=DS_OK) > + goto EXIT; > + > + /* Create a primary buffer on dso1 with CTRL3D but without CTRLVOLUME */ > + ZeroMemory(&bufdesc, sizeof(bufdesc)); > + bufdesc.dwSize=sizeof(bufdesc); > + bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER|DSBCAPS_CTRL3D; > + rc=IDirectSound_CreateSoundBuffer(dso1,&bufdesc,&primary1,NULL); > + ok(rc==DS_OK && primary1!=NULL, > + "IDirectSound_CreateSoundBuffer(dso1) failed: %08lx\n",rc); > + if (rc!=DS_OK || primary1==NULL) > + goto EXIT; Similarly here and below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137956

1 0

Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) April 28, 2026

April 28, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c: > + DSBCAPS bufcaps; > + LONG vol; > + > + rc=DirectSoundCreate(NULL,&dso1,NULL); > + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) > + return; > + > + rc=DirectSoundCreate(NULL,&dso2,NULL); > + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, > + "DirectSoundCreate() failed: %08lx\n",rc); > + if (rc!=DS_OK) { > + IDirectSound_Release(dso1); > + return; > + } I think we should require the second `DirectSoundCreate()` call to return successfully if the first one goes through. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137954

1 0

Re: [PATCH v6 0/2] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 28, 2026

April 28, 2026

Base tests seem to be passing @julliard . Should add ones customary to the feature? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10737#note_137953

1 0

[PATCH 0/5] MR10763: opengl32: Generate code to call the get_integer hooks.
by Rémi Bernon (＠rbernon) April 28, 2026

April 28, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10763

2 5

[PATCH 0/5] MR10716: dsound: Speed up resampling, part 6
by Anton Baskanov (＠baskanov) April 28, 2026

April 28, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10716

3 10

[PATCH 0/1] MR10762: vbscript/tests: Add coverage for BSTR vs numeric comparison.
by Francis De Brabandere (＠francisdb) April 28, 2026

April 28, 2026

Add assertions for locale-invariant numeric-string forms ("+5", "-0", "05", " 5", "5 ", "5e0") and for type-mismatch errors raised when an unparseable BSTR ("abc", "", " ") is compared to a number with =, <> or a relational operator. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10762

2 1