April 2026 - Wine-GitLab - list.winehq.org

[PATCH 0/3] MR10754: mf/session: Initialise the stored presentation rate.
by Conor McCarthy (＠cmccarthy) April 27, 2026

April 27, 2026

The latest argument passed to SetRate() is stored in presentation.rate, but if the client never called SetRate(), the stored rate remains zero, which results in preroll not being enabled. That could be fixed by instead calling GetRate() before enabling preroll, but always setting the stored rate reduces the risk of regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10754

3 5

[PATCH v3 0/3] MR10743: small odbc fixes
by Ivan Ivlev (＠iviv) April 27, 2026

April 27, 2026

1)odbc32: compare strings case-insensitively in get_driver_filename() Driver names should be compared without case-sensetivity. unixODBC has no problems when testDSN got "Driver = SQLite3" instead of "Driver = SQLITE3" https://learn.microsoft.com/en-us/openspecs/sql_server_protocols/ms-odbcstr… 2)odbc32: skip set_value for NULL filename in replicate_odbc_to_registry() get_driver_filename can return NULL, for example when \~/.odbc.ini contains driver that has been deleted. We want to prevent SIGSEGV because of wcslen(filename) when filename is NULL. 3)odbc32: check if row_number is NULL in param_options_unix() According to documentation, SQLParamOptions can accept NULL row_number. Now when NULL row_nuber is passed, crash happens 4)odbc32: make sure ODBC_CALL returns SQLRETURN Not sure about this one, need opinion. The targeted problem: now ODBC_CALL return SQLRETURN which is truncated from NTSTATUS. If WINE_UNIX_CALL fails at some point, ODBC_CALL returns truncated NTSTATUS error code, STATUS_ACCESS_VIOLATION (0xC0000005) truncated to 5, then function gets invalid SQLRETURN. The following solution checks of NTSTATUS is actually short SQLRETURN casted to NTSTATUS. -- v3: odbc32: Check if row_number is NULL in param_options_unix(). odbc32: Skip set_value for NULL filename in replicate_odbc_to_registry(). odbc32: Compare strings case-insensitively in get_driver_filename(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10743

2 4

[PATCH v3 0/2] MR10750: msado15: Handle BSTR bookmarks in _Recordset::Find.
by Piotr Caban (＠piotr) April 27, 2026

April 27, 2026

-- v3: msado15: Handle empty BSTR bookmark in _Recordset::Find. https://gitlab.winehq.org/wine/wine/-/merge_requests/10750

2 2

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Thanks for the patches. I have some comments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137728

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/winscard.c: > return SCARD_S_SUCCESS; > } > > +/* subkey of the db in HKLM */ > +const WCHAR* SUBKEY_SMARTCARDS_DATABASE = L"SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards"; > + > +/******************************************************************************* > + * SCardGetCardTypeProviderNameW (winscard.@) > + * > + * Return the name of the "provider" that handles the given type of card. > + * Depending on the value of `provider_id`, this return either the name of the DLL, crypto provider, or key storage provider. We no longer do function documentation. We can refer to MSDN instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137727

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > + ok(len == wcslen(provider)+1, "bad length from SCardGetCardTypeProviderNameW: got %lu, expected %Iu\n", len, wcslen(provider)+1); > + SCardFreeMemory(ctx, provider); > + > + ret = SCardReleaseContext(ctx); > + ok(ret == ERROR_SUCCESS, "failed to release context: error %ld\n", ret); > +} > + > +static void test_smartcard_db(void) > +{ > + LONG ret; > + > + ret = populate_smartcard_db(); > + ok(ret == ERROR_SUCCESS, "failed to populate database: error %ld\n", ret); > + if (ret) return; > + > + test_SCardGetCardTypeProviderName(); This function could be omitted if you call populate_smartcard_db() first in test_SCardGetCardTypeProviderName(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137726

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > + if (ret) return ret; > + > + ret = RegCloseKey(key_card1); > + if (ret) return ret; > + ret = RegCloseKey(key_card2); > + if (ret) return ret; > + ret = RegCloseKey(key_db); > + if (ret) return ret; > + > + return 0; > +} > + > +static void test_SCardGetCardTypeProviderName(void) > +{ > + LONG ret; > + SCARDCONTEXT ctx = 0; /* SCardGetCardTypeProviderName does not need a context */ In that case you should just pass 0 directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137725

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > + > + ret = create_empty_key(HKEY_LOCAL_MACHINE, SUBKEY_SMARTCARDS_DATABASE, &key_db); > + ok(ret == ERROR_SUCCESS, "failed to create an empty %s: %ld\n", SUBKEY_SMARTCARDS_DATABASE, ret); > + > + ret = RegCreateKeyExA(key_db, CARD_NAME_1, 0, NULL, 0, KEY_WRITE, NULL, &key_card1, NULL); > + if (ret) return ret; > + ret = RegCreateKeyExA(key_db, CARD_NAME_2, 0, NULL, 0, KEY_WRITE, NULL, &key_card2, NULL); > + if (ret) return ret; > + > + ret = RegSetValueExA(key_card1, "Crypto Provider", 0, REG_SZ, (const BYTE*)crypto_provider_1, strlen(crypto_provider_1)); > + if (ret) return ret; > + ret = RegSetValueExA(key_card2, "Crypto Provider", 0, REG_SZ, (const BYTE*)crypto_provider_2, strlen(crypto_provider_2)); > + if (ret) return ret; > + > + ret = RegSetValueExA(key_card1, "Smart Card Key Storage Provider", 0, REG_SZ, (const BYTE*)storage_provider_1, strlen(storage_provider_1)); > + if (ret) return ret; Please wrap lines when they exceed 120 characters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137724

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > + ret = RegOpenKeyExA(hkey, name, 0, KEY_READ|KEY_WRITE, &key); > + if (ret == ERROR_SUCCESS) { > + ret = RegDeleteTreeA(key, NULL); > + if (ret != ERROR_SUCCESS) { > + return ret; > + } > + } > + ret = RegCreateKeyExA(hkey, name, 0, NULL, 0, KEY_READ|KEY_WRITE, NULL, open_key, NULL); > + return ret; > +} > + > +const char* SUBKEY_SMARTCARDS_DATABASE = "SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards"; > +const char *CARD_NAME_1 = "PKI-test-1"; > +const char *CARD_NAME_2 = "PKI-test-2"; > +const WCHAR *CARD_NAME_1L = L"PKI-test-1"; > +const WCHAR *CARD_NAME_2L = L"PKI-test-2"; Please use lower-case for the variables. The convention is to use a W suffix for wide character strings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137723

1 0

Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)
by Hans Leidekker (＠hans) April 27, 2026

April 27, 2026

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c: > } > > +static LSTATUS create_empty_key(HKEY hkey, LPCSTR name, PHKEY open_key) > +{ > + HKEY key; > + LSTATUS ret; > + > + ret = RegOpenKeyExA(hkey, name, 0, KEY_READ|KEY_WRITE, &key); > + if (ret == ERROR_SUCCESS) { > + ret = RegDeleteTreeA(key, NULL); > + if (ret != ERROR_SUCCESS) { > + return ret; > + } > + } > + ret = RegCreateKeyExA(hkey, name, 0, NULL, 0, KEY_READ|KEY_WRITE, NULL, open_key, NULL); > + return ret; ``` return RegCreateKeyExA(hkey, name, 0, NULL, 0, KEY_READ|KEY_WRITE, NULL, open_key, NULL); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137722

1 0