April 2026 - Wine-GitLab - list.winehq.org

[PATCH v14 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v14: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v13 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v13: vbscript: Pass script LCID to VariantChangeType in to_string helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v12 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v12: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v22 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v22: vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. vbscript: Bind local variable assignments at compile time. vbscript: Factor out assign_local_var from assign_ident. vbscript: Bind local variables and arguments at compile time. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 6

[PATCH 0/4] MR10742: msado15: Add partial implementation of IRowsetFind::FindNextRow in rowset wrapper.
by Piotr Caban (＠piotr) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10742

2 4

[PATCH v2 0/6] MR10739: opengl32/tests: Test object names allocation and sharing.
by Rémi Bernon (＠rbernon) April 24, 2026

April 24, 2026

-- v2: opengl32/tests: Test object types shared namespaces. opengl32/tests: Test wglShareLists sharing of GLsync objects. opengl32/tests: Test wglShareLists sharing of various types. opengl32/tests: Test implicit object allocation support. opengl32/tests: Declare and load every GL/WGL functions. opengl32/tests: Remove unnecessary window creation check. https://gitlab.winehq.org/wine/wine/-/merge_requests/10739

2 7

[PATCH v11 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v11: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

2 1

[PATCH 0/6] MR10739: opengl32/tests: Test object names allocation and sharing.
by Rémi Bernon (＠rbernon) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10739

3 7

[PATCH v10 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v10: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

3 2

Re: [PATCH v4 0/1] MR10456: vbscript: Implement DatePart built-in function. - approved
by Jacek Caban (＠jacek) April 24, 2026

April 24, 2026

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10456

1 0