April 2026 - Wine-GitLab - list.winehq.org

[PATCH v11 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 24, 2026

April 24, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v11: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* functions. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

3 6

[PATCH 0/3] MR10741: msxml3: Support for max-element-depth property.
by Nikolay Sivov (＠nsivov) April 24, 2026

April 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10741

2 3

[PATCH 0/6] MR10740: msxml3: Improvements to node name validation.
by Nikolay Sivov (＠nsivov) April 24, 2026

April 24, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10740

2 6

[PATCH 0/3] MR10738: urlmon,itss: Fix -Wunused-but-set-global warnings.
by Jacek Caban (＠jacek) April 24, 2026

April 24, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10738

2 3

[PATCH v5 0/2] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 24, 2026

April 24, 2026

In some cases windows apps may try to draw large cursors that exceed hardware accelerated cursor rendering on x servers. Ex: with nvidia proprietary the values may be: ``` $ xdpyinfo | grep -i cursor largest cursor: 256x256 ``` In such cases (even with 96dpi) on some x servers like xorg/xlibre cursor rendering may be unstable (rendering artifacts, flickering). Patch introduces optional logic path (manual toggle) that will attempt to conform win/x cursor to that of best reported by x. Note: Original hotpath is untouched. * create_xcursor_cursor - decouple windows cursor buffer from x cursor buffer, buffer dimensions logic * create_xcursor_frame - support target buffer dims != source buffer dims * two config fields toggling best cursor modes (if best cursor is smaller than requested cursor): - clamp_x_cursor_to_best_size: win cursor buffer will be clamped to max dimension values of the best cursor - fit_w_cursor_to_best_size: win cursor buffer dimensions will be reassigned to smaller value that fit best cursor dimensions --- Open to any suggestions/changes. Thanks! -- v5: fix hotspot clamping to max dim instead of 1px offset https://gitlab.winehq.org/wine/wine/-/merge_requests/10737

2 2

[PATCH v4 0/1] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 24, 2026

April 24, 2026

In some cases windows apps may try to draw large cursors that exceed hardware accelerated cursor rendering on x servers. Ex: with nvidia proprietary the values may be: ``` $ xdpyinfo | grep -i cursor largest cursor: 256x256 ``` In such cases (even with 96dpi) on some x servers like xorg/xlibre cursor rendering may be unstable (rendering artifacts, flickering). Patch introduces optional logic path (manual toggle) that will attempt to conform win/x cursor to that of best reported by x. Note: Original hotpath is untouched. * create_xcursor_cursor - decouple windows cursor buffer from x cursor buffer, buffer dimensions logic * create_xcursor_frame - support target buffer dims != soruce buffer dims * two config fields toggling best cursor modes (if best cursor is smaller than requested cursor): - clamp_x_cursor_to_best_size: win cursor buffer will be clamped to max dimension values of the best cursor - fit_w_cursor_to_best_size: win cursor buffer dimensions will be reassigned to smaller value that fit best cursor dimensions --- Open to any suggestions/changes. Thanks! -- v4: Optional handling of XQueryBestCursor https://gitlab.winehq.org/wine/wine/-/merge_requests/10737

2 1

[PATCH 0/1] MR10737: Optional handling of XQueryBestCursor
by Meow Jaceee (＠jaceee.wine) April 24, 2026

April 24, 2026

In some cases windows apps may try to draw large cursors that exceed hardware accelerated cursor rendering on x servers. Ex: with nvidia proprietary the values may be: ``` $ xdpyinfo | grep -i cursor largest cursor: 256x256 ``` In such cases (even with 96dpi) on some x servers like xorg/xlibre cursor rendering may be unstable (rendering artifacts, flickering). Patch introduces optional logic path (manual toggle) that will attempt to conform win/x cursor to that of best reported by x. Note: Original hotpath is untouched. * create_xcursor_cursor - decouple windows cursor buffer from x cursor buffer, buffer dimensions logic * create_xcursor_frame - support target buffer dims != soruce buffer dims * two config fields toggling best cursor modes (if best cursor is smaller than requested cursor): - clamp_x_cursor_to_best_size: win cursor buffer will be clamped to max dimension values of the best cursor - fit_x_cursor_to_best_size: win cursor buffer dimensions will be reassigned to smaller value that fit best cursor dimensions --- Open to any suggestions/changes. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10737

2 1

[PATCH v11 0/2] MR10659: combase: Implement restricted WinRT error handling APIs.
by Anna R Békefi (＠annareginabekefi) April 24, 2026

April 24, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58900 Bug 58900 This series implements restricted WinRT error handling in combase and\ adds conformance tests for the new behavior. Implemented APIs include restricted error creation / retrieval,\ error context capture, transform, matching, and unhandled error reporting\ paths. Tests were added under dlls/combase/tests and pass locally.\ The existing combase tests also continue to pass. -- v11: combase/tests: Add tests for restricted WinRT error handling. combase: Implement restricted WinRT error handling APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/10659

2 2

Re: [PATCH v46 0/2] MR10295: Fix ImageGetDigestStream
by eric pouech (＠epo) April 24, 2026

April 24, 2026

eric pouech (@epo) commented about dlls/imagehlp/integrity.c: > - */ > - nt_hdr->OptionalHeader.SizeOfInitializedData = 0; > - nt_hdr->OptionalHeader.SizeOfImage = 0; > - nt_hdr->OptionalHeader.CheckSum = 0; > - size = sizeof(nt_hdr->Signature) + sizeof(nt_hdr->FileHeader) + > - nt_hdr->FileHeader.SizeOfOptionalHeader; > + NumberOfRvaAndSizes = nthdr32->OptionalHeader.NumberOfRvaAndSizes; > + DataDirectory = nthdr32->OptionalHeader.DataDirectory; > + if( nthdr32->OptionalHeader.Magic == IMAGE_NT_OPTIONAL_HDR64_MAGIC ) > + { > + nthdr64 = (IMAGE_NT_HEADERS64 *)nthdr32; > + NumberOfRvaAndSizes = nthdr64->OptionalHeader.NumberOfRvaAndSizes; > + DataDirectory = nthdr64->OptionalHeader.DataDirectory; > + /* NOTE: Fields up to SizeOfStackCommit are the same size/offset, except for ImageBase */ > + } > + memcpy(DataDirBackup, DataDirectory, sizeof(DataDirBackup)); it looks a bit ackward to save ntheader+section headers, modify the memory of mapping, then restore the saved bits in the mapping it would be more straightforward to keep mapping as is, and allocate a buffer for tempering ntheader + section headers and pass pointer into this buffer in the callback this is how native behaves BTW this would save one memcpy and avoids dirty:ing the mapping which results with COW of the modified pages -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10295#note_137581

1 0

Re: [PATCH v46 0/2] MR10295: Fix ImageGetDigestStream
by eric pouech (＠epo) April 24, 2026

April 24, 2026

hi retested again a range of images and I still get discrepancies from native imagehlp behavior as you didn't add any FIXME for non supported DigestLeve, I assumed you meant all values of DigestLevel are supported some examples of missed callbacks: * DigestLevel = 0,4, callback with chunks inside IMPORT data directory * DigestLevel = 2,6, callback with section containing DEBUG directory also what's suspicious in the code is that there are actions taken when data directory points at the very start of a section (when checking respective VirtualAddress: fields), but a data directory could point to anywhere within a section (for the record, it looks a bit ackward to save ntheader+section headers, modify the memory of mapping, then restore the saved bits in the mapping; it would be more straightforward to keep mapping as is, and allocate a buffer for tempering ntheader + section headers and pass pointer into this buffer in the callback; this is how native behaves BTW); this would save one copy and avoids dirty:ing the mapping again, I strongly suggest to start with a unique value of DigestLevel (the one you need to support), get it right (and testing native / bultin behavior on all .exe/.dll you can find) (by testing I mean writing a small program that does print, for each callback invocation, size and CRC of passed chunk; using native and builtin imagehlp should produce the very same output) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10295#note_137580

1 0