April 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + > + return pointer; > +} > + > +static struct pointer *find_pointerid(UINT32 id) { > + struct pointer_thread_data *thread_data = get_pointer_thread_data(); > + struct pointer *pointer; > + > + TRACE( "looking for pointer id %d\n", id ); > + > + LIST_FOR_EACH_ENTRY(pointer, &thread_data->known_pointers, struct pointer, entry) > + if (pointer->id == id) > + return pointer; > + > + return NULL; > +} Are we truly confident that this should be a per-thread list of pointer (and I assume, later, frame history)? If there isn't already we will need tests to make sure it is and that querying pointer info and pointer history from a thread that has never processed any message indeed returns an error. Fwiw we already maintain a list of pointers on wineserver side, I suspect it should perhaps work globally instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136039

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + TRACE( "looking for pointer id %d\n", id ); > + > + LIST_FOR_EACH_ENTRY(pointer, &thread_data->known_pointers, struct pointer, entry) > + if (pointer->id == id) > + return pointer; > + > + return NULL; > +} > + > +static POINT pixel_to_himetric(POINT px) { > + UINT dpi = HIMETRIC / get_system_dpi(); > + > + return (POINT) { > + .x = px.x * dpi, > + .y = px.y * dpi, > + }; We don't use these constructs in Wine yet. It's perhaps acceptable to introduce new usages but it will only make it more difficult to get your patches accepted if you add extra portability questions to be considered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136038

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/win32u/pointer.c: > + > +#define HIMETRIC 2540 > + > +static LONG last_frame = 0; > + > +struct pointer { > + UINT32 id; > + struct list entry; > + POINTER_INPUT_TYPE type; > + POINTER_INFO info; > +}; > + > +struct pointer_thread_data { > + struct list known_pointers; > +}; > + There's various style inconsistencies, it will need to be fixed to match win32u code style (spaces in paren, allman braces, etc...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136037

1 0

Re: [PATCH v7 0/10] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Rémi Bernon (@rbernon) commented about dlls/user32/tests/input.c: > > memset( &pointer_info, 0xcd, sizeof(pointer_info) ); > ret = pGetPointerInfo( 1, &pointer_info ); > + todo_wine > ok( !ret, "GetPointerInfo succeeded\n" ); > + todo_wine > ok( GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError() ); It will probably need to be done without adding todo_wine, these tests more or less closely mimic some application calls, and it will break what currently works if these tests don't pass anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10649#note_136036

1 0

[PATCH 0/1] MR10657: cfgmgr32: Fix querying unnamed properties.
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10657

2 1

[PATCH 0/1] MR10656: opengl32: Check for GL_EXT_memory_object_fd before filtering extensions.
by Rémi Bernon (＠rbernon) April 14, 2026

April 14, 2026

Fixes: 97f2945b4ca7e3d72e9692592b373dd89b6003f9 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10656

2 1

[PATCH v5 0/1] MR7494: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value.
by Alistair Leslie-Hughes (＠alesliehughes) April 14, 2026

April 14, 2026

0024:trace:msxml:domdoc_put_preserveWhiteSpace (068F0520)->(1) Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=21940 -- v5: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7494

2 1

[PATCH v3 0/2] MR10010: odbc32 asci fallbacks.
by Alistair Leslie-Hughes (＠alesliehughes) April 14, 2026

April 14, 2026

-- v3: odbc32: SQLPrepareW add ansi fallback odbc32: SQLNativeSqlW add ansi fallback https://gitlab.winehq.org/wine/wine/-/merge_requests/10010

2 2

[PATCH 0/3] MR10646: msxml3: Add support of GB2312.
by Jactry Zeng (＠jactry) April 14, 2026

April 14, 2026

Superseded MR !3928. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10646

3 9

[PATCH 0/1] MR10655: winecfg: Support 7.1 speaker config.
by Mohamad Al-Jaf (＠maljaf) April 14, 2026

April 14, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56664 ![winecfg-7.1](/uploads/19fe1fad54748bb3731bafa8f2288f45/winecfg-7.1.png){width=357 height=452} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10655

3 2