April 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR10654: winegstreamer: Fix wg_parser/native video stride mismatch.
by Yuxuan Shui (＠yshui) April 14, 2026

April 14, 2026

On Tue Apr 14 03:14:19 2026 +0000, Yuxuan Shui wrote: > > ... by calling `IMF2DBuffer::Lock`. ... > Sorry, I meant `IMF2DBuffer::Lock2D` There really is no way to get pitch info from an `IMFMediaBuffer`, right? Am I missing something? Slight correction (and additional context) to my comment: The video I used to test is a 162x120 video. If I set the output pixel format to YV12: - When locked with `IMFMediaBuffer_Lock`, the Y plane size is 176x128, clearly aligned up to 16 bytes. - When locked with `IMF2DBuffer2_Lock2DSize`, the returned pitch is 256 bytes and Y plane size is 256x128. So if `IMF2DBuffer` is not available, how does a game figure out what the real pitch of the buffer returned by `IMFMediaBuffer_Lock` is? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10654#note_136016

1 0

Re: [PATCH v2 0/4] MR10654: winegstreamer: Fix wg_parser/native video stride mismatch.
by Yuxuan Shui (＠yshui) April 14, 2026

April 14, 2026

> ... by calling `IMF2DBuffer::Lock`. ... Sorry, I meant `IMF2DBuffer::Lock2D` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10654#note_136015

1 0

[PATCH 0/4] MR10654: winegstreamer: Fix wg_parser/native video stride mismatch.
by Yuxuan Shui (＠yshui) April 14, 2026

April 14, 2026

YV12, NV12, I420 formats has min alignment of 2 bytes for Y plane stride on native, but winegstreamer uses 4 bytes. Additionally YV12 and I420 expect U and V plane stride to be exactly 1/2 of the Y plane stride, yet winegstreamer also aligns those to 4 bytes. This breaks some games. This commit adds a custom buffer pool to wg_parser which affords us control over what stride to use, just like wg_transform. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10654

2 5

[PATCH 0/1] MR10653: gdiplus: Assume bitmaps are top-down in image-reading code.
by Esme Povirk (＠madewokherd) April 14, 2026

April 14, 2026

Noticed when looking at https://bugs.winehq.org/show_bug.cgi?id=40409, but I don't think this noticeably improves performance. Still, it cuts down on some extra work and simplifies the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10653

2 1

[PATCH 0/5] MR10652: gdiplus: Rewrite GdipCreateBitmapFromGdiDib.
by Esme Povirk (＠madewokherd) April 14, 2026

April 14, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40409 The main thing that changes here is that we reference bits directly instead of copying to an intermediate HBITMAP. Most of the tests are to make sure we don't regress anything by parsing BITMAPINFOHEADER directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10652

2 5

[PATCH v17 0/6] MR10419: ntdll: Fix thread stops inside __wine_syscall_dispatcher
by Hoshino Lina (＠hoshinolina) April 14, 2026

April 14, 2026

When SIGUSR1 is called while running inside `__wine_syscall_dispatcher`, the CPU context is not in a consistent state. To ensure that the captured context is always consistent: * If the SIGUSR1 arrives while saving the context, set a flag and defer handling it until after the context is fully saved. * If the SIGUSR1 arrives while restoring the context, rewind and retry restoring the context from the beginning. The latter relies on context restore being idempotent. The only case where that is not true is when the instrumentation callback is enabled. To address this, first make that path idempotent by saving the user %rip into %r10 in paths that enable the instrumentation callback. This fixes a regression introduced by 0a5f7a710365 which started leaking bogus SP values, but also generally fixes all other register value leaks due to SIGUSR1 racing with the syscall dispatcher. Supersedes: !10232 (FYI, the threadctx test introduced in this MR is stricter and also checks %rip, which will fail with that previous MR). Fixes: 0a5f7a710365 ("ntdll: Switch to the user stack before restoring the %fs register.") \ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59333 -- v17: gitlab: Run ntdll tests with win64 architecture. ntdll/tests: Abort wow64 tests early if wow64 is unavailable ntdll/tests: Add a test for interrupted syscall handling ntdll: Block SIGUSR1 when the thread context is being modified ntdll: Fix thread stops inside __wine_syscall_dispatcher https://gitlab.winehq.org/wine/wine/-/merge_requests/10419

4 10

[PATCH v36 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 13, 2026

April 13, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v36: imagehlp: Fix ImageGetDigestStream https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v35 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 13, 2026

April 13, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v35: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2

[PATCH v34 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) April 13, 2026

April 13, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v34: imagehlp: Fix ImageGetDigestStream Add test case for image with rsrc/reloc sections https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 3

[PATCH v4 0/1] MR10340: comctl32/tooltips: suppress icon and title when title is NULL or empty.
by Larry Starr (＠starrl) April 13, 2026

April 13, 2026

Per MSDN, TTM_SETTITLE with a NULL or empty title string should suppress both the title row and any associated icon. Previously an empty string was treated the same as a non-empty title, causing the icon to still be displayed and the tooltip to be incorrectly sized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58236 Signed-off-by: Larry Starr <Larry_A_Starr(a)yahoo.com> -- v4: comctl32/tooltips: suppress icon and title when title is NULL or empty. https://gitlab.winehq.org/wine/wine/-/merge_requests/10340

3 8