May 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR10553: iphlpapi: Prefer adapters with valid MAC in GetAdaptersInfo.
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ndis.c: > struct if_nameindex *indices = if_nameindex(), *entry; > unsigned int append_count = 0; > +#ifdef HAVE_BSD_IF_INFO > + struct ifaddrs *ifaddrs = NULL; > + if (getifaddrs( &ifaddrs ) != 0) ifaddrs = NULL; > +#endif > > for (entry = indices; entry->if_index; entry++) > { > - if (!find_entry_from_index( entry->if_index ) && add_entry( entry->if_index, entry->if_name )) > + UINT bsd_type; > + bsd_type = 0; > +#ifdef HAVE_BSD_IF_INFO > + if_get_bsd_info( ifaddrs, entry->if_name, &bsd_type ); > +#endif > + if (!find_entry_from_index( entry->if_index ) && add_entry( entry->if_index, entry->if_name, bsd_type )) Why don't we just filter out the unwanted interface types in this loop, rather than having `add_entry()` do it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10553#note_140546

1 0

[PATCH 0/1] MR10943: Revert "packager: Prefer native version."
by Elizabeth Figura (＠zfigura) May 19, 2026

May 19, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10943

3 3

[PATCH v3 0/2] MR10889: ole32: Validate cached clipboard window handle in get_clipbrd_window.
by Aaron Yourk (＠ayourk) May 19, 2026

May 19, 2026

The OLE clipboard caches a per-process window handle. When the STA thread that created this window terminates, the window is destroyed but the stale handle remains cached. Subsequent OleSetClipboard calls use this stale handle, causing OpenClipboard to fail with CLIPBRD_E_CANT_OPEN. Check whether the cached window is still valid using IsWindow() before returning it. If the window has been destroyed, clear the cache so a fresh window is created on the current thread. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59519 -- v3: ole32: Validate cached clipboard window handle in get_clipbrd_window. https://gitlab.winehq.org/wine/wine/-/merge_requests/10889

3 3

[PATCH v2 0/1] MR10946: shell32: Don't add backslash after SHGetSpecialFolderPathW.
by Arie Miller (＠Arimil) May 19, 2026

May 19, 2026

This fixes a regression implemented in 984f608c2885c80284ca8f35d6ad72d5193b3658 this breaks the game [Hyperdevotion Noire](https://store.steampowered.com/app/415480/Hyperdevotion_Noire_Goddes…. This game runs in proton 6.3-8 but is broken on versions after that. It seems most applications don't care about this, but this one in particular will crash when trying to access the My Documents directory due to this. -- v2: shell32: Don't add backslash after SHGetSpecialFolderPathW. https://gitlab.winehq.org/wine/wine/-/merge_requests/10946

2 1

Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c: > int index_offset; > int write_dir = (analysis->fRTL && !analysis->fLogicalOrder) ? -1 : 1; > int offset_sign = (analysis->fRTL && analysis->fLogicalOrder) ? -1 : 1; > + unsigned int k = glyph_index + write_dir; Again, `k` for a long-lived variable is unfortunate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140532

1 0

Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c: > > for (k = 0; k < backtrack_count; ++k) > { > + unsigned int j; > offset = GET_BE_WORD(backtrack->Coverage[k]); > - if (GSUB_is_glyph_covered((const BYTE *)backtrack + offset, > - glyphs[glyph_index + (dirBacktrack * (k + 1))]) == -1) > + j = glyph_index + (dirBacktrack * (k + 1)); Could we come up with a better name than `j` (especially as it's in a loop over `k`)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140531

1 0

Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c: > if (mark_index != -1) > { > int mark2_index; > + unsigned int next_glyph_index = glyph_index - write_dir; > + if (next_glyph_index >= glyph_count) { Do we need to worry about `next_glyph_index < 0`? Also, opening brace on new line seems to be the majority style here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140530

1 0

[PATCH 0/2] MR10947: win32u: Simplify internal small class icon creation.
by Rémi Bernon (＠rbernon) May 19, 2026

May 19, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10947

2 2

[PATCH 0/3] MR10919: dsound cleanup
by Matteo Bruni (＠Mystral) May 19, 2026

May 19, 2026

This incorporates / supersedes !10882 and !10886. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10919

4 5

[PATCH v2 0/2] MR10913: Various IME fixes for FFXIV
by Marc-Aurel Zent (＠mzent) May 19, 2026

May 19, 2026

These are small fixes that make sure that FFXIV correctly sees the current input source as IME capable, so the game will display an IME icon next to its chat box (IME input actually working is independent of this). On macOS, there is no such concept as open or closed IME. Whenever an IME keyboard layout is active, we should open/close the IME that is currently active. -- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/10913

3 5