May 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR10886: dsound: Remove unused DSOUND_renderers list and lock.
by Jon Koops (＠jonkoops) May 16, 2026

May 16, 2026

Superseded by !10919. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10886#note_140209

1 0

[PATCH 0/1] MR10923: oleaut32: Normalize the SLTG value of cParamsOpt to MSFT convention
by Wolfgang Hartl (＠wolfo.dev) May 16, 2026

May 16, 2026

Bug: https://bugs.winehq.org/show_bug.cgi?id=24387 The issue: The SLTG-format typelib in INV7.OCX of MS Money 2000 crashes on the call for the function CreateProperies() with a vararg VT_VARIANT|VT_ARRAY|VT_BYREF parameter that is omitted by the caller. The caller INV7.OCX CreateProperties() receives the wrong type and immediately crashes reading VT_ERROR instead a pointer to a SAFEARRAY. The root cause: The SLTG binary format stores cParamsOpt in a 6-bit field. SLTG uses the maximum value (0x3f / 63) as a sentinel with the meaning "vararg", like the MSFT format uses -1 for the same purpose. ITypeInfo_fnInvoke() checks cParamsOpt \< 0 at four places to detect vararg and handle the optional VT_VARIANT|VT_ARRAY parameter correctly to allocate an empty SafeArray placeholder. Since 63 \< 0 is false, this check never triggers for SLTG-compiled typelibs. The ITypeInfo_fnInvoke() function instead comes to the generic VT_BYREF placeholder path, which sets: VT_VARIANT|VT_BYREF {VT_ERROR: DISP_E_PARAMNOTFOUND} instead of the correct VT_VARIANT|VT_ARRAY|VT_BYREF {empty SafeArray}. The fix: Normalize the SLTG sentinel value to the MSFT convention at parse time in SLTG_DoFuncs: set cParamsOpt to -1 when it is 63. This makes the cParamsOpt \< 0 checks in ITypeInfo_fnInvoke work correctly for SLTG typelibs, and GetFuncDesc returns the Windows-documented canonical value (-1) for vararg to callers. Tests: Rerun MS Money 2000 with the lasted compiled version wine version 11.9 plus the fix in typelib.c. With the fix, DispCallFunc receives the correct argument VT_VARIANT|VT_ARRAY|VT_BYREF the reference to an empty SafeArray, CreateProperties() executes successfully and returns VT_DISPATCH. The function call in MS Money 2000 no longer crashes! I extensively searched the internet and did not find any documentation of this vararg defintion for SLTG format. But I sucessfully recreated typelib files in SLTG format in Windows with vararg and without vararg option for a test-function. I was able to produce them with an old midl version 3.01.75, later versions failed with internal compile error MIDL9008. midl /win32 /oldtlb /tlb test3.tlb test_vararg_sltg3.odl midl /win32 /oldtlb /tlb test3no.tlb test_novararg_sltg3.odl The difference in the generated binary typelib files shows the relevant byte changed from 0xfe (6-bits 111111) with "vararg" to 0x80 (6-bits 000000) without "vararg". `diff <(xxd test3.tlb) <(xxd test3no.tlb)d` Then a test dump of both loaded tlbs showed in - Windows: cParamsOpt = -1 (vararg) and 0 (no vararg) - Linux/Wine: cParamsOpt = 63 (vararg, before the fix) and 0 (no vararg) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10923

2 1

Re: [PATCH v4 0/1] MR10882: dsound: Replace device reference counting with a stop event.
by Matteo Bruni (＠Mystral) May 16, 2026

May 16, 2026

On Sat May 16 11:25:39 2026 +0000, Jon Koops wrote: > Ah, missed that. Shall I close this one and !10886 in favor of your new PR? Sure, at your convenience. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10882#note_140205

1 0

[PATCH v2 0/1] MR10823: winex11: Allow user to set WM_CLASS
by Nicholas Little (＠njlittle) May 16, 2026

May 16, 2026

This commit allows the user to optionally set the WM_CLASS by setting an environment variable WINEWMCLASS with the aim of allowing him to ensure desktop environments can correctly identify wine windows, unfortunately the executable filename isn't always sufficient as some programs share a common executable name. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50095 Signed-off-by: Nicholas Little <nicholas.john.little(a)gmail.com> -- v2: winex11: Allow user to set WM_CLASS https://gitlab.winehq.org/wine/wine/-/merge_requests/10823

2 3

[PATCH v2 0/4] MR10922: winebth.sys: Refactor code for initial enumeration of BlueZ objects.
by Vibhav Pant (＠vibhavp) May 16, 2026

May 16, 2026

The current code maintains separate data structures and lists for initial device enumeration. This is unnecessary as the main watcher loop ultimately pushes initial devices onto the main event list anyway. To that end, this MR: * Removes the `bluez_init_entry` struct and the `initial_{radio, device, gatt_{service, chars}}_list` lists in `bluez_watcher_ctx`. Newly detected objects are now directly pushed to the event list. * Factors the new object handling logic in `bluez_signal_handler` and `bluez_build_initial_device_lists` (now `bluez_enumerate_objects`) into a common function, `bluez_handle_new_object`. * Use libdbus' async callback methods to automatically perform initial device enumeration, instead of checking the status of the `GetManagedObjects` call on every iteration of the main loop. -- v2: winebth.sys: Perform initial device enumeration inside a DBusPendingCall callback. winebth.sys: Factor code for handling new BlueZ objects into bluez_handle_new_object. https://gitlab.winehq.org/wine/wine/-/merge_requests/10922

2 4

[PATCH 0/4] MR10922: winebth.sys: Refactor code for initial enumeration of BlueZ objects.
by Vibhav Pant (＠vibhavp) May 16, 2026

May 16, 2026

The current code maintains separate data structures and lists for initial device enumeration. This is unnecessary as the main watcher loop ultimately pushes initial devices onto the main event list anyway. To that end, this MR: * Removes the `bluez_init_entry` struct and the `initial_{radio, device, gatt_{service, chars}}_list` lists in `bluez_watcher_ctx`. Newly detected objects are now directly pushed to the event list. * Factors the new object handling logic in `bluez_signal_handler` and `bluez_build_initial_device_lists` (now `bluez_enumerate_objects`) into a common function, `bluez_handle_new_object`. * Use libdbus' async callback methods to automatically perform initial device enumeration, instead of checking the status of the `GetManagedObjects` call on every iteration of the main loop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10922

2 4

Re: [PATCH v4 0/1] MR10882: dsound: Replace device reference counting with a stop event.
by Jon Koops (＠jonkoops) May 16, 2026

May 16, 2026

On Fri May 15 21:16:28 2026 +0000, Matteo Bruni wrote: > This would trigger the `WARN()` when the `stopev` event fires. > I don't think a new event is necessary in the first place though. I > tweaked the patch slightly in !10919. Ah, missed that. Shall I close this one and !10886 in favor of your new PR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10882#note_140197

1 0

Re: [PATCH v7 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Jon Koops (＠jonkoops) May 16, 2026

May 16, 2026

On Sat May 16 10:09:44 2026 +0000, Matteo Bruni wrote: > The bugs mentioned in the release notes are bugs marked as RESOLVED > FIXED on bugs.winehq.org, which are CLOSED during release. I just marked > #41047 as RESOLVED FIXED so it should appear in the next release notes. > For the records, this is not uncommon at all in Wine :sweat_smile: No worries, just making sure all the administrative work is in a correct state. Thanks, Matteo! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_140175

1 0

Re: [PATCH v7 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Matteo Bruni (＠Mystral) May 16, 2026

May 16, 2026

On Sat May 16 10:09:44 2026 +0000, Jon Koops wrote: > @julliard FYI this should have closed #41047, not sure why it didn't > (perhaps me mentioning it was not enough for automation to pick it up?). > It should probably be added to the [Wine 11.9 release > notes](https://bugs.winehq.org/show_bug.cgi?id=41047) that this issue > was resolved. The bugs mentioned in the release notes are bugs marked as RESOLVED FIXED on bugs.winehq.org, which are CLOSED during release. I just marked #41047 as RESOLVED FIXED so it should appear in the next release notes. For the records, this is not uncommon at all in Wine :sweat_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_140173

1 0

Re: [PATCH v7 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
by Jon Koops (＠jonkoops) May 16, 2026

May 16, 2026

@julliard FYI this should have closed #41047, not sure why it didn't (perhaps me mentioning it was not enough for automation to pick it up?). It should probably be added to the [Wine 11.9 release notes](https://bugs.winehq.org/show_bug.cgi?id=41047) that this issue was resolved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_140171

1 0