May 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v9 0/1] MR10528: oleaut32: Add fast paths for VarAdd and VarCmp with integer operands. - closed
by Francis De Brabandere (＠francisdb) May 16, 2026

May 16, 2026

This merge request was closed by Francis De Brabandere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10528

1 0

Re: [PATCH v9 0/1] MR10528: oleaut32: Add fast paths for VarAdd and VarCmp with integer operands.
by Francis De Brabandere (＠francisdb) May 16, 2026

May 16, 2026

Switching to alternative !10921 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10528#note_140170

1 0

Re: [PATCH v9 0/1] MR10528: oleaut32: Add fast paths for VarAdd and VarCmp with integer operands.
by Francis De Brabandere (＠francisdb) May 16, 2026

May 16, 2026

On Sat May 16 09:28:26 2026 +0000, Jacek Caban wrote: > I'm not sure about this. In general, we know that performance matters > for these functions, but this is quite a narrow special case, > potentially at the expense of adding more branching to other cases > (although that could be mitigated with something like `!(xmask & > ~(VTBIT_I2 | VTBIT_I4 | VTBIT_EMPTY))`). > It is hard for me to comment further without knowing the exact > bottleneck. If changing the type is the problem, perhaps some > refactoring that provides a lighter version of `VariantChangeTypeEx` > that does not clear/validate the output would help, both here and in > other callers. I'm not sure, it would also be a larger change, so it may > not be worth it. If it really comes down to special-casing, perhaps > vbscript, where this case is likely the most common by far, would be a > better place. moving to vbscript in !10921 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10528#note_140167

1 0

[PATCH 0/1] MR10921: Draft: vbscript: Fast-path interp_add and var_cmp for pure-integer operands.
by Francis De Brabandere (＠francisdb) May 16, 2026

May 16, 2026

For-loop counters and conditional comparisons hit VarAdd/VarCmp every iteration with trivial I2/I4 operands, but the full VARIANT conversion pipeline (VariantChangeType, locale grab/free in ucrtbase) dominates the cost. Short-circuit at the call site in interp.c when both operands are pure VT_I2/VT_I4: compare directly, or add via LONGLONG with native promotion (I2+I2 -> I4 on overflow, I4+I4 -> R8 on overflow). Alternative to !10528 Keeps the optimisation scoped to vbscript callers rather than adding branches to oleaut32 generic VarAdd/VarCmp. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10921

2 1

[PATCH 0/1] MR10920: Feedback needed for a themes MR (This one)
by Fatih Bakal (＠Twig) May 16, 2026

May 16, 2026

Context/See; https://bugs.winehq.org/show_bug.cgi?id=59739 https://bugs.winehq.org/show_bug.cgi?id=48506 Sorry for opening a merge request like this but I need feedback as to whether this is something upstream is willing to merge. Even if so I need details on the implementation that'd be merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10920

4 7

[PATCH v8 0/2] MR10895: vbscript: Resolve UBound/LBound default member and match native errors
by Francis De Brabandere (＠francisdb) May 16, 2026

May 16, 2026

Resolve VT_DISPATCH arguments via DISPID_VALUE so an object whose default member returns an array works, and map the failure modes to native error codes (91 for Nothing, 438 for no default, 450 for default needing args, 13 for default returning a scalar). Scalar arguments collapse to err 13. -- v8: vbscript: Match native error codes for non-array arguments to UBound/LBound. https://gitlab.winehq.org/wine/wine/-/merge_requests/10895

2 4

[PATCH v4 0/2] MR10900: vbscript: Parse octal numeric literals (&O...).
by Francis De Brabandere (＠francisdb) May 16, 2026

May 16, 2026

Native cscript accepts &O0, &O17, &O177777, etc. as octal integer literals. Wine was emitting err 1002 (syntax error) for any &O prefix because the lexer only recognised &H. Add an oct_to_int helper and parse_oct_literal mirroring parse_hex_literal, allowing up to 32-bit values; overflow checks use an ULONGLONG accumulator since 11-digit octal can exceed 32 bits. -- v4: vbscript: Parse octal numeric literals (&O...). vbscript/tests: Add tests for octal numeric literals. https://gitlab.winehq.org/wine/wine/-/merge_requests/10900

2 2

Re: [PATCH v3 0/2] MR10893: msvcrt: Avoid expensive timezone queries from plain time() calls
by Piotr Caban (＠piotr) May 16, 2026

May 16, 2026

Please merge the patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10893#note_140147

1 0

Re: [PATCH v4 0/1] MR10882: dsound: Replace device reference counting with a stop event.
by Matteo Bruni (＠Mystral) May 15, 2026

May 15, 2026

Matteo Bruni (@Mystral) commented about dlls/dsound/mixer.c: > - /* > - * Some audio drivers are retarded and won't fire after being > - * stopped, add a timeout to handle this. > - */ > - ret = WaitForSingleObject(dev->sleepev, dev->sleeptime); > + /* > + * Some audio drivers are retarded and won't fire after being > + * stopped, add a timeout to handle this. > + */ > + while ((ret = WaitForMultipleObjects(ARRAY_SIZE(handles), handles, FALSE, dev->sleeptime)) != WAIT_OBJECT_0) > + { > if (ret == WAIT_FAILED) > WARN("wait returned error %lu %08lx!\n", GetLastError(), GetLastError()); > - else if (ret != WAIT_OBJECT_0) > + else if (ret != WAIT_OBJECT_0 + 1) > WARN("wait returned %08lx!\n", ret); This would trigger the `WARN()` when the `stopev` event fires. I don't think a new event is necessary in the first place though. I tweaked the patch slightly in !10919. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10882#note_140105

1 0

[PATCH 0/1] MR10918: configure.ac: Document the other --enable-archs values.
by Esme Povirk (＠madewokherd) May 15, 2026

May 15, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10918

2 1