May 2026 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR10822: vbscript: Return subscript-out-of-range from UBound/LBound on uninitialized array.
by Francis De Brabandere (＠francisdb) May 5, 2026

May 5, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10822

3 2

[PATCH v17 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Francis De Brabandere (＠francisdb) May 5, 2026

May 5, 2026

VarAnd only inspected the non-Null operand one way and left V_BOOL/V_I4 uninitialized. VarImp treated VT_UI1 0xFF as VARIANT_TRUE (it isn't) and its VT_CY -1 check compared unscaled .int64 to -1 instead of -10000. props to @jsm174 for this one: https://github.com/vpinball/libwinevbs/commit/7e877fafe34483623ca33d26ab76f… -- v17: vbscript/tests: Add Null handling smoke tests for logical operators. vbscript: Match native UI1 Imp Null behavior. oleaut32: Fix VT_DATE Null handling in VarImp. oleaut32: Fix VT_CY Null handling in VarImp. oleaut32: Fix Null handling in VarAnd. https://gitlab.winehq.org/wine/wine/-/merge_requests/10673

3 8

[PATCH v6 0/2] MR10818: vbscript: Cover non-literal numeric vs whitespace-only BSTR.
by Francis De Brabandere (＠francisdb) May 5, 2026

May 5, 2026

Native VBScript treats a whitespace-only BSTR (e.g. Space(N)) as larger than any numeric in BSTR-vs-numeric comparison, regardless of binary lex order. Wine's CStr-coerce path goes through VarCmp's binary order and gets the opposite result for single-digit numerics, breaking the practical Left(str, n) guard pattern Len(str) > Space(n). continuation of !10775 -- v6: vbscript: Treat all-whitespace and control-char BSTR as greater than numeric. vbscript/tests: Cover non-literal numeric vs whitespace-only and control-char BSTR. https://gitlab.winehq.org/wine/wine/-/merge_requests/10818

3 3

[PATCH v7 0/2] MR10797: cmd: Remove parentheses from list of illegal characters for quote strip
by Mykola Mykhno (＠MykolaMykhno) May 5, 2026

May 5, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- v7: cmd: Remove parentheses from list of illegal characters for quote strip https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

2 3

[PATCH v5 0/2] MR10797: cmd: Add a second set of illegal characters for the quotes strip
by Mykola Mykhno (＠MykolaMykhno) May 5, 2026

May 5, 2026

Prior to XP Professional x64 Edition, logic was that special characters such as: `&,<>,()@^` were forbidden in quotes. Quotes must be stripped if any of these characters appear in a parameter. This logic is documented in the cmd.exe documentation at MSDN. However, after XP Professional x64 Edition, Microsoft added the `Program Files (x86)` directory, and it seems like they removed parentheses from the list of forbidden characters in quotes. The documentation doesn't mention it. I have checked that XP Professional SP 2 x32 bit strips quotes when it finds parentheses in a parameter passed with /C, and XP Professional x64 Edition and all versions after it, whether 32 or 64 bit, preserve quotation marks when parentheses are in a parameter. Also, I checked that XP Professional x64 Edition is based already on NT 5.2, same with Windows Server 2003. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=37789 -- v5: cmd: Remove parentheses from list of illegal characters for quote strip cmd: Update tests for parentheses in quoted parameter https://gitlab.winehq.org/wine/wine/-/merge_requests/10797

3 5

[PATCH v3 0/6] MR10716: dsound: Speed up resampling, part 6
by Anton Baskanov (＠baskanov) May 5, 2026

May 5, 2026

-- v3: dsound: Add an SSE version of downsample. dsound: Add an SSE version of upsample. makedep: Allow adding arch-specific sources. https://gitlab.winehq.org/wine/wine/-/merge_requests/10716

3 10

[PATCH v24 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) May 5, 2026

May 5, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v24: vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. vbscript: Bind local variable assignments at compile time. vbscript: Factor out assign_local_var from assign_ident. vbscript: Bind local variables and arguments at compile time. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 6

[PATCH v2 0/5] MR10716: dsound: Speed up resampling, part 6
by Anton Baskanov (＠baskanov) May 5, 2026

May 5, 2026

-- v2: dsound: Add an SSE version of downsample. dsound: Add an SSE version of upsample. https://gitlab.winehq.org/wine/wine/-/merge_requests/10716

3 12

[PATCH v13 0/11] MR10649: win32u: Initial implementation for GetPointer{,Frame}Info{,History} and GetPointerDeviceRects
by navi (＠navi) May 5, 2026

May 5, 2026

-- v13: win32u: Implement NtUserGetPointerInfoList. win32u: Update pointerid 1 from mouse_in_pointer events. win32u: Implement NtUserGetPointerType. win32u: Keep track of pointer types. win32u: Preallocate pointerId 1 for the mouse pointer. win32u: Keep per-thread list of known pointers. win32u: Move process_pointer_message to input.c. win32u: Implement NtUserGetPointerDeviceRects for INVALID_HANDLE_VALUE. win32u: Add NtUserGetPointerDeviceRects test for INVALID_HANDLE_VALUE. https://gitlab.winehq.org/wine/wine/-/merge_requests/10649

2 12

[PATCH v58 0/2] MR10295: Fix ImageGetDigestStream
by Trent Waddington (＠trent.waddington) May 4, 2026

May 4, 2026

ImageGetDigestStream is used to hash the "important" parts of PE files. After rigorous experimentation we discovered these changes were sufficient to get identical hashes (and thereby signatures) on Windows and Wine. -- v58: imagehlp: Fix ImageGetDigestStream. https://gitlab.winehq.org/wine/wine/-/merge_requests/10295

2 2