May 2026 - Wine-GitLab - list.winehq.org

[PATCH v4 0/1] MR10278: d3dxof: Return isolated buffers from IDirectXFileData_GetData().
by Joerg Rueppel (＠jrueppel) May 4, 2026

May 4, 2026

The original d3dxof.dll does it. Space Empires V writes into the returned buffers for some reason and overwrites adjacent data. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49722 -- v4: d3dxof: Return isolated buffers from IDirectXFileData_GetData(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10278

3 12

[PATCH 0/1] MR10815: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) May 4, 2026

May 4, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10815

2 1

Re: [PATCH v15 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Francis De Brabandere (＠francisdb) May 4, 2026

May 4, 2026

On Mon May 4 18:49:38 2026 +0000, Jacek Caban wrote: > This does not need to be a special case. It will fallback to detault > switch case anyway. removed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10673#note_138770

1 0

Re: [PATCH v15 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Francis De Brabandere (＠francisdb) May 4, 2026

May 4, 2026

On Mon May 4 18:47:37 2026 +0000, Jacek Caban wrote: > It would be nice to have test cases showing that this should be symmetrical. The VARAND macro uses test_var_call2_commutative (vartest.c:551), which exercises both (left, right) and (right, left). Every VARAND_TODOCOMM → VARAND conversion in this commit is a previously-failing-in-one-direction case that now passes commutatively. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10673#note_138769

1 0

[PATCH 0/3] MR10814: d2d1: Fix coordinate in arc-to-bezier conversion for degenerate case.
by Nikolay Sivov (＠nsivov) May 4, 2026

May 4, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59718 Signed-off-by: Giang Nguyen <nen24t(a)gmail.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10814

2 5

[PATCH v14 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Francis De Brabandere (＠francisdb) May 4, 2026

May 4, 2026

VarAnd only inspected the non-Null operand one way and left V_BOOL/V_I4 uninitialized. VarImp treated VT_UI1 0xFF as VARIANT_TRUE (it isn't) and its VT_CY -1 check compared unscaled .int64 to -1 instead of -10000. props to @jsm174 for this one: https://github.com/vpinball/libwinevbs/commit/7e877fafe34483623ca33d26ab76f… -- v14: vbscript/tests: Add Null handling smoke tests for logical operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10673

2 5

[PATCH v10 0/1] MR10509: vbscript: Implement DateValue and TimeValue functions.
by Francis De Brabandere (＠francisdb) May 4, 2026

May 4, 2026

-- v10: vbscript: Implement DateValue and TimeValue functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10509

3 3

Re: [PATCH v13 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Jacek Caban (＠jacek) May 4, 2026

May 4, 2026

Jacek Caban (@jacek) commented about dlls/oleaut32/variant.c: > + if (leftvt == VT_NULL && rightvt == VT_NULL) > + { > + V_VT(result) = VT_NULL; > + goto VarAnd_Exit; > + } > + > if (leftvt == VT_NULL) > + { > + other = right; > + othervt = rightvt; > + } > + else > + { > + other = left; > + othervt = leftvt; > + } It would be nice to have test cases showing that this should be symmetrical. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10673#note_138753

1 0

Re: [PATCH v13 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Jacek Caban (＠jacek) May 4, 2026

May 4, 2026

Jacek Caban (@jacek) commented about dlls/oleaut32/variant.c: > > if (leftvt == VT_NULL || rightvt == VT_NULL) > { > - /* > - * Special cases for when left variant is VT_NULL > - * (VT_NULL & 0 = VT_NULL, VT_NULL & value = value) > - */ > + /* Three-valued logic for `And` with Null: > + * zero And Null = zero (typed by the resvt computed above) > + * nonzero And Null = Null > + * Null And Null = Null > + * > + * Both orderings must produce the same result. */ > + VARIANT *other; > + VARTYPE othervt; You may just use `V_VT(other)`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10673#note_138751

1 0

Re: [PATCH v13 0/5] MR10673: oleaut32: Fix Null handling in three-valued logical ops.
by Jacek Caban (＠jacek) May 4, 2026

May 4, 2026

Jacek Caban (@jacek) commented about dlls/oleaut32/variant.c: > - */ > + /* Three-valued logic for `And` with Null: > + * zero And Null = zero (typed by the resvt computed above) > + * nonzero And Null = Null > + * Null And Null = Null > + * > + * Both orderings must produce the same result. */ > + VARIANT *other; > + VARTYPE othervt; > + BOOL nonzero = FALSE; > + > + if (leftvt == VT_NULL && rightvt == VT_NULL) > + { > + V_VT(result) = VT_NULL; > + goto VarAnd_Exit; > + } This does not need to be a special case. It will fallback to detault switch case anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10673#note_138752

1 0