June 2026 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR11059: dssenh: Use SymCrypt. - approved
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11059

1 0

Re: [PATCH v2 0/1] MR11057: winexinput.sys: Fix handling of non-32-bit axis - approved
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11057

1 0

Re: [PATCH v5 0/1] MR11055: loader: Add default SQMClient registry key - approved
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11055

1 0

[PATCH v2 0/1] MR10953: Draft: Update default i386_CFLAGS
by Matteo Bruni (＠Mystral) June 3, 2026

June 3, 2026

The immediate reason for this is !10716, but I suspect it might come in handy in other places as well. FWIW I've been building Wine with similar CFLAGS for many, many years. -- v2: configure: Add x86-64 CPU features to default i386_EXTRACFLAGS. https://gitlab.winehq.org/wine/wine/-/merge_requests/10953

3 2

[PATCH v3 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Rose Hellsing (＠axtlos) June 3, 2026

June 3, 2026

Until now wine tried to write the cookie even if the cookie was located in a read-only section, causing some applications to crash. With this change the loader temporarily marks the memory section as read-write to update the cookie. The same fix was applied to the ntdll and ntoskrnl.exe loader, as they had pretty much the same set_security_cookie() function. A test to check for correctness with read-only cookies was also added. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51928 -- v3: kernel32: Add test for read-only cookie in loader ntoskernel.exe: account for read-only cookies ntdll: account for read-only cookie in loader https://gitlab.winehq.org/wine/wine/-/merge_requests/11001

2 3

Re: [PATCH v2 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

On Wed Jun 3 18:43:03 2026 +0000, Rose Hellsing wrote: > Is the loop actually necessary? From how I understand it it keeps > re-rolling the cookie until it's no longer the same as the default > sentinel, but the chance for that to happen should be pretty low. Sure, but low is not zero. Some apps crash when the cookie is not set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142125

1 0

Re: [PATCH v2 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Rose Hellsing (＠axtlos) June 3, 2026

June 3, 2026

On Wed Jun 3 18:42:40 2026 +0000, Alexandre Julliard wrote: > I don't think you should be removing the loop. Is the loop actually necessary? From how I understand it it keeps re-rolling the cookie until it's no longer the same as the default sentinel, but the chance for that to happen should be pretty low. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142124

1 0

[PATCH 0/1] MR11061: hnetcfg: Report 0 returned elements from IEnumVARIANT::Next.
by Tim Clem (＠tclem) June 3, 2026

June 3, 2026

A regression from !10957. MSDN documents that the final argument should be set to the number of returned elements, even if the function returns S_FALSE. steamservice.exe crashes on launch without this; it passes an uninitialized variable as pCeltFetched, so it proceeds to loop over some arbitrary number of (nonexistent) variants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11061

3 2

Re: [PATCH v2 0/3] MR11001: ntdll, ntoskrnl.exe: account for read-only cookie in loader
by Alexandre Julliard (＠julliard) June 3, 2026

June 3, 2026

I don't think you should be removing the loop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11001#note_142122

1 0

Re: [PATCH v6 0/4] MR10992: ddraw: Allow attaching flip chain surfaces surfaces (for v1 surfaces).
by Paul Gofman (＠gofman) June 3, 2026

June 3, 2026

Thanks for spotting this. Also, unsurprisingly, shows up as a test crash if running the test with WINEDEBUG=warn+heap. I've sent https://gitlab.winehq.org/wine/wine/-/merge_requests/11060. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10992#note_142117

1 0