- Wine-GitLab - list.winehq.org

[PATCH 0/3] MR10710: wineandroid: prepare ioctl dispatch for Java-only thread execution (part of !10569)
by Twaik Yont (＠twaik) April 21, 2026

April 21, 2026

Part of !10569. This series prepares wineandroid ioctl dispatch paths for execution on Java-originated threads that do not have a Wine TEB. It does three things: * pass JNIEnv explicitly through the ioctl dispatch path instead of relying on the global jni_env value in handlers * move native window registration from the APC/unixlib callback path to the direct JNI surface_changed callback on the Android UI thread * make logging in device.c context-aware so the same code remains safe both on Wine threads and on Java-only threads The JNIEnv change is a preparatory refactoring. It does not by itself complete the thread model transition, but it removes one of the major implicit dependencies on Wine thread context and makes follow-up changes smaller and easier to review. Moving native window registration to surface_changed removes another dependency on APC-based execution in the desktop process and puts window attachment on the thread that actually receives the Android surface callbacks. A shared lock is used to serialize registration against ioctl dispatch. Finally, logging in device.c is made context-aware. Upcoming changes will run parts of ioctl dispatch on Java-only threads, where the standard Wine TRACE/WARN/FIXME/ERR macros are unsafe because they depend on Wine TEB state. The local logging wrapper preserves normal Wine logging semantics on Wine threads and falls back to Android logging on non-Wine threads, allowing the existing code to keep using the standard logging macros without invasive per-call-site changes. Taken together, these patches remove several implicit Wine-thread-only assumptions from wineandroid ioctl dispatch code and prepare the path for running more of it directly on Java-side threads. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10710

2 3

[PATCH v5 0/3] MR10504: Draft: vbscript: Implement GetLocale / SetLocale and honor locale in Format*
by Francis De Brabandere (＠francisdb) April 21, 2026

April 21, 2026

Implements `GetLocale` and `SetLocale` (previously stubbed as `E_NOTIMPL`) and makes the locale-sensitive `Format*` built-ins actually respect the script's current locale. This mimics the jscript implementation. -- v5: vbscript: Pass script LCID to VariantChangeType in to_string helper. vbscript: Use script LCID in Format* and call SetThreadLocale. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH 0/1] MR10612: gdi32/uniscribe: Fix heap buffer overflow in ScriptStringAnalyse().
by समीरसिंह Sameer Singh (＠ss141309) April 21, 2026

April 21, 2026

Hi, I came across this bug while solving another issue. Steps to reproduce: 1. Open wine notepad 2. Start spamming any character that requires mark_invalid_combinations() in the notepad, such as: َ (0x064e Arabic Fatha) 3. At nearly 41 inserted Fatha, notepad will crash -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10612

5 5

[PATCH 0/2] MR10697: win32u: Reject DDBs that are not 1-bit or 32-bit for GetDIBits().
by Zhiyi Zhang (＠zhiyi) April 21, 2026

April 21, 2026

SDL3 applications depend on this to not overwrite the depth of its internal display mode. Fix SDL3 applications using the native display mode instead of the specified display mode when restoring to fullscreen from focus loss for the first time, and the specific display mode is 16-bit. Please see `WIN_UpdateDisplayMode()` in the SDL3 source code. ```c static void WIN_UpdateDisplayMode(SDL_VideoDevice *_this, LPCWSTR deviceName, DWORD index, SDL_DisplayMode *mode) { ... if (index == ENUM_CURRENT_SETTINGS && (hdc = CreateDCW(deviceName, NULL, NULL, NULL)) != NULL) { char bmi_data[sizeof(BITMAPINFOHEADER) + 256 * sizeof(RGBQUAD)]; LPBITMAPINFO bmi; HBITMAP hbm; SDL_zeroa(bmi_data); bmi = (LPBITMAPINFO)bmi_data; bmi->bmiHeader.biSize = sizeof(BITMAPINFOHEADER); hbm = CreateCompatibleBitmap(hdc, 1, 1); GetDIBits(hdc, hbm, 0, 1, NULL, bmi, DIB_RGB_COLORS); GetDIBits(hdc, hbm, 0, 1, NULL, bmi, DIB_RGB_COLORS); DeleteObject(hbm); DeleteDC(hdc); if (bmi->bmiHeader.biCompression == BI_BITFIELDS) { switch (*(Uint32 *)bmi->bmiColors) { ... case 0x7C00: mode->format = SDL_PIXELFORMAT_XRGB1555; break; } ... ``` When entering a 16-bit display mode, `WIN_UpdateDisplayMode(_this, displaydata->DeviceName, ENUM_CURRENT_SETTINGS, mode);` is called in `WIN_SetDisplayMode()`. The second `GetDIBits()` call in `WIN_UpdateDisplayMode()` succeeds and ends up overwriting the format to SDL_PIXELFORMAT_XRGB1555, which is a 15-bit display mode. So when SDL3 tries to enter the 16-bit display mode again, it won't be found because it's now 15-bit. Tests show that the second `GetDIBits()` should fail and thus leave the display mode format unchanged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10697

3 4

[PATCH v4 0/2] MR10504: Draft: vbscript: Implement GetLocale and SetLocale functions.
by Francis De Brabandere (＠francisdb) April 21, 2026

April 21, 2026

-- v4: vbscript: Use script LCID in Format* and call SetThreadLocale. vbscript: Implement GetLocale and SetLocale functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10504

2 3

[PATCH v2 0/7] MR10706: msxml3: Respect document encoding in Save().
by Nikolay Sivov (＠nsivov) April 21, 2026

April 21, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: msxml3/tests: Add a few missing return value checks (Coverity). msxml3/tests: Fix some use-after-free (Coverity). msxml3/tests: Fix a string double free (Coverity). msxml3/tests: Fix copy-paste issue when testing node value (Coverity). msxml3: Improve cleanup on error paths when creating DOM nodes (Coverity). msxml3: Fix a leak when parsing xml declaration body (Coverity). msxml3: Respect document encoding in Save(). https://gitlab.winehq.org/wine/wine/-/merge_requests/10706

2 7

[PATCH 0/3] MR10709: colorcnv/tests: Add initial tests for the color conversion media object.
by Brendan McGrath (＠redmcg) April 21, 2026

April 21, 2026

This MR add tests for the color conversion DMO which is currently only stubbed under Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10709

3 7

[PATCH 0/3] MR10708: mfplat: Strip leading slashes from the URL in source_resolver_CreateObjectFromURL().
by Conor McCarthy (＠cmccarthy) April 21, 2026

April 21, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10708

3 4

Re: [PATCH v2 0/7] MR10688: msxml3: Improvements to setAttribute().
by Nikolay Sivov (＠nsivov) April 21, 2026

April 21, 2026

On Tue Apr 21 07:42:53 2026 +0000, Bernhard Übelacker wrote: > And also silence from the [gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/pipelines/64016). That's very good, thank you for reporting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10688#note_137190

1 0

Re: [PATCH v2 0/7] MR10688: msxml3: Improvements to setAttribute().
by Bernhard Übelacker (＠bernhardu) April 21, 2026

April 21, 2026

On Mon Apr 20 21:28:41 2026 +0000, Bernhard Übelacker wrote: > With 7cb26d6936 applied ASan stays silent on my local system, with > x86_64 and i386. And also silence from the [gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/pipelines/64016). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10688#note_137186

1 0