- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR10715: mf: Call GetCorrelatedTime without critical section.
by Nikolay Sivov (＠nsivov) May 8, 2026

May 8, 2026

Nikolay Sivov (@nsivov) commented about dlls/mf/clock.c: > static void CALLBACK presentation_clock_timer_callback(IUnknown *context) > { > struct presentation_clock *clock = impl_from_IMFPresentationClock((IMFPresentationClock*)context); > + IMFPresentationTimeSource *time_source; > struct clock_timer *timer; > LONGLONG time, systime; > > - EnterCriticalSection(&clock->cs); > - if (clock->time_source && > - SUCCEEDED(IMFPresentationTimeSource_GetCorrelatedTime(clock->time_source, 0, &time, &systime))) > + if ((time_source = clock->time_source)) > + IMFPresentationTimeSource_AddRef(time_source); > + I think at least this part should still be protected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10715#note_139209

1 0

[PATCH v2 0/1] MR10830: Draft: winewayland: Use wp_pointer_warp_v1 for SetCursorPos when available.
by Zakaria HABRI (＠zakissimo) May 8, 2026

May 8, 2026

The existing SetCursorPos implementation abuses zwp_locked_pointer_v1's set_cursor_position_hint side-effect: it briefly locks the pointer, sets the position hint, then unlocks. The compositor clamps position hints to locked-surface bounds, so warps to coordinates outside that area are silently dropped, and the lock/unlock cycle has subtle timing and side-effect issues. wp_pointer_warp_v1 is a staging protocol added in wayland-protocols 1.45 (June 2025) that provides a direct cursor-warp primitive without requiring pointer locking. KWin \>=6.4, Mutter \>=49, and wlroots \>=0.19 already implement it on the compositor side. This MR adds support to winewayland.drv: when the compositor advertises the global and we have a recent enter serial, the new path is used; otherwise we fall back to the existing lock/hint workaround. ## Testing - KWin 6.6.4 (Plasma Wayland): protocol advertised, new path fires (verified via `WINEDEBUG=+waylanddrv` showing the new `warp_pointer hwnd=...` TRACE). - niri 26.04 (no protocol support): fallback path fires unchanged. - Fallback else-branch is byte-equivalent to upstream master (only `pending_warp = FALSE` was hoisted out of the if-block). ## References - Protocol spec: https://wayland.app/protocols/pointer-warp-v1 - Existing workaround MR: !7353 (cc @atticf — thanks for the original workaround that this MR complements) - SDL adoption: https://github.com/libsdl-org/SDL/pull/10922 -- v2: winewayland: Use wp_pointer_warp_v1 for SetCursorPos when available. https://gitlab.winehq.org/wine/wine/-/merge_requests/10830

2 2

[PATCH v22 0/1] MR10461: vbscript: Implement IDispatch::GetTypeInfo for class instances.
by Francis De Brabandere (＠francisdb) May 8, 2026

May 8, 2026

Implement GetTypeInfo on vbdisp_t (VBScript class instances) by returning an ITypeInfo that reports the class name via GetDocumentation(MEMBERID_NIL) and exposes public methods and properties via GetFuncDesc, GetVarDesc, GetNames, GetIDsOfNames, and GetTypeAttr. This makes TypeName() return the actual class name (e.g. "MyClass") instead of falling back to "Object". This is partially based on previous work by @jsm174 at https://github.com/jsm174/libwinevbs/blob/fbc4d2a17a2da8196d50805f7ae289406… -- v22: vbscript: Implement IDispatch::GetTypeInfo for class instances. https://gitlab.winehq.org/wine/wine/-/merge_requests/10461

2 2

[PATCH v25 0/6] MR10515: Draft: vbscript: Bind local variables, class properties, and loop variables at compile time.
by Francis De Brabandere (＠francisdb) May 8, 2026

May 8, 2026

Resolve identifiers to direct indices during compilation instead of doing runtime `wcsicmp` string scans in `lookup_identifier()`. This adds new opcodes that access local variables, function arguments, class properties, and loop variables by index, eliminating the linear string comparison overhead for the most common cases. **New opcodes:** - `OP_local` / `OP_assign_local` / `OP_set_local` - read/write local vars and args by index - `OP_local_prop` / `OP_assign_local_prop` / `OP_set_local_prop` - read/write class properties by index - `OP_step_local` / `OP_incc_local` - For-loop step/increment with indexed counter - `OP_enumnext_local` - For-Each iteration with indexed loop variable This mirrors jscript's `OP_local` / `bind_local()` optimization (`dlls/jscript/compile.c`) and addresses the FIXME in `lookup_identifier()` noting that class property access should be bound at compile time. Names that cannot be resolved at compile time (globals in Execute/ExecuteGlobal code, dynamic vars, host objects) continue to use the existing string-based path. The last commit also adds a fast path for SAFEARRAY iteration that bypasses the `IEnumVARIANT` COM vtable dispatch and copies elements directly from the array data, eliminating one intermediate `VariantCopy` per iteration. ### Local variable / argument / class property access (1M iterations, 10 reads per iteration) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Local vars | 156 ms | 413 ms | 234 ms | **1.8x** | 1.5x slower | | Arguments | 171 ms | 357 ms | 231 ms | **1.5x** | 1.4x slower | | Class props | 265 ms | 393 ms | 226 ms | **1.7x** | 0.9x (faster!) | ### For-loop variants (10M iterations) | Benchmark | Windows (VM) | Wine master | Wine (7 commits) | **Speedup** | vs Windows | |-----------|-------------|-------------|-------------------|---------|------------| | Empty For | 117 ms | 370 ms | 270 ms | **1.4x** | 2.3x slower | | For + assign | 203 ms | 613 ms | 430 ms | **1.4x** | 2.1x slower | | Do-While manual | 437 ms | 646 ms | 513 ms | **1.3x** | 1.2x slower | | For Step 2 | 62 ms | 370 ms | 271 ms | **1.4x** | 4.4x slower | | Nested For | 125 ms | 387 ms | 268 ms | **1.4x** | 2.1x slower | | For local Sub | 109 ms | 294 ms | 251 ms | **1.2x** | 2.3x slower | | For R8 counter | 203 ms | 2,812 ms | 2,529 ms | **1.1x** | 12x slower | | For-Each array | 7 ms | 286 ms | 62 ms | **4.6x** | 8.9x slower | The remaining 4-13x gap vs Windows in For-loops is from `VarAdd`/`VarCmp` going through full `VariantChangeTypeEx` machinery (including locale alloc/free per call). A separate MR ([!10528](https://gitlab.winehq.org/wine/wine/-/merge_requests/10529)) adds I2/I4 fast paths in oleaut32 that bring integer loops within 1.2-1.9x of Windows when combined with this branch. -- v25: vbscript: Bind class properties at compile time. vbscript: Bind For-loop variables at compile time. vbscript: Factor out do_for_step and do_incc from interp_step and interp_incc. vbscript: Bind local variable assignments at compile time. vbscript: Factor out assign_local_var from assign_ident. vbscript: Bind local variables and arguments at compile time. https://gitlab.winehq.org/wine/wine/-/merge_requests/10515

2 6

[PATCH v25 0/2] MR10393: Draft: vbscript: Check named item dispatch for Dim variable names.
by Francis De Brabandere (＠francisdb) May 8, 2026

May 8, 2026

Matches native VBScript and prevents the dim-time refetch from clobbering the runtime IDispatch cache when a host returns distinct dispatches per GetItemInfo. -- v25: vbscript: Probe top-level declared names against the host dispatch. https://gitlab.winehq.org/wine/wine/-/merge_requests/10393

2 2

Re: [PATCH v6 0/1] MR10704: Display invalid Indic syllables
by समीरसिंह Sameer Singh (＠ss141309) May 8, 2026

May 8, 2026

On Fri May 1 19:38:32 2026 +0000, समीरसिंह Sameer Singh wrote: > Yes, the error seems to be gone now. I will test this patch some more > and will get back to you in a few days to report if I find something > else missing. Now for vowel signs like `ৌ` if it is at the start of the line, the pre-Matra portion of the glyph disappears. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10704#note_139191

1 0

[PATCH v24 0/2] MR10393: Draft: vbscript: Check named item dispatch for Dim variable names.
by Francis De Brabandere (＠francisdb) May 8, 2026

May 8, 2026

When declaring variables with Dim in a visible named item context, check the named item's IDispatch for each variable name via GetIDsOfNames. This matches Windows VBScript behavior where Dim probes the host object before creating the variable. -- v24: vbscript: Probe top-level declared names against the host dispatch. vbscript/tests: Cover named-item dim-probe IDispatch fetching. https://gitlab.winehq.org/wine/wine/-/merge_requests/10393

2 2

[PATCH v12 0/2] MR8635: oleaut32: Convert VT_BSTR numeric strings to VT_I4 in VarAnd
by Maotong Zhang (＠xiaotong) May 8, 2026

May 8, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56280 -- v12: oleaut32: Convert VT_BSTR numeric strings to VT_I4 in VarAnd. oleaut32/tests: Add more test cases for VarAnd https://gitlab.winehq.org/wine/wine/-/merge_requests/8635

3 3

Re: [PATCH v2 0/2] MR10715: mf: Call GetCorrelatedTime without critical section.
by Brendan McGrath (＠redmcg) May 8, 2026

May 8, 2026

v2: - rebase to master -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10715#note_139184

1 0

[PATCH 0/1] MR10830: Draft: winewayland: Use wp_pointer_warp_v1 for SetCursorPos when available.
by Zakaria HABRI (＠zakissimo) May 8, 2026

May 8, 2026

The existing SetCursorPos implementation abuses zwp_locked_pointer_v1's set_cursor_position_hint side-effect: it briefly locks the pointer, sets the position hint, then unlocks. The compositor clamps position hints to locked-surface bounds, so warps to coordinates outside that area are silently dropped, and the lock/unlock cycle has subtle timing and side-effect issues. wp_pointer_warp_v1 is a staging protocol added in wayland-protocols 1.45 (June 2025) that provides a direct cursor-warp primitive without requiring pointer locking. KWin \>=6.4, Mutter \>=49, and wlroots \>=0.19 already implement it on the compositor side. This MR adds support to winewayland.drv: when the compositor advertises the global and we have a recent enter serial, the new path is used; otherwise we fall back to the existing lock/hint workaround. ## Testing - KWin 6.6.4 (Plasma Wayland): protocol advertised, new path fires (verified via `WINEDEBUG=+waylanddrv` showing the new `warp_pointer hwnd=...` TRACE). - niri 26.04 (no protocol support): fallback path fires unchanged. - Fallback else-branch is byte-equivalent to upstream master (only `pending_warp = FALSE` was hoisted out of the if-block). ## References - Protocol spec: https://wayland.app/protocols/pointer-warp-v1 - Existing workaround MR: !7353 (cc @atticf — thanks for the original workaround that this MR complements) - SDL adoption: libsdl-org/SDL #10922 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10830

3 3