- Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/5] MR10208: winebth.sys part 15: Add support for reading/caching GATT characteristic values
by micha k (＠breiti) April 9, 2026

April 9, 2026

Hi @vibhavp , i just came across this PR by chance because i was researching a bit because we [Zwift on Linux users are looking to use Bluetooth pairing of our fitness equipment.](https://github.com/netbrain/zwift/issues/188#issuecomment-41320… However, when scanning the changelogs/code, i noticed that there is a small typo that occurs in the codebase: `characterisitic` (notice the superfluous "i" before the "t". correct: `characteristic`). Examples of symbols that use this: `winebth_gatt_service_read_characterisitic_value_params`, `IOCTL_WINEBTH_GATT_SERVICE_READ_CHARACTERISITIC_VALUE` Sorry for the noise on this already merged MR, i wanted to mention it somewhere so there is a chance that it can be remedied in a later MR at some point. Thank you for your work on bluetooth in wine. :raised_hands: Greatly appreciated! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10208#note_135670

1 0

[PATCH v6 0/2] MR10571: ntdll: Add NtCreateWaitablePort stub
by Rose Hellsing (＠axtlos) April 9, 2026

April 9, 2026

Some application call NtCreateWaitablePort, which made them crash since it wasn't available. By implementing a stub applications will at least not completely crash. Tested with StarMoney 10, which now throws an internal error instead of crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59494 -- v6: Add test for NtCreateWaitablePort https://gitlab.winehq.org/wine/wine/-/merge_requests/10571

2 4

Re: [PATCH v58 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 9, 2026

April 9, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/file.c: > + /* Handle \\?\ prefix (Extended Length Path) */ > + if (lstrlenW(shortpath) >= 4 && shortpath[0] == '\\' && shortpath[1] == '\\' > + && shortpath[2] == '?' && shortpath[3] == '\\') > + { > + if (wcsnicmp(shortpath + 4, L"UNC\\", 4) == 0) > + { > + FIXME("UNC Extended pathname %s\n", debugstr_w(shortpath)); > + tmplen = lstrlenW(shortpath); > + if (tmplen < longlen) > + { > + if (longpath != shortpath) lstrcpyW(longpath, shortpath); > + return tmplen; > + } > + return tmplen + 1; > + } > + else if ( isalpha(shortpath[4]) && shortpath[5] == ':') I have some reservations about using `isalpha` with `WCHAR`, since its behavior is not defined for wide characters and may vary depending on the locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_135664

1 0

Re: [PATCH v58 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 9, 2026

April 9, 2026

On Thu Apr 9 12:53:40 2026 +0000, Vishnunithyasoundhar S wrote: > Changed length of tmplongpath to maximum that can be reached by extended > file length path I'm a bit concerned about allocating 32KB on the stack, as that's quite large. Since adding proper length validation would make this patch more complex, I understand why you avoided it here. Would you leave the buffer size unchanged in this patch and create a follow-up patch that allocates the 32KB temporary buffer on the heap instead? That way we can avoid the stack usage issue without expanding the scope of this merge request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_135663

1 0

Re: [PATCH v2 0/3] MR10298: mfreadwrite: Implement sample encoding.
by Nikolay Sivov (＠nsivov) April 9, 2026

April 9, 2026

I would merge last two commits, because the second one does not do anything on its own. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10298#note_135655

1 0

Re: [PATCH v2 0/3] MR10298: mfreadwrite: Implement sample encoding.
by Nikolay Sivov (＠nsivov) April 9, 2026

April 9, 2026

Nikolay Sivov (@nsivov) commented about dlls/mfreadwrite/writer.c: > + HRESULT hr = S_OK; > + DWORD status; > + > + while (SUCCEEDED(hr)) > + { > + memset(&output_buffer, 0, sizeof(output_buffer)); > + if (FAILED(hr = allocate_transform_output(transform, &output_buffer.pSample))) > + break; > + > + if (SUCCEEDED(hr = IMFTransform_ProcessOutput(transform, 0, 1, &output_buffer, &status))) > + { > + if (next_transform) > + hr = stream_encode_sample(stream, output_buffer.pSample, next_transform, NULL); > + else > + hr = stream_queue_sample(stream, output_buffer.pSample); > + } This one is confusing. Why would be do encode_sample() more than once? Is it possible to have multiple encoders one after another? Or is the helper name simply misleading and it means "process" in general, instead of "encode"? What is the idea behind next_transform? It looks like this code allows two transforms at maximum, is there a limit to this chain on Windows? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10298#note_135654

1 0

[PATCH v3 0/3] MR10458: quartz: Reset the completion event on paused -> running transition.
by Akihiro Sagawa (＠sgwaki) April 9, 2026

April 9, 2026

Otherwise, `WaitForCompletion` returns immediately because the completion event remains set. -- v3: quartz: Don't leak the completion event handle. quartz: Reset the completion event on paused -> running transition. quartz/tests: Add IMediaEvent(Ex)::WaitForCompletion tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/10458

2 4

Re: [PATCH v5 0/1] MR8914: msxml: IXMLDOMNamedNodeMap::getNamedItem to handle global namespace. - closed
by Nikolay Sivov (＠nsivov) April 9, 2026

April 9, 2026

This merge request was closed by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8914

1 0

Re: [PATCH v5 0/1] MR8914: msxml: IXMLDOMNamedNodeMap::getNamedItem to handle global namespace.
by Nikolay Sivov (＠nsivov) April 9, 2026

April 9, 2026

Tests from this MR seem to work after !10599. I'm going to submit them separately, but we can close this now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8914#note_135637

1 0

[PATCH v3 0/2] MR10577: Fix build with old clang (<13).
by Vitaly Lipatov (＠lav) April 9, 2026

April 9, 2026

When clang < 13 cross-compiles for Windows, it sets _MSC_VER to 1911 (< 1912). The #if/#elif chain in __config checked _MSC_VER < 1912 first, which prevented the elif branch from defining _LIBCPP_DEFER_NEW_TO_VCRUNTIME. This caused placement new/delete to be defined in both vcruntime_new.h and the libc++ <new> header, resulting in redefinition errors. Since Wine always provides aligned allocation operators in vcruntime_new.h, simply remove the _MSC_VER < 1912 cases and always define _LIBCPP_DEFER_NEW_TO_VCRUNTIME when using the Microsoft ABI with vcruntime. Also add fall back to the wmemchr() call or manual loop on clang < 13. -- v3: include: Avoid __builtin_wmemchr with clang < 13. https://gitlab.winehq.org/wine/wine/-/merge_requests/10577

3 3