- Wine-GitLab - list.winehq.org

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

On Fri Apr 3 11:32:44 2026 +0000, Vishnunithyasoundhar S wrote: > I have addressed all ur comments @sgwaki Pls have a look thanks. > Also currently, some tests that my code change didnt even touch are > failing. Am I supposed to look into them too? Ideally, those failures should be verified, but if you're confident that your change cannot affect them, it's fine to ignore them. Personally, I would at least take a quick look to confirm that the failing tests don't use the API you modified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134950

1 0

[PATCH v3 0/7] MR10549: iyuv_32: Implement Decompression
by Brendan McGrath (＠redmcg) April 3, 2026

April 3, 2026

This MR adds I420 "decompression" functionality to the `iyuv_32.dll`. -- v3: iyuv_32: Implement IYUV_Decompress. iyuv_32: Implement IYUV_DecompressBegin. iyuv_32: Implement IYUV_Open. iyuv_32: Implement IYUV_DecompressGetFormat. iyuv_32: Implement IYUV_DecompressQuery. iyuv_32: Implement IYUV_GetInfo. winegstreamer: Add winegstreamer_create_color_converter. https://gitlab.winehq.org/wine/wine/-/merge_requests/10549

3 12

[PATCH v14 0/1] MR10532: crypt32: Implement PFXExportCertStoreEx support
by Benoît Legat (＠blegat) April 3, 2026

April 3, 2026

Part 2 of my attempt to run the [Niko Home Control programming software](https://appdb.winehq.org/objectManager.php?sClass=application&iId… under Wine. This .NET application ends up calling \``PFXExportCertStoreEx` (or `PFXExportCertStore` ) since it redirects to it which is a stub at the moment. According to the [documentation](https://learn.microsoft.com/en-us/windows/win32/api/wincrypt…, if the `EXPORT_PRIVATE_KEYS` flag is set, we should export the private key as well. For this, we use `NCryptExportKey` which is part of `ncrypt` so we have to add `ncrypt` to the `Makefile.in` as well. For exporting, I used GnuTLS library. As it seems to be only available in the unix side, I added a helper in `unixlib.c`. **EDIT** Looking at the behavior of Windows with the tests, it seems that when `cert` is `NULL` we should not fail but instead produce a valid but empty `PKCS#12`. I changed this to reflect Windows' behavior. -- v14: crypt32: Implement PFXExportCertStoreEx support https://gitlab.winehq.org/wine/wine/-/merge_requests/10532

3 2

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Thanks for the update -- the changes look much better overall. There are still a few areas that need some refinement, though. Since this will start handling extended-length path prefix in GetLongPathNameW function, you may also need to pay attention to the length of `tmplongpath`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134943

1 0

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/file.c: > return 0; > } > > - if (shortpath[0] == '\\' && shortpath[1] == '\\') > + /* Handle \\?\ prefix (Extended Length Path) */ > + if (wcslen(shortpath) >= 4 && shortpath[0] == '\\' && > + shortpath[1] == '\\' && shortpath[2] == '?' && shortpath[3] == '\\') { Please add a newline before `{` and `}`, and also use a 4‑space indentation instead of 2 spaces to match the surrounding code. The same style issue applies to the following lines, so the rest is omitted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134942

1 0

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/file.c: > return 0; > } > > - if (shortpath[0] == '\\' && shortpath[1] == '\\') > + /* Handle \\?\ prefix (Extended Length Path) */ > + if (wcslen(shortpath) >= 4 && shortpath[0] == '\\' && `lstrlenW` is preferred since it is already used elsewhere in this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134941

1 0

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/file.c: > + if (wcsnicmp(shortpath + 4, L"UNC\\", 4) == 0) { > + FIXME("UNC Extended pathname %s\n", debugstr_w(shortpath)); > + tmplen = lstrlenW(shortpath); > + if (tmplen < longlen) { > + if (longpath != shortpath) > + lstrcpyW(longpath, shortpath); > + return tmplen; > + } > + return tmplen + 1; > + } else if (shortpath[4] && shortpath[5] == ':') { > + tmplongpath[0] = '\\'; > + tmplongpath[1] = '\\'; > + tmplongpath[2] = '?'; > + tmplongpath[3] = '\\'; > + tmplongpath[4] = shortpath[4]; > + tmplongpath[5] = shortpath[5]; Since you're copying six characters manually, couldn't this be rewritten as `lstrcpynW(tmplongpath, shortpath, 6)` ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134940

1 0

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/path.c: > length = GetLongPathNameW(shortpath, NULL, 0); > ok(length == expanded, "Expected %ld, got %ld\n", expanded, length); > > + /* Test that extended prefix is preserved in output when converting from > + * short to long path */ > + shortpath2[0] = 0; > + length = GetShortPathNameW(dirpath, shortpath2, ARRAY_SIZE(shortpath2)); > + ok(length, "GetShortPathNameW failed: %lu\n", GetLastError()); > + ok(lstrcmpiW(dirpath, shortpath2) != 0, > + "short path name isn't created, got %s\n", debugstr_w(shortpath2)); > + SetLastError(0xdeadbeef); > + length = GetLongPathNameW(shortpath2, longpath, ARRAY_SIZE(longpath)); > + trace("longpath: %s\n", wine_dbgstr_w(longpath)); // to be removed > + ok(length > 0, "GetLongPathNameW failed: %ld\n", GetLastError()); This condition is inconsistent with line 1333, where the same check is written as `length`. It's also acceptable to update line 1333 to match the expression used here. You should use `%lu` instead of `%ld` for `GetLastError()` since it is `DWORD (unsigned long)`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134939

1 0

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/path.c: > length = GetLongPathNameW(shortpath, NULL, 0); > ok(length == expanded, "Expected %ld, got %ld\n", expanded, length); > > + /* Test that extended prefix is preserved in output when converting from > + * short to long path */ > + shortpath2[0] = 0; > + length = GetShortPathNameW(dirpath, shortpath2, ARRAY_SIZE(shortpath2)); > + ok(length, "GetShortPathNameW failed: %lu\n", GetLastError()); > + ok(lstrcmpiW(dirpath, shortpath2) != 0, > + "short path name isn't created, got %s\n", debugstr_w(shortpath2)); > + SetLastError(0xdeadbeef); > + length = GetLongPathNameW(shortpath2, longpath, ARRAY_SIZE(longpath)); > + trace("longpath: %s\n", wine_dbgstr_w(longpath)); // to be removed It looks like this line was forgotten to be removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134938

1 0

Re: [PATCH v46 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW
by Akihiro Sagawa (＠sgwaki) April 3, 2026

April 3, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/path.c: > ok(length == expanded, "Expected %ld, got %ld\n", expanded, length); > > + /* Test that extended prefix is preserved in output when converting from > + * short to long path */ > + shortpath2[0] = 0; > + length = GetShortPathNameW(dirpath, shortpath2, ARRAY_SIZE(shortpath2)); > + ok(length, "GetShortPathNameW failed: %lu\n", GetLastError()); > + ok(lstrcmpiW(dirpath, shortpath2) != 0, > + "short path name isn't created, got %s\n", debugstr_w(shortpath2)); > + SetLastError(0xdeadbeef); > + length = GetLongPathNameW(shortpath2, longpath, ARRAY_SIZE(longpath)); > + trace("longpath: %s\n", wine_dbgstr_w(longpath)); // to be removed > + ok(length > 0, "GetLongPathNameW failed: %ld\n", GetLastError()); > + ok(!wcsncmp(longpath, dirpath, lstrlenW(dirpath)), > + "Expected path: %s, got: %s\n", wine_dbgstr_w(dirpath), > + wine_dbgstr_w(longpath)); Using `lstrcmpiW` seems more appropriate than `wcsncmp` in this context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_134937

1 0