- Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR10497: vbscript: Return specific error codes for unterminated block statements. - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10497

1 0

[PATCH v6 0/1] MR10600: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

For VT_DISPATCH arguments, call the object's default property (DISPID_VALUE) to get a string value instead of returning the object via VariantCopy (Eval) or returning type mismatch (Execute/ ExecuteGlobal). This matches Windows behavior where passing a dispatch object without a default property fails with error 438, and objects with a default property have it invoked to obtain the string to evaluate or execute. -- v6: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal. https://gitlab.winehq.org/wine/wine/-/merge_requests/10600

3 4

Re: [PATCH v2 0/2] MR10702: wscript: Implement WScript.Timeout and //T:nn - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10702

1 0

Re: [PATCH v4 0/2] MR8331: iertutil: Fix out-of-bound access in remove_dot_segments. - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8331

1 0

Re: [PATCH v2 0/1] MR10700: iertutil: Fix wrong host type for Punycode-encoded hostnames. - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10700

1 0

Re: [PATCH v2 0/3] MR10703: opengl32: Misc client-side handle table fixes. - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10703

1 0

Re: [PATCH v7 0/5] MR10550: winex11: Keyboard layouts rework, part 1 - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10550

1 0

Re: [PATCH v2 0/3] MR10690: wineandroid: refactoring and cleanup changes (part of !10569) - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10690

1 0

Re: [PATCH v2 0/1] MR10699: Revert "win32u: Don't forcefully activate windows before restoring them." - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10699

1 0

Re: [PATCH v3 0/1] MR10556: odbc32: Report SQL_TIMESTAMP format for timestamp data in ODBC 2.x application. - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10556

1 0

Re: [PATCH v8 0/1] MR10561: secur32: Fix handling by SChannel for CNG/NCrypt client certificates for mTLS - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10561

1 0

Re: [PATCH v6 0/3] MR10487: winewayland: Fix display freeze for games that fake-minimize - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10487

1 0

Re: [PATCH v2 0/1] MR10694: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) April 20, 2026

April 20, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10694

1 0

Re: [PATCH v2 0/7] MR10688: msxml3: Improvements to setAttribute().
by Nikolay Sivov (＠nsivov) April 20, 2026

April 20, 2026

On Mon Apr 20 11:42:09 2026 +0000, Nikolay Sivov wrote: > Great, thank you. Could you try if !10705 helps? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10688#note_137130

1 0

[PATCH 0/1] MR10705: msxml3: Fix owner node refcount update when adding children and attributes.
by Nikolay Sivov (＠nsivov) April 20, 2026

April 20, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10705

2 1

[PATCH v2 0/5] MR10677: amstream: Test and fix media type enum on ddraw stream.
by Brendan McGrath (＠redmcg) April 20, 2026

April 20, 2026

This MR adds new tests and subsequent fixes for the type returned by `IEnumMediaTypes::Next` on the `IEnumMediaTypes` retrieved from the `IPin::EnumMediaTypes` function on the Direct Draw media stream. -- v2: amstream: Return connected media subtype in enum if connected. amstream: Return current format in media type enum. amstream/tests: Test enum media type on disconnect. amstream/tests: Test enum media type whilst connected. amstream/tests: Test enum media type with ddraw. https://gitlab.winehq.org/wine/wine/-/merge_requests/10677

3 8

[PATCH v11 0/1] MR10484: vbscript: Return "Invalid for loop control variable" error for member expressions.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

Windows VBScript rejects member expressions (e.g. x.y) as For/For Each loop control variables with error 1040. Accept MemberExpression in the parser rules and check for obj_expr to report the proper error instead of a generic syntax error. -- v11: vbscript: Return "Invalid for loop control variable" error for member expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10484

2 1

Re: [PATCH v10 0/7] MR10604: setupapi, ntoskrnl: Implement CM_Get_Parent with device tree properties
by Elizabeth Figura (＠zfigura) April 20, 2026

April 20, 2026

On Fri Apr 17 19:58:07 2026 +0000, Jan Robert Gerigk wrote: > I have addressed all three points: > 2/7 and 3/7: removed the scope blocks, moved parent_id\[\] (and friends > in 3/7: parent_sp, child_ids, count) to the functions declaration block. > 7/7: replaced the non-empty check with ok(!wcscmp(buffer_w, > L"ROOT\\WINETEST\\0"), ...) plus a matching size check. As a side > effect, 4/7s scope block and duplicate child_ids/count are gone. The > Siblings loop now reuses the function-level vars from 3/7, with a single > free() at the end. And tests for 1/7, 3/7, and 4/7? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10604#note_137123

1 0

[PATCH v9 0/3] MR10603: win32u/freetype: Fix tmExternalLeading for CFF fonts.
by Arie Miller (＠Arimil) April 20, 2026

April 20, 2026

This fixes font scaling issues with CFF fonts this was discovered from games utilizing DxLib. https://github.com/yumetodo/DxLib/tree/master https://dxlib.xsrv.jp/index.html I've ran tests on Windows and to confirm that this change is consistent with a number of fonts. Before: ![image.png](/uploads/a398d5543df8561f1a6fbe9edded3b45/image.png){width="801" height="600"} After (this matches the windows visual from testing in a VM): ![image.png](/uploads/cf4e4c8753b3482dd24211b519a5fe23/image.png){width="767" height="572"} Related Proton Issue: https://github.com/ValveSoftware/Proton/issues/7299 Full Disclosure: An LLM was used to assist in finding this bug, the original fix written by the LLM wrote a loader binary that changed the pointers for `GetTextMetricsA` and `GetTextMetricsW` to point to a custom implementation that always set `tmExternalLeading`. The LLM determined that `GDI returns 0 when (winAscent + winDescent) > (Ascender - Descender)`, after testing on WIndows I found this to be incorrect, the actual difference is that CFF fonts always set `tmExternalLeading` to 0. ~~The test case for this fix was LLM generated but reviewed and tested on both Windows and Linux by me.~~ Test case: ``` WINEPREFIX=/tmp/wine-font winetricks allfonts WINEPREFIX=/tmp/wine-font ./loader/wine ./dlls/gdi32/tests/i386-windows/gdi32_test.exe ``` Patched: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (0 failures) ``` Unpatched Wine: ``` font.c:4266: test_CFF_external_leading: tested 51 CFF fonts (51 failures) ``` Windows 11: ``` font.c:4266: test_CFF_external_leading: tested 48 CFF fonts (0 failures) ``` -- v9: gdi32: Add test for tmExternalLeading for CFF fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/10603

3 11

[PATCH v5 0/1] MR10600: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

For VT_DISPATCH arguments, call the object's default property (DISPID_VALUE) to get a string value instead of returning the object via VariantCopy (Eval) or returning type mismatch (Execute/ ExecuteGlobal). This matches Windows behavior where passing a dispatch object without a default property fails with error 438, and objects with a default property have it invoked to obtain the string to evaluate or execute. -- v5: vbscript: Convert VT_DISPATCH arguments to string in Eval/Execute/ExecuteGlobal. https://gitlab.winehq.org/wine/wine/-/merge_requests/10600

3 4

[PATCH v21 0/3] MR10464: vbscript: Return "Name redefined" error for duplicate declarations.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

When a name is defined twice (Const/Const, Dim/Const, Const/Dim, Dim/Dim, Sub vs Const/Dim, Class vs Const/Dim/Function, duplicate class members), Windows returns VBScript error 1041 ("Name redefined"). Wine was returning E_FAIL. Store source locations in const_decl_t, dim_decl_t, function_decl_t, and class_decl_t so errors point to the duplicate name. Also fix duplicate Sub/Function/Property/Dim detection inside classes, including the case where a Property collides with an existing Sub/Function. -- v21: vbscript: Return "Name redefined" error for duplicate class members. vbscript: Return "Name redefined" error for duplicate global declarations. vbscript: Track source location in const, class, and function declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/10464

3 4

[PATCH v2 0/1] MR10496: vbscript: Return error 1045 for non-literal constant expressions.
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

When a Const declaration uses a non-literal expression (e.g. "Const x = 1 + \"a\""), Windows parses the full expression and then rejects it with error 1045 ("expected literal constant"). Change ConstDecl to accept Expression instead of ConstExpression, and validate in new_const_decl() that the expression is a literal or negated numeric literal. Remove the now-unused ConstExpression rule. This fixes both the error code (was generic E_FAIL/16389) and the error character position (now points to the end of the expression). -- v2: vbscript: Return error 1045 for non-literal constant expressions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10496

3 2

[PATCH 0/2] MR10702: wscript: Implement WScript.Timeout and //T:nn
by Francis De Brabandere (＠francisdb) April 20, 2026

April 20, 2026

Wires up the WScript.Timeout property and its command-line counterpart //T:nn, both of which were no-op stubs. Commit 1: WScript.Timeout property + //T:nn parsing. Default 0, negative values rejected with VBScript error 5 (matches Windows). //T:nn sets the same value, readable from the script. Commit 2: Actual expiry. A timer thread is armed when Timeout > 0 (from either entry point). On expiry it prints the standard native message to the console and exits with code 1. Setting Timeout to 0 or re-assigning mid-script cancels/re-arms the timer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10702

3 3

[PATCH v3 0/2] MR8331: iertutil: Fix out-of-bound access in remove_dot_segments.
by Yuxuan Shui (＠yshui) April 20, 2026

April 20, 2026

* * * As you can see from the ~~[test results](https://testbot.winehq.org/JobDetails.pl?Key=158742)~~ (link expired), this seems to be bugged on native. I don't know if we need to replicate native's behavior -- v3: iertutil: Fix out-of-bound access in remove_dot_segments. https://gitlab.winehq.org/wine/wine/-/merge_requests/8331

3 4

[PATCH 0/1] MR10700: iertutil: Fix wrong host type for Punycode-encoded hostnames.
by Zhiyi Zhang (＠zhiyi) April 20, 2026

April 20, 2026

It's something that I encountered when I was working on IUriRuntimeClass. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10700

3 2