- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR10946: shell32: Don't add backslash after SHGetSpecialFolderPathW.
by Arie Miller (＠Arimil) May 19, 2026

May 19, 2026

This fixes a regression implemented in 984f608c2885c80284ca8f35d6ad72d5193b3658 this breaks the game [Hyperdevotion Noire](https://store.steampowered.com/app/415480/Hyperdevotion_Noire_Goddes…. This game runs in proton 6.3-8 but is broken on versions after that. It seems most applications don't care about this, but this one in particular will crash when trying to access the My Documents directory due to this. -- v2: shell32: Don't add backslash after SHGetSpecialFolderPathW. https://gitlab.winehq.org/wine/wine/-/merge_requests/10946

2 1

Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c: > int index_offset; > int write_dir = (analysis->fRTL && !analysis->fLogicalOrder) ? -1 : 1; > int offset_sign = (analysis->fRTL && analysis->fLogicalOrder) ? -1 : 1; > + unsigned int k = glyph_index + write_dir; Again, `k` for a long-lived variable is unfortunate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140532

1 0

Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c: > > for (k = 0; k < backtrack_count; ++k) > { > + unsigned int j; > offset = GET_BE_WORD(backtrack->Coverage[k]); > - if (GSUB_is_glyph_covered((const BYTE *)backtrack + offset, > - glyphs[glyph_index + (dirBacktrack * (k + 1))]) == -1) > + j = glyph_index + (dirBacktrack * (k + 1)); Could we come up with a better name than `j` (especially as it's in a loop over `k`)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140531

1 0

Re: [PATCH v9 0/1] MR10660: uniscribe: Correct possible buffer over/under runs
by Huw Davies (＠huw) May 19, 2026

May 19, 2026

Huw Davies (@huw) commented about dlls/gdi32/uniscribe/opentype.c: > if (mark_index != -1) > { > int mark2_index; > + unsigned int next_glyph_index = glyph_index - write_dir; > + if (next_glyph_index >= glyph_count) { Do we need to worry about `next_glyph_index < 0`? Also, opening brace on new line seems to be the majority style here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10660#note_140530

1 0

[PATCH 0/2] MR10947: win32u: Simplify internal small class icon creation.
by Rémi Bernon (＠rbernon) May 19, 2026

May 19, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10947

2 2

[PATCH 0/3] MR10919: dsound cleanup
by Matteo Bruni (＠Mystral) May 19, 2026

May 19, 2026

This incorporates / supersedes !10882 and !10886. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10919

4 5

[PATCH v2 0/2] MR10913: Various IME fixes for FFXIV
by Marc-Aurel Zent (＠mzent) May 19, 2026

May 19, 2026

These are small fixes that make sure that FFXIV correctly sees the current input source as IME capable, so the game will display an IME icon next to its chat box (IME input actually working is independent of this). On macOS, there is no such concept as open or closed IME. Whenever an IME keyboard layout is active, we should open/close the IME that is currently active. -- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/10913

3 5

[PATCH 0/1] MR10946: shell32: Don't add backslash after SHGetSpecialFolderPathW.
by Arie Miller (＠Arimil) May 19, 2026

May 19, 2026

This fixes a regression implemented in 984f608c2885c80284ca8f35d6ad72d5193b3658 this breaks the game Hyperdevotion Noire. https://store.steampowered.com/app/415480/Hyperdevotion_Noire_Goddess_Black… This game runs in proton 6.3-8 but is broken on versions after that. It seems most applications don't care about this, but this one in particular will crash when trying to access the My Documents directory due to this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10946

2 1

[PATCH v2 0/2] MR10927: vbscript: Mark class member fixed-size arrays as FADF_FIXEDSIZE
by Francis De Brabandere (＠francisdb) May 19, 2026

May 19, 2026

When a class member is declared with explicit bounds (Private mArr(N) or Public mArr(N)) the SAFEARRAY created at instance construction was missing FADF_FIXEDSIZE, so interp_redim's fixed-size guard silently accepted a later ReDim from a method body. Set the flag (and FADF_STATIC) to match interp_dim's handling of local fixed-size arrays, so ReDim raises err 10 like native. -- v2: vbscript: Mark class member fixed-size arrays as FADF_FIXEDSIZE. vbscript/tests: Add tests for ReDim on class member arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/10927

2 2

[PATCH 0/1] MR10945: wineandroid: Update Z-order on window activation.
by Twaik Yont (＠twaik) May 19, 2026

May 19, 2026

Handle pActivateWindow by forwarding the activation-related Z-order change through ioctl_window_pos_changed(). This fixes activated windows not being visually raised to the front when clicked. <details> <summary>video demonstrating the issue</summary> ![Screencast_20260519_073246](/uploads/9db08716c58a572eb7772e37ae50ec85/Screencast_20260519_073246.webm){width=866 height=600} </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10945

2 1