- Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) June 23, 2023

June 23, 2023

On Fri Jun 23 19:02:05 2023 +0000, Davide Beatrici wrote: > I would expect the same behavior for `PFD_DRAW_TO_BITMAP` though. Aren't > both the same flag "class"? I guess we need more tests to be sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36674

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Davide Beatrici (＠davidebeatrici) June 23, 2023

June 23, 2023

On Fri Jun 23 18:54:52 2023 +0000, Damjan Jovanovic wrote: > I don't think it works like that. If the flag is set, it only returns a > PIXELFORMATDESCRIPTOR with the flag set, but if it is clear, then the > returned PIXELFORMATDESCRIPTOR can have the flag set or cleared. I would expect the same behavior for `PFD_DRAW_TO_BITMAP` though. Aren't both the same flag "class"? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36673

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Damjan Jovanovic (＠dj) June 23, 2023

June 23, 2023

On Fri Jun 23 18:48:33 2023 +0000, Davide Beatrici wrote: > For consistency: > ```suggestion:-0+0 > if ((ppfd->dwFlags & PFD_SUPPORT_GDI) != (format.dwFlags & PFD_SUPPORT_GDI)) > ``` I don't think it works like that. If the flag is set, it only returns a PIXELFORMATDESCRIPTOR with the flag set, but if it is clear, then the returned PIXELFORMATDESCRIPTOR can have the flag set or cleared. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36672

1 0

Re: [PATCH v3 0/2] MR3111: opengl32: treat the PFD_SUPPORT_GDI flag to ChoosePixelFormat() as mandatory
by Davide Beatrici (＠davidebeatrici) June 23, 2023

June 23, 2023

Davide Beatrici (@davidebeatrici) commented about dlls/opengl32/wgl.c: > continue; > } > > + if ((ppfd->dwFlags & PFD_SUPPORT_GDI) && !(format.dwFlags & PFD_SUPPORT_GDI)) For consistency: ```suggestion:-0+0 if ((ppfd->dwFlags & PFD_SUPPORT_GDI) != (format.dwFlags & PFD_SUPPORT_GDI)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3111#note_36671

1 0

[PATCH 0/1] MR1045: include: Add wine/winrt.h and define IInspectable helpers there.
by Paul Gofman (＠gofman) June 23, 2023

June 23, 2023

And use that instead of duplicating those helpers across the tree. Besides removing existing duplicates, I am planning to add yet another WinRT dll (gamepad) and we will likely add more in the future, each of those can use that, as well as potentially more common helpers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1045

5 6

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting. - closed
by Rémi Bernon June 23, 2023

June 23, 2023

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311

1 0

[PATCH v2 0/9] MR3122: Implement FileDispositionInformationEx
by Joel Holdsworth (＠jhol) June 23, 2023

June 23, 2023

This MR supercedes !1895 and !3073 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FileDispositionInformationEx` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. All the flags of `FileDispositionInformationEx` are implemented with the exception of `FILE_DISPOSITION_FORCE_IMAGE_SECTION_CHECK`. This MR improves upon !3073 by implementing `FILE_DISPOSITION_POSIX_SEMANTICS` and `FILE_DISPOSITION_ON_CLOSE` where the previous MR only implemented `FILE_DISPOSITION_DELETE` and `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE`. -- v2: ntdll: Implement FILE_DISPOSITION_POSIX_SEMANTICS server: Replace unlink member of closed_fd with disp_flags ntdll/tests: Add tests for FILE_DISPOSITION_POSIX_SEMANTICS https://gitlab.winehq.org/wine/wine/-/merge_requests/3122

3 12

[PATCH 0/2] MR3146: Implement dbghelp.SymSrvGetFileIndexInfo for PDB files (DS format).
by eric pouech (＠epo) June 23, 2023

June 23, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3146

2 2

[PATCH v2 0/1] MR3022: kernelbase: In AllocConsole(), dispose existing unix console.
by eric pouech (＠epo) June 23, 2023

June 23, 2023

Unix consoles (created from initial process) are inherited by child processes for various reasons, like keeping std handles bound to that unix console. This differs from Windows as the default for a GUI is not to have console attached. If a GUI programs asks for a console, it will succeed on Windows but fail under Wine as the Unix console is still present. So, allow AllocConsole() to succeed when called from a GUI program and tied to a Unix console. (don't do it for CUI as they are already attached to a console). This fixes Scrap Mechanic when run with '-dev' option. (based on suggestion from Zhiyi Zhang) Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: kernelbase: Only inherit consoles for CUI processes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3022

3 9

[PATCH 0/1] MR3145: ntdll: Inherit ConsoleHandle only by CUI processes.
by Jacek Caban (＠jacek) June 23, 2023

June 23, 2023

Based on !3022. We could also consider applying that logic to `get_initial_console`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3145

3 3