- Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) May 18, 2023

May 18, 2023

On Thu May 18 20:22:26 2023 +0000, Francisco Casas wrote: > Indeed, I didn't have the big picture in mind. returning false keeps the > original instruction. > However, I also think that we should go for the change in case we ever > call hlsl_fold_constant_exprs() from somewhere else. This change seems like it would break the result - do we want it to be more like ``` bool success = true; ... case HLSL_TYPE_INT: /* Always evaluate this expression... */ dst->value.u[k].i = abs(src->value.u[k].i); /* ... but if we try abs(INT_MIN), mark this fold as invalid */ if (src->value.u[k].i == INT_MIN) { success = false; } break; ... return success; ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33141

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Francisco Casas (＠fcasas) May 18, 2023

May 18, 2023

On Thu May 18 20:19:08 2023 +0000, Zebediah Figura wrote: > > I might have misread, but doesn't the return value apply to the full > vector and not its components? I thought returning false made it so the > whole abs op was left alone if any component was INT_MIN, like an > all-or-nothing deal. > That is the case, yes. That said, I believe we want to make that change anyway. Indeed, I didn't have the big picture in mind. returning false keeps the original instruction. However, I also think that we should go for the change in case we ever call hlsl_fold_constant_exprs() from somewhere else. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33140

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Zebediah Figura (＠zfigura) May 18, 2023

May 18, 2023

> I might have misread, but doesn't the return value apply to the full vector and not its components? I thought returning false made it so the whole abs op was left alone if any component was INT_MIN, like an all-or-nothing deal. That is the case, yes. That said, I believe we want to make that change anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33139

1 0

[PATCH 0/1] MR2852: winemac: Add missing event to dbgstr_event().
by Brendan Shanks (＠bshanks) May 18, 2023

May 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2852

3 2

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) May 18, 2023

May 18, 2023

On Thu May 18 19:54:01 2023 +0000, Francisco Casas wrote: > This won't get the absolute value of components that come after the > component that is INT_MIN. > Consider an int vector such as `(-1, INT_MIN, -1, -1)`; This would end > up as `(1, INT_MIN, -1, -1)`. > I think it would be better to guard the assignment: > ```c > case HLSL_TYPE_INT: > /* abs(INT_MIN) is undefined, leave this expression > alone */ > if (src->value.u[k].i != INT_MIN) > dst->value.u[k].i = abs(src->value.u[k].i); > break; > ``` I might have misread, but doesn't the return value apply to the full vector and not its components? I thought returning false made it so the whole abs op was left alone if any component was INT_MIN, like an all-or-nothing deal. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33136

1 0

[PATCH v5 0/1] MR2346: winsqlite3: Add stub DLL.
by Tareque Md Hanif (＠tmdh) May 18, 2023

May 18, 2023

Required to run winget package manager. -- v5: winsqlite3: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2346

3 4

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Francisco Casas (＠fcasas) May 18, 2023

May 18, 2023

Francisco Casas (@fcasas) commented about libs/vkd3d-shader/hlsl_constant_ops.c: > + { > + switch (type) > + { > + case HLSL_TYPE_FLOAT: > + case HLSL_TYPE_HALF: > + dst->value.u[k].f = fabsf(src->value.u[k].f); > + break; > + > + case HLSL_TYPE_DOUBLE: > + dst->value.u[k].d = fabs(src->value.u[k].d); > + break; > + > + case HLSL_TYPE_INT: > + /* abs(INT_MIN) is undefined, leave this expression alone */ > + if (src->value.u[k].i == INT_MIN) > + return false; This won't get the absolute value of components that come after the component that is INT_MIN. Consider an int vector such as `(-1, INT_MIN, -1, -1)`; This would end up as `(1, INT_MIN, -1, -1)`. I think it would be better to guard the assignment: ```c case HLSL_TYPE_INT: /* abs(INT_MIN) is undefined, leave this expression alone */ if (src->value.u[k].i != INT_MIN) dst->value.u[k].i = abs(src->value.u[k].i); break; ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33133

1 0

[PATCH v10 0/4] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) May 18, 2023

May 18, 2023

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v10: test host_os echoing https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 5

[PATCH 0/1] MR2851: localspl: Fix wow64_start_doc Wow64 entry point.
by Piotr Caban (＠piotr) May 18, 2023

May 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2851

4 3

[PATCH 0/1] MR2850: gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll
by Bartosz Kosiorek (＠gang65) May 18, 2023

May 18, 2023

I have investigated `GdipGetGenericFontFamily*` functions from native gdiplus.dll. The result of investigation * GdipGetGenericFontFamilySansSerif: is taking first `"Microsoft Sans Serif"` font, then `Arial` [(here is the comparison)](http://www.identifont.com/differences?first=Microsoft+Sans+Ser…) The replacement for Arial is `"Liberation Sans"`. [(here is the comparison)](http://www.identifont.com/differences?first=Liberation+Sans&se…) If these fonts are not found then [`Tahoma` is taken.](http://www.identifont.com/differences?first=Liberation+Sans&second=… * GdipGetGenericFontFamilySerif: If `"Times New Roman"` is not found, then the fonts from `GdipGetGenericFontFamilySansSerif` is taken. * GdipGetGenericFontFamilyMonospace: If `"Courier New"` is not found, then the fonts from `GdipGetGenericFontFamilySansSerif` is taken. More information about Free Fonts: https://en.wikipedia.org/wiki/Liberation_fonts -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2850

3 2