- Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by Nikolay Sivov (＠nsivov) April 25, 2023

April 25, 2023

Nikolay Sivov (@nsivov) commented about dlls/shlwapi/string.c: > + { > + case SFBS_FLAGS_ROUND_TO_NEAREST_DISPLAYED_DIGIT: > + dBytes = round(dBytes / bfFormats[i].dDivisor) / bfFormats[i].dNormaliser; > + break; > + case SFBS_FLAGS_TRUNCATE_UNDISPLAYED_DECIMAL_DIGITS: > + dBytes = floor(dBytes / bfFormats[i].dDivisor) / bfFormats[i].dNormaliser; > + break; > + default: > + return E_INVALIDARG; > + } > > + /* Not sure about the error code. Can't find a way to trigger the error here */ > if (!FormatDouble(dBytes, bfFormats[i].nDecimals, lpszDest, cchMax)) > - return NULL; > + return E_UNEXPECTED; > + E_FAIL is probably more generic. Also comment is not really needed here. I'd also remove documentation comments before function declaration, leaving just function name there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_31101

1 0

[PATCH 0/4] MR2703: wineps: default device font, paths drawing and multiple pages document fixes
by Piotr Caban (＠piotr) April 25, 2023

April 25, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2703

4 6

[PATCH v4 0/5] MR2672: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) April 25, 2023

April 25, 2023

Needed for Minecraft Legends. -- v4: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0. twinapi.appcore: Add UnregisterAppStateChangeNotification stub. twinapi.appcore: Add RegisterAppStateChangeNotification stub. twinapi.appcore: Add stub DLL. include: Add appnotify.h file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2672

4 7

[PATCH v2 0/6] MR2628: Some more shell32 improvements.
by Jactry Zeng (＠jactry) April 25, 2023

April 25, 2023

-- v2: shell32: Update view mode flags while creating IShellView for IExplorerBrowser. shell32: Reimplement IExplorerBrowser_SetFolderSettings() with support of setting flags. shell32/tests: Move tests of IExplorerBrowser_SetFolderSettings() to a separated function and more tests. shell32: Reimplement IFolderView2_SetCurrentViewMode() with modern behaviours. shell32: Implement IFolderView2_{Get, Set}CurrentFolderFlags(). shell32/tests: Add tests for IFolderView2_{Get, Set}CurrentFolderFlags(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2628

2 7

[PATCH v2 0/2] MR2697: winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option().
by Vova Mshanetskiy (＠vovams) April 25, 2023

April 25, 2023

This is needed for mod.io integration in game "The Entropy Centre". Without support for this option the game hangs when trying to authenticate. Please note that i do not know how Wine works, and have very little understanding of what i am doing. I copied and adjusted code from `connect_query_option()` in the same file. The game does work with this patch though. -- v2: winhttp: Avoid unnecessary cast in connect_query_option(). winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2697

5 6

[PATCH v11 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) April 25, 2023

April 25, 2023

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v11: shell32: Fix last parameter behavior in SHBindToFolderIDListParent(). shell32/tests: Test SHBindToParent() last parameter behavior. shell32/tests: Add SHBindToFolderIDListParent() tests. shell32: Implement SHBindToFolderIDListParent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 7

[PATCH v7 0/13] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) April 24, 2023

April 24, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v7: vkd3d-shader/hlsl: Consider duplicated input semantic types equivalent in SM1. vkd3d-shader/hlsl: Handle possibly different types in input semantic var load. vkd3d-shader/hlsl: Error out when a semantic is used with incompatible types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Support semantics for array types. vkd3d-shader/hlsl: Don't create semantic vars more than once. vkd3d-shader/hlsl: Move get_array_size() and get_array_type() to hlsl.c. tests: Test duplicated semantics. tests: Test array types with semantics. vkd3d-shader/hlsl: Avoid invalid input/output copies for non-numeric types. tests: Map unindentified hrs on compilation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

2 15

[PATCH v2 0/4] MR2695: wine{alsa,coreaudio,oss,pulse}: Use dedicated macros to call interface functions.
by Davide Beatrici (＠davidebeatrici) April 24, 2023

April 24, 2023

-- v2: winepulse: Use dedicated macros to call interface functions. wineoss: Use dedicated macros to call interface functions. winecoreaudio: Use dedicated macros to call interface functions. winealsa: Use dedicated macros to call interface functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2695

3 5

Re: [PATCH v3 0/2] MR2674: d3d10: Use the vkd3d-shader DXBC API. - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2674

1 0

Re: [PATCH v2 0/1] MR2696: ntdll: Avoid integer overflow in block_get_subheap(). - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2696

1 0