- Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 12:10:54 2023 +0000, Philip Karlsson Gisslow wrote: > I see, I changed it now. Excellent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20369

1 0

Re: [PATCH v6 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 12:04:49 2023 +0000, Bernhard Kölbl wrote: > Maybe something along the lines of: "msi: Initialize WINTRUST_DATA to > zero." ? I see, I changed it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20368

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 11:45:30 2023 +0000, Philip Karlsson Gisslow wrote: > Thank you for taking the time Bernhard, I am not sure what I am missing, > the dot after the first sentence? I really want to get this right as I > would be happy to help out contributing more going forward. Maybe something along the lines of: "msi: Initialize WINTRUST_DATA to zero." ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20364

1 0

[PATCH 0/4] MR1913: Fix winedbg module's search path.
by eric pouech (＠epo) Jan. 5, 2023

Jan. 5, 2023

This series solves https://bugs.winehq.org/show_bug.cgi?id=54250 The two first patches address proper loading of modules in dbghelp. There are cases where the path sent in the dll load debug event isn't the real path to the loaded module. The two last patches are to expose the real path of the module for integration in when winedbg acts as a proxy to gdb. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1913

3 4

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 11:43:46 2023 +0000, Bernhard Kölbl wrote: > Just wanna take the time to point out that the commit message isn't > matching Wine's requirements > https://wiki.winehq.org/Submitting_Patches#The_commit_message . Thank you for taking the time Bernhard, I am not sure what I am missing, the dot after the first sentence? I really want to get this right as I would be happy to help out contributing more going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20363

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl Jan. 5, 2023

Jan. 5, 2023

Just wanna take the time to point out that the commit message isn't matching Wine's requirements https://wiki.winehq.org/Submitting_Patches#The_commit_message . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20362

1 0

Re: [PATCH v5 0/1] MR1907: user32: Set 32-bit base address.
by Patrick Szczepański Jan. 5, 2023

Jan. 5, 2023

@gverm Okey, it's done - sorry for bunch of force-updated commits, I just noticed how wine-team is paying attention to details and I'm trying to fit into the rules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907#note_20361

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized - approved
by Hans Leidekker (＠hans) Jan. 5, 2023

Jan. 5, 2023

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

1 0

[PATCH v2 0/1] MR1912: winevulkan: Enable VK_EXT_hdr_metadata
by Joshua Ashton (＠joshua) Jan. 5, 2023

Jan. 5, 2023

This works fine with the new struct conversions, and is needed for HDR with native Vulkan games such as Doom Eternal and games using HDR with DXVK and VKD3D-Proton. -- v2: winevulkan: Enable VK_EXT_hdr_metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/1912

2 1

Re: [PATCH v4 0/1] MR1907: user32: Set 32-bit base address.
by Gijs Vermeulen (＠gverm) Jan. 5, 2023

Jan. 5, 2023

@PSzczepanski1996 You'll need to set the author of your commit to your real name as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907#note_20357

1 0