- Wine-GitLab - list.winehq.org

[PATCH 0/5] MR1756: ntdll: Various performance improvements to hash_short_file_name.
by Rémi Bernon Dec. 9, 2022

Dec. 9, 2022

The function is called a lot, I believe something like this would improve its performance in general. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1756

1 5

[PATCH v5 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) Dec. 9, 2022

Dec. 9, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v5: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 12

[PATCH v4 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) Dec. 8, 2022

Dec. 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v4: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 9

[PATCH v3 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) Dec. 8, 2022

Dec. 8, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v3: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH 0/1] MR1754: wsdapi: Annotate duplicate_(string|name) with __WINE_MALLOC.
by Alex Henrie (＠alexhenrie) Dec. 8, 2022

Dec. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1754

2 1

[PATCH 0/1] MR1753: wintrust: Annotate WINTRUST_Alloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) Dec. 8, 2022

Dec. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1753

2 1

Re: [PATCH v13 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) Dec. 8, 2022

Dec. 8, 2022

Sorry for replying a bit late, I'm still working on this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1268#note_19265

1 0

[PATCH v2 0/2] MR1746: Draft: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) Dec. 8, 2022

Dec. 8, 2022

-- v2: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. setupapi: Handle NULL in string allocation functions and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

2 3

[PATCH v8 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) Dec. 8, 2022

Dec. 8, 2022

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v8: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. shell32: Fix error handling in SHBindToParent. shell32/tests: Test SHBindToParent last parameter behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 5

[PATCH v5 0/2] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc
by Brendan Shanks (＠bshanks) Dec. 8, 2022

Dec. 8, 2022

-- v5: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _aligned_malloc functions. include/msvcrt: Add __WINE_(DEALLOC|MALLOC) attributes to _strdup and _wcsdup. https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

3 3