- Wine-GitLab - list.winehq.org

[PATCH 0/1] MR1028: nsi: Use the correct members for the error and discard counts.
by Huw Davies (＠huw) Oct. 11, 2022

Oct. 11, 2022

This is instead of !984. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1028

3 2

[PATCH v2 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer.
by Gabriel Ivăncescu Oct. 11, 2022

Oct. 11, 2022

-- v2: shell32: Handle drive letters properly when parsing MyComputer. shell32/tests: Test drive letters parsing for My Computer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

2 3

[PATCH v3 0/6] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) Oct. 11, 2022

Oct. 11, 2022

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- v3: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx(). wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent. wow64: Support MEM_ADDRESS_REQUIREMENTS in wow64_NtAllocateVirtualMemoryEx(). ntdll/tests: Add tests for memory address requiements. https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

3 11

[PATCH 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer.
by Gabriel Ivăncescu Oct. 11, 2022

Oct. 11, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

2 3

[PATCH v3 0/6] MR965: jscript/mshtml: Enumeration fixes.
by Gabriel Ivăncescu Oct. 11, 2022

Oct. 11, 2022

-- v3: mshtml: Enumerate document elements with name. mshtml: Split the lookup for an element with name into a separate helper. mshtml: Do not enumerate internal dynamic props. mshtml: Fix enumerating first custom prop after builtins. jscript: Refill the props at end of enumeration in html mode and retry. jscript: Fill the builtin props for enumeration on prototypes as well. https://gitlab.winehq.org/wine/wine/-/merge_requests/965

3 13

[PATCH v2 0/4] MR980: wintrust: Support WSS_GET_SECONDARY_SIG_COUNT in singature settings in WinVerifyTrust().
by Paul Gofman (＠gofman) Oct. 11, 2022

Oct. 11, 2022

Nvidia's Streamline library depends on that (https://github.com/NVIDIAGameWorks/Streamline/) -- v2: wintrust: Support WSS_GET_SECONDARY_SIG_COUNT in Softpub provider. wintrust: Load secondary signatures in SoftpubLoadSignature(). https://gitlab.winehq.org/wine/wine/-/merge_requests/980

3 5

Re: [PATCH v6 0/1] MR23: shell32: Sanitize Program Manager icon and group names
by Huw Davies (＠huw) Oct. 10, 2022

Oct. 10, 2022

Huw Davies (@huw) commented about dlls/shell32/dde.c: > } > if (argc >= 2) > { > - len = lstrlenW(last_group) + 1 + lstrlenW(argv[1]) + 5; > - name = heap_alloc(len * sizeof(*name)); > - swprintf( name, len, L"%s/%s.lnk", last_group, argv[1] ); > + name = combine_path(last_group, argv[1], L".lnk", TRUE); > } > else > { > - const WCHAR *filename = PathFindFileNameW(argv[0]); > - len = PathFindExtensionW(filename) - filename; > - name = heap_alloc((lstrlenW(last_group) + 1 + len + 5) * sizeof(*name)); > - swprintf( name, lstrlenW(last_group) + 1 + len + 5, L"%s/%.*s.lnk", last_group, len, filename ); > + WCHAR *filename = PathFindFileNameW(argv[0]); > + *PathFindExtensionW(filename) = '\0'; You're modifying `argv[0]` here which is pretty ugly. More broadly, you might find things easier if you add the `combine_path()` helper without the `sanitize` param in a first commit and then turn on the sanitizing in a second commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/23#note_10235

1 0

Re: [PATCH v2 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Kevin Puetz (＠puetzk) Oct. 10, 2022

Oct. 10, 2022

On Mon Oct 10 21:33:57 2022 +0000, Huw Davies wrote: > This looks correct to me, however afaict, Windows also sets > `stubMessage.pRpcChannelBuffer` to `NULL` when it releases it, so it > would be good to have a test for that, as well as it added to the implementation. > It would be clearer to split this into two commits: the first commit > would contain just the tests with appropriate `todo_wine`s. A second > commit would then add the implementation changes and remove the > `todo_wine`s. That way it's clear what the new changes are fixing. Ok, easy to do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957#note_10232

1 0

[PATCH v5 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by Joel Holdsworth (＠jhol) Oct. 10, 2022

Oct. 10, 2022

Based on a patch by Qian Hong. -- v5: ntdll: Improve stub of NtQueryEaFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/745

4 7

Re: [PATCH v2 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Huw Davies (＠huw) Oct. 10, 2022

Oct. 10, 2022

Huw Davies (@huw) commented about dlls/rpcrt4/tests/cstub.c: > + /* stubMessage doesn't add its own refcounts on proxy_if1 or proxy_buffer, > + * so it's possible these are freed out from under it. > + * E.g. an event sink might unadvise upon receiving the event it was waiting for; > + * this unadvise could be reentrant to Invoke because SendReceive pumps STA messages. > + * The source would then erase that conection point entry and Release the proxy. */ > + IRpcProxyBuffer_Disconnect(proxy_buffer); > + ok(test_chanbuf.RefCount == 1, "got %ld\n", test_chanbuf.RefCount); > + IRpcProxyBuffer_Release(proxy_buffer); > + refs = IUnknown_Release(proxy_if1); > + ok(refs == 0, "got %ld\n", refs); > + ok(test_chanbuf.RefCount == 1, "got %ld\n", test_chanbuf.RefCount); > + > + /* NdrProxyFreeBuffer must not dereference the the now-freed proxy_if1, > + * yet should still free the remaining reference on test_chanbuf */ > + NdrProxyFreeBuffer(proxy_if1, &stubMessage); > + ok(test_chanbuf.RefCount == 0, "got %ld\n", test_chanbuf.RefCount); This looks correct to me, however afaict, Windows also sets `stubMessage.pRpcChannelBuffer` to `NULL` when it releases it, so it would be good to have a test for that, as well as it added to the implementation. It would be clearer to split this into two commits: the first commit would contain just the tests with appropriate `todo_wine`s. A second commit would then add the implementation changes and remove the `todo_wine`s. That way it's clear what the new changes are fixing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957#note_10221

1 0