- Wine-GitLab - list.winehq.org

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Gabriel Ivăncescu Sept. 16, 2022

Sept. 16, 2022

On Fri Sep 16 15:03:29 2022 +0000, Etaash Mathamsetty wrote: > lol now another issue popped up, the rebase worked properly earlier > this gitlab is really weird, litterally nothing has worked correctly for me It worked properly earlier likely because there were no conflicts. Use git locally as normal instead of the web interface to do it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8699

1 0

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) Sept. 16, 2022

Sept. 16, 2022

On Fri Sep 16 15:28:23 2022 +0000, Huw Davies wrote: > My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has > `REG_PROCESS_PRIVATE` as 0x20, which is presumably what > `REG_PROCESS_APPKEY` gets mapped to. > If the tests aren't going to work on Win 7, then skip them as soon as > the first call returns `STATUS_INVALID_PARAMETER_6`. > Since you've found that the key return is only available for an app key, > then I don't think it makes sense to split this MR up as I'd previously > suggested. That means we need the filename logic back in. > A couple of notes on that: When passing strings to the server, we > typically don't nul-terminate them and pass the length instead. Also, > there is logic there already that copes with loading and saving branches > i.e. the `save_branch_info` stuff. Have you looked into adapting that? Oh interesting, where do you find those headers in the windwos sdk? I've tried to find something like that but I'm always afraid of breaking the clean room guidelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8698

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 16, 2022

Sept. 16, 2022

On Thu Sep 15 22:27:44 2022 +0000, Bernhard Kölbl wrote: > > Rebase failed: Rebase locally, resolve all conflicts, then push the > branch. Try again. lol now another issue popped up, the rebase worked properly earlier this gitlab is really weird, litterally nothing has worked correctly for me -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8695

1 0

[PATCH 0/1] MR875: glu32: Fix GCC 12.2 warnings.
by eric pouech (＠epo) Sept. 16, 2022

Sept. 16, 2022

GCC complains about writing 4x4 floats into a pointer to a float. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/875

2 1

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Huw Davies (＠huw) Sept. 16, 2022

Sept. 16, 2022

My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has `REG_PROCESS_PRIVATE` as 0x20, which is presumably what `REG_PROCESS_APPKEY` gets mapped to. If the tests aren't going to work on Win 7, then skip them as soon as the first call returns `STATUS_INVALID_PARAMETER_6`. Since you've found that the key return is only available for an app key, then I don't think it makes sense to split this MR up as I'd previously suggested. That means we need the filename logic back in. A couple of notes on that: When passing strings to the server, we typically don't nul-terminate them and pass the length instead. Also, there is logic there already that copes with loading and saving branches i.e. the `save_branch_info` stuff. Have you looked into adapting that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8694

1 0

[PATCH 0/6] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu Sept. 16, 2022

Sept. 16, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/856

2 17

[PATCH 0/1] MR837: wininet: Clear cached credentials after the first failed attempt.
by Alistair Leslie-Hughes (＠alesliehughes) Sept. 16, 2022

Sept. 16, 2022

Windows when using cached credentials will use them on the first challenge, if then a second 403 (ACCESS_DENIED) is received, the user is prompted again but this time with the password and save checkbox cleared. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/837

3 2

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) Sept. 16, 2022

Sept. 16, 2022

On Fri Sep 16 01:12:18 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=123494 > Your paranoid android. > === debian11 (32 bit report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (32 bit zh:CN report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (32 bit WoW report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > === debian11 (64 bit WoW report) === > ntdll: > reg.c:2348: Test succeeded inside todo block: got 0xc00000f5 > ``` This test report is from the other force push, now I fixed it with the last push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8684

1 0

[PATCH v7 0/9] MR813: winecoreaudio: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) Sept. 16, 2022

Sept. 16, 2022

-- v7: winecoreaudio: Switch to mmdevapi's unixlib.h. winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's. winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's. winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's. winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate winecoreaudio's additions in unixlib.h. winecoreaudio: Switch to string as device identifier, to match other drivers. winecoreaudio: Fix RegEnumKeyExW() call passing wrong unit for the buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/813

3 11

[PATCH 0/1] MR873: xmllite/writer: Enable some more tests for WriteNode().
by Nikolay Sivov (＠nsivov) Sept. 16, 2022

Sept. 16, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/873

2 1