- Wine-GitLab - list.winehq.org

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 23, 2022

Aug. 23, 2022

On Tue Aug 23 01:19:06 2022 +0000, Davide Beatrici wrote: > The example at https://docs.microsoft.com/en-us/windows/win32/learnwin32/example--the-open…: > ``` > x86_64-w64-mingw32-g++ open_dialog_box.cpp -municode -lole32 -luuid -o open_dialog_box > ``` > ![](/uploads/4e8c5b8ee3df0c9242638683c9690d6b/image.png) > ![](/uploads/f8bfa92da7e09844e7f5a1444299a508/image.png) > I confirm pressing Enter when the address bar is focused does not change > the location. Thanks @davidebeatrici, I'll try to fix that, for my next commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6705

1 0

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Davide Beatrici (＠davidebeatrici) Aug. 23, 2022

Aug. 23, 2022

On Tue Aug 23 01:00:40 2022 +0000, Ben Cottrell wrote: > Common item dialog The example at https://docs.microsoft.com/en-us/windows/win32/learnwin32/example--the-open…: ``` x86_64-w64-mingw32-g++ open_dialog_box.cpp -municode -lole32 -luuid -o open_dialog_box ``` ![](/uploads/4e8c5b8ee3df0c9242638683c9690d6b/image.png) ![](/uploads/f8bfa92da7e09844e7f5a1444299a508/image.png) I confirm pressing Enter when the address bar is focused does not change the location. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6704

1 0

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 23, 2022

Aug. 23, 2022

On Tue Aug 23 00:37:23 2022 +0000, Davide Beatrici wrote: > Would you like me to perform specific tests? > The screenshots I sent are of `explorer`. Common item dialog -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6703

1 0

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Davide Beatrici (＠davidebeatrici) Aug. 23, 2022

Aug. 23, 2022

On Tue Aug 23 00:10:52 2022 +0000, Davide Beatrici wrote: > ![](/uploads/25abbb18e0c5980412b0d6a1455140f1/image.png) Would you like me to perform specific tests? The screenshots I sent are of `explorer`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6702

1 0

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Davide Beatrici (＠davidebeatrici) Aug. 23, 2022

Aug. 23, 2022

On Tue Aug 23 00:07:16 2022 +0000, Ben Cottrell wrote: > Can you please test out my changes for the next commit on your machine? ![](/uploads/25abbb18e0c5980412b0d6a1455140f1/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6701

1 0

[PATCH v8 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 23, 2022

Aug. 23, 2022

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v8: comdlg32: Add missing controls to the common item dialog, only affecting the implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 4

Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 23, 2022

Aug. 23, 2022

On Mon Aug 22 23:01:04 2022 +0000, Davide Beatrici wrote: > Yes, I compiled and ran your branch on my machine. Can you please test out my changes for the next commit on your machine? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6698

1 0

Re: [PATCH v7 0/1] MR672: comdlg32: Common item dialog fixes
by Davide Beatrici (＠davidebeatrici) Aug. 22, 2022

Aug. 22, 2022

On Mon Aug 22 07:58:24 2022 +0000, Ben Cottrell wrote: > Is that running on your machine? I'm testing in a Docker container. Yes, I compiled and ran your branch on my machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6689

1 0

[PATCH v2 0/3] MR693: user32: Fix passing resource IDs to bitmap and icon static control
by Jacek Caban (＠jacek) Aug. 22, 2022

Aug. 22, 2022

-- v2: user32: Pass resource ID as a string in DIALOG_CreateControls32. user32: Support passing bitmap and icon resource ID as a string when creating static conctrol. user32: Support resource ID strings in CREATESTRUCT Unicode conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/693

3 6

[PATCH 0/8] MR9: vkd3d-shader/hlsl: Properly check argument counts and offset dimensions in texture methods.
by Francisco Casas (＠fcasas) Aug. 22, 2022

Aug. 22, 2022

The objective of this patch series is to converge to the correct argument count checks and offset parameter dimensions when parsing the Load, Sample, SampleLevel, Gather (and variants) methods, for the different texture types. I made the following table to summarize the expected arguments and their dimensions: ![resource_methods_dims](/uploads/43511fe82e934c2542f6152f9134cb0e/resource_methods_dims.png) Getting these required some extensive trial-and-error, because: - Official documentation about the methods is spread in different pages and in a somewhat inconsistent manner. - Automatic vector truncation, scalar broadcasting, and type conversion, make shaders that pass inexact types compile. - clamp and status arguments (for tiled resources) are not present in fxc 9, and yet, they are part of ps_5_0 and vs_5_0. - Some methods (Load() in particular) require the mipmap level as part of the location parameter (except for Multi-Sampled textures), while other don't. For implementing new methods I recommend passing an invalid parameter count to them in fxc 10, so that it lists available overloads. And to do this for each texture type. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/9

5 16