- Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/1] MR672: comdlg32: Common item dialog fixes
by Davide Beatrici (＠davidebeatrici) Aug. 22, 2022

Aug. 22, 2022

On Sun Aug 21 23:11:44 2022 +0000, Ben Cottrell wrote: > After making the changes, the icons for explorer and the common item > dialog are missing, possibly due to out of bounds memory reads, but I > don't know the cause, especially as adding trace+comctl32 to the > WINEDEBUG environment variable doesn't produce useful messages. > ![Screenshot_from_2022-08-22_11-04-57](/uploads/6c51e3d86403fd52a71e765cfecd075d/Screenshot_from_2022-08-22_11-04-57.png) > ![Screenshot_from_2022-08-22_11-05-28](/uploads/4682a15c445f2d78b5a9b5b2c4c90e75/Screenshot_from_2022-08-22_11-05-28.png) I replaced `button[2].iBitmap = HIST_UP` with `button[2].iBitmap = HIST_VIEWTREE + 1`, this is the result: ![](/uploads/6af132b1ea3c302eaeb1cc5a67945b12/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6644

1 0

Re: [PATCH v7 0/1] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 21, 2022

Aug. 21, 2022

On Sun Aug 21 21:20:05 2022 +0000, Ben Cottrell wrote: > OK, I'll remove the define and change the position of the image, so that > it's HIST_VIEWTREE + 1 in my next commit. I'm sorry for making a basic error. After making the changes, the icons for explorer and the common item dialog are missing, possibly due to out of bounds memory reads, but I don't know the cause, especially as adding trace+comctl32 to the WINEDEBUG environment variable doesn't produce useful messages. ![Screenshot_from_2022-08-22_11-04-57](/uploads/6c51e3d86403fd52a71e765cfecd075d/Screenshot_from_2022-08-22_11-04-57.png) ![Screenshot_from_2022-08-22_11-05-28](/uploads/4682a15c445f2d78b5a9b5b2c4c90e75/Screenshot_from_2022-08-22_11-05-28.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6639

1 0

Re: [PATCH v7 0/1] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 21, 2022

Aug. 21, 2022

On Sun Aug 21 19:31:58 2022 +0000, Alexandre Julliard wrote: > These are Windows API defines, you can't change them. OK, I'll remove the define and change the position of the image, so that it's HIST_VIEWTREE + 1 in my next commit. I'm sorry for making a basic error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6637

1 0

Re: [PATCH v7 0/1] MR672: comdlg32: Common item dialog fixes
by Alexandre Julliard (＠julliard) Aug. 21, 2022

Aug. 21, 2022

Alexandre Julliard (@julliard) commented about include/commctrl.h: > > #define HIST_BACK 0 > #define HIST_FORWARD 1 > -#define HIST_FAVORITES 2 > -#define HIST_ADDTOFAVORITES 3 > -#define HIST_VIEWTREE 4 > +#define HIST_UP 2 > +#define HIST_FAVORITES 3 > +#define HIST_ADDTOFAVORITES 4 > +#define HIST_VIEWTREE 5 > These are Windows API defines, you can't change them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6636

1 0

[PATCH 0/1] MR691: ntoskrnl: implement IoCreateFileEx
by Etaash Mathamsetty (＠etaash.mathamsetty) Aug. 21, 2022

Aug. 21, 2022

required for vgk.sys (vanguard anti-cheat) fixes bug #51939 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/691

2 1

[PATCH 0/1] MR690: NTOSKRNL.EXE: Implement KeAreAllApcsDisabled
by Etaash Mathamsetty (＠etaash.mathamsetty) Aug. 21, 2022

Aug. 21, 2022

required for vgk.sys (vanguard anti-cheat) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/690

2 2

[PATCH v2 0/5] MR665: win32u: Tweak reading / writing of DEVMODEW into the registry.
by Rémi Bernon Aug. 21, 2022

Aug. 21, 2022

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/576, for which I'll then add modes sorting, and move support for stretched / interlaced modes from winemac to win32u. -- v2: win32u: Only read/write valid mode fields from/to the registry. win32u: Use current mode position if desired mode doesn't specify it. win32u: Always copy devmode in validate_display_settings. win32u: Read registry or current mode when validation needs it. win32u: Do not keep display modes driver extra in the registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/665

2 6

[PATCH v2 0/10] MR658: winepulse: Switch to mmdevapi's unixlib.h
by Davide Beatrici (＠davidebeatrici) Aug. 21, 2022

Aug. 21, 2022

Follow-up to !600. -- v2: winepulse: Switch to mmdevapi's unixlib.h winepulse: Adapt "get_prop_value_params" struct to mmdevapi's winepulse: Adapt "is_started_params" struct to mmdevapi's winepulse: Adapt "get_device_period_params" struct to mmdevapi's winepulse: Adapt "get_mix_format_params" struct to mmdevapi's winepulse: Adapt "get_capture_buffer_params" struct to mmdevapi's winepulse: Adapt "release_render_buffer_params" struct to mmdevapi's winepulse: Adapt "release_stream_params" struct to mmdevapi's winepulse: Adapt "create_stream_params" struct to mmdevapi's winepulse: Adapt "endpoint" struct to mmdevapi's https://gitlab.winehq.org/wine/wine/-/merge_requests/658

2 12

[PATCH 0/1] MR687: winealsa: Fix WoW64 failure when calling get_position()
by Davide Beatrici (＠davidebeatrici) Aug. 21, 2022

Aug. 21, 2022

Bug introduced in !600. ``` 00dc:trace:alsa:AudioClient_GetService (00A53680)->({cd63314f-3fba-4a1b-812c-ef96358728e7}, 0022FCB0) 00dc:trace:alsa:AudioClient_AddRef (00A53680) Refcount now 2 00dc:trace:alsa:AudioClock_GetFrequency (00A53680)->(0022FCC8) render.c:1056: Clock Frequency 384000 00dc:trace:alsa:AudioClock_GetPosition (00A53680)->(00000000, 00000000) 00dc:trace:alsa:AudioClock_GetPosition (00A53680)->(0022FCD0, 0022FCD8) 00dc:trace:alsa:alsa_get_position frames written: 0, held: 0, state: 0x2, position: 0 render.c:1071: Test failed: GetPosition failed: 00423930 render.c:1072: Test failed: GetPosition returned non-zero pos before being started render.c:1073: Test failed: GetPosition returned zero pcpos 00dc:trace:alsa:AudioClient_GetService (00A53680)->({f294acfc-3146-4483-a7bf-addca7c260e2}, 0022FCB4) 00dc:trace:alsa:AudioClient_AddRef (00A53680) Refcount now 3 00dc:trace:alsa:AudioRenderClient_GetBuffer (00A53680)->(24001, 0022FCC0) ``` And the test hangs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/687

2 1

[PATCH 0/3] MR546: mfplat: Implement and use IMF2DBuffer2::Copy2DTo().
by Giovanni Mascellani (＠giomasce) Aug. 20, 2022

Aug. 20, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/546

4 7