- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR648: winspool.drv: Fix DocumentProperties function when printer name and driver name differs - approved
by Alexandre Julliard (＠julliard) Aug. 16, 2022

Aug. 16, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/648

1 0

[PATCH 0/1] MR656: jscript: Implement fdexNameCaseInsensitive flag handling.
by Gabriel Ivăncescu Aug. 16, 2022

Aug. 16, 2022

Despite common sense, native doesn't seem to look for exact match first; it simply case-insensitively compares the props and returns as soon as it finds one. This is also reliant on implementation details in case the object has multiple props with same case-insensitive names, e.g. an object having `Foo` prop, with `foo` prop on its prototype, can still find `Foo` even if you look up `foo` instead (which matches exactly on the prototype). Which is not always reliable, sometimes it finds the prototype first. See the following diff to illustrate possible behavior on native (which is what I get). Note that especially for jscript, the behavior makes no sense logically; first it picks 'Foo', despite 'foo' being available on the prototype (i.e. exact match). You might think it just looks up on props first, and prototype later, but the second ok() added shows that it finds the prototype's prop first, instead! ```diff diff --git a/dlls/jscript/tests/jscript.c b/dlls/jscript/tests/jscript.c index 03774da..2428363 100644 --- a/dlls/jscript/tests/jscript.c +++ b/dlls/jscript/tests/jscript.c @@ -999,6 +999,7 @@ static void test_case_sens(void) /* Native picks one "arbitrarily" here, depending how it's laid out, so can't compare exact id */ hr = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive, &id2); ok(hr == S_OK, "GetDispID failed: %08lx\n", hr); + ok(id != id2, "id == id2\n"); hr = IDispatchEx_GetIDsOfNames(disp, &IID_NULL, &bstr, 1, 0, &id2); ok(hr == S_OK, "GetIDsOfNames failed: %08lx\n", hr); @@ -1031,6 +1032,7 @@ static void test_case_sens(void) hr = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive | fdexNameEnsure, &id2); ok(hr == S_OK, "GetDispID failed: %08lx\n", hr); + ok(id == id2, "id != id2\n"); SysFreeString(bstr); IDispatchEx_Release(disp); diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c index 14e3a14..563b87a 100644 --- a/dlls/mshtml/tests/script.c +++ b/dlls/mshtml/tests/script.c @@ -241,6 +241,7 @@ static void test_script_vars(unsigned argc, VARIANTARG *argv) /* Native picks one "arbitrarily" here, depending how it's laid out, so can't compare exact id */ hres = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive, &id2); ok(hres == S_OK, "GetDispID failed: %08lx\n", hres); + ok(id != id2, "id == id2\n"); hres = IDispatchEx_GetIDsOfNames(disp, &IID_NULL, &bstr, 1, 0, &id2); ok(hres == S_OK, "GetIDsOfNames failed: %08lx\n", hres); @@ -273,6 +274,7 @@ static void test_script_vars(unsigned argc, VARIANTARG *argv) hres = IDispatchEx_GetDispID(disp, bstr, fdexNameCaseInsensitive | fdexNameEnsure, &id2); ok(hres == S_OK, "GetDispID failed: %08lx\n", hres); + ok(id != id2, "id == id2\n"); SysFreeString(bstr); IDispatchEx_Release(disp); ``` Strangely, mshtml's jscript still finds the prop on the object the second time, but that could be to different underlying implementation. I don't think it's necessary to replicate this quirk. The main point of this case insensitive handling is that it will be needed later when IE9+ modes use jscript proxy objects for the mshtml objects, because those default to case-insensitive search in GetIDsOfNames, likely to preserve backwards compatibility with pre-IE9 modes. It's a weird quirk, I know, but we have tests for that, which would otherwise break when proxies get added. I'll also add more tests around it later, to prove this, of course, that it also applies to jscript props (e.g. hasOwnProperty on the prototype is still looked case-insensitively if GetIDsOfNames is used). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/656

3 7

[PATCH 0/5] MR652: qasf: More ASF Reader filter implementation.
by Rémi Bernon Aug. 16, 2022

Aug. 16, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/652

2 6

[PATCH v2 0/5] MR627: comctl32/tests: Add IME tests for edit control.
by Zhiyi Zhang (＠zhiyi) Aug. 16, 2022

Aug. 16, 2022

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v2: comctl32/edit: Handle IME composition result string only when EIMES_GETCOMPSTRATONCE is set. comctl32/edit: Let DefWindowProcW() handle WM_IME_CHAR. comctl32/edit: Implement EM_GETIMESTATUS. comctl32/edit: Implement EM_SETIMESTATUS. comctl32/tests: Add IME tests for edit control. https://gitlab.winehq.org/wine/wine/-/merge_requests/627

4 11

[PATCH 0/5] MR649: wined3d: Managed texture patches.
by Zebediah Figura (＠zfigura) Aug. 16, 2022

Aug. 16, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/649

4 7

[PATCH 0/5] MR654: wow64win: Implement remaining user callbacks.
by Jacek Caban (＠jacek) Aug. 16, 2022

Aug. 16, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/654

3 6

[PATCH 0/2] MR650: ddraw: Restore full complex attachment chain in ddraw_surface7_Restore().
by Paul Gofman (＠gofman) Aug. 16, 2022

Aug. 16, 2022

The added inner loop over attachment chain in the second patch minds zero attachment array only. That is because the only case when non-zero complex_array elements are used is the root of the cube texture. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/650

6 8

Re: [PATCH v7 0/3] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi - approved
by Huw Davies (＠huw) Aug. 16, 2022

Aug. 16, 2022

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/600

1 0

[PATCH 0/1] MR655: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Fan WenJie (＠fanwenjie) Aug. 16, 2022

Aug. 16, 2022

function call from windows dll to unix function should use `__wine_unix_call` instead of callback function pointer. remove callback struct unix_funcs and add wrapper function of `unixlib_entry_t` type. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/655

2 1

[PATCH v2 0/3] MR633: d3d11: Implement D3D11_FEATURE_FORMAT_SUPPORT.
by Zebediah Figura (＠zfigura) Aug. 16, 2022

Aug. 16, 2022

-- v2: d3d11: Implement D3D11_FEATURE_FORMAT_SUPPORT. d3d11: Always return E_FAIL for formats which have no support flags. d3d11/tests: Use winetest_push_context() to print explicit feature levels. https://gitlab.winehq.org/wine/wine/-/merge_requests/633

3 4