- Wine-GitLab - list.winehq.org

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Vibhav Pant (＠vibhavp) Aug. 31, 2025

Aug. 31, 2025

On Sun Aug 31 16:55:44 2025 +0000, Bernhard Übelacker wrote: > Thanks for looking into it. By replacing the body of > property_value_statics_CreateString with above version (and renaming the > parameter value to value_str) ASan stays silent and the test succeeds here. Thanks, I'll create an MR for the fix them (: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114367

1 0

[PATCH 0/1] MR8863: ws2_32: Add support for AF_UNIX sockets.
by Ralf Habacker (＠rhabacker) Aug. 31, 2025

Aug. 31, 2025

See !7650 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8863

2 1

[PATCH v11 0/13] MR8829: windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v11: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v10 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v10: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v9 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v9: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). windows.media.playback.mediaplayer: Add IMediaPlayer2 stub. include: Add IMediaPlayer2 definition. windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker Aug. 31, 2025

Aug. 31, 2025

On Sun Aug 31 11:46:59 2025 +0000, Vibhav Pant wrote: > Yes, I think `IPropertyValueStatics::CreateString` should use > `WindowsDuplicateString`. Could you replace the code > [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16… > with > ```c > { > HSTRING value; > HRESULT hr; > TRACE("iface %p, value %s, property_value %p.\n", iface, > debugstr_hstring(value_str), property_value); > *property_value = NULL; > if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr; > create_primitive_property_value_iref(PropertyType_String, > irefs.hstring_iface.lpVtbl, iref_hstring_vtbl); > } > ``` > and see if it resolves the issue? I'll create an MR in that case. Thanks for looking into it. By replacing the body of property_value_statics_CreateString with above version (and renaming the parameter value to value_str) ASan stays silent and the test succeeds here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114358

1 0

[PATCH v8 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v8: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v7 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v7: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v6 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) Aug. 31, 2025

Aug. 31, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v6: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). windows.media.playback.mediaplayer: Add IMediaPlayer2 stub. include: Add IMediaPlayer2 definition. windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current(). windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance(). windows.media.playback.backgroundmediaplayer: Add IBackgroundMediaPlayerStatics stub. include: Add IMediaPlayer definition. windows.media.playback.backgroundmediaplayer: Add stub dll. include: Add windows.media.playback.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH 0/2] MR8861: shell32: Accept CSIDL values in SHBrowseForFolderW().
by Attila Fidan (＠atticf) Aug. 31, 2025

Aug. 31, 2025

This fixes an access violation when clicking the button to browse for an installation directory in some installers using the BURIKO (BGI/Ethornell) engine. The affected applications call `SHBrowseForFolderA(&bi)` with `bi.pidlRoot` being 0x11, which causes wine to dereference 0x11 inside InitializeTreeView. On native, this opens the treeview from My Computer. 0x11 is the CSIDL value for My Computer, and passing any pidlRoot from 0 to 2^16 will not crash on native like resource IDs. If an invalid folder value is used then native returns 0 without showing a window. If I delete the My Pictures folder then use `CSIDL_MYPICTURES`, the folder gets recreated. None of this works if `BIF_NEWDIALOGSTYLE` is used, native crashes with access violation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8861

2 3