- Wine-GitLab - list.winehq.org

[PATCH v8 0/7] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v8: Resource pending for “Open with” on file association https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 7

[PATCH 0/1] MR8862: mmdevapi/tests: Rewrite capturing tests.
by Giovanni Mascellani (＠giomasce) Aug. 31, 2025

Aug. 31, 2025

I began working on this to address some flakyness (see e.g. https://gitlab.winehq.org/wine/wine/-/jobs/183916) and eventually I ended up rewriting `test_capture()` because the previous implementation looked somewhat incomplete. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8862

2 1

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Vibhav Pant (＠vibhavp) Aug. 31, 2025

Aug. 31, 2025

On Sun Aug 31 09:30:40 2025 +0000, Bernhard Übelacker wrote: > @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up > with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is > `str` supposed to be a new allocation after line 948? > ``` > ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: > heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp > 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 > READ of size 8 at 0x7f6707c03ba0 thread T0 > #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 > #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 > 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) > freed by thread T0 here: > #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 > #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 > #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 > previously allocated by thread T0 here: > #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 > #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 > #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 > #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 > ``` > [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… Yes, I think `IPropertyValueStatics::CreateString` should use `WindowsDuplicateString`. Could you replace the code [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16… with ```c { HSTRING value; HRESULT hr; TRACE("iface %p, value %s, property_value %p.\n", iface, debugstr_hstring(value_str), property_value); *property_value = NULL; if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr; create_primitive_property_value_iref(PropertyType_String, irefs.hstring_iface.lpVtbl, iref_hstring_vtbl); } ``` and see if it resolves the issue? I'll create an MR in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114348

1 0

[PATCH 0/1] MR8849: cmd: Treat COPY from CON or CON: as ASCII operation.
by Joe Souza (＠JoeS209) Aug. 31, 2025

Aug. 31, 2025

This should fix the remaining issues in bug #16214. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8849

3 8

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker Aug. 31, 2025

Aug. 31, 2025

Bernhard Übelacker (@bernhardu) commented about dlls/vccorlib140/tests/vccorlib.c: > + obj = pCreateValue(TYPECODE_STRING, &str); > + WindowsDeleteString(str); > + ok(obj != NULL || broken(obj == NULL), "got obj %p\n", obj); /* Returns NULL on i386 Windows 10. */ > + if (obj) > + { > + type = PropertyType_Empty; > + hr = IPropertyValue_get_Type(obj, &type); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(type == PropertyType_String, "got type %d\n", type); > + str = NULL; > + hr = IPropertyValue_GetString(obj, &str); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(str != NULL, "got str %p\n", str); > + buf = WindowsGetStringRawBuffer(str, NULL); > + ok(buf && !wcscmp(buf, L"foo"), "got buf %s\n", debugstr_w(buf)); > + WindowsDeleteString(str); @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is `str` supposed to be a new allocation after line 948? ``` ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 READ of size 8 at 0x7f6707c03ba0 thread T0 #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) freed by thread T0 here: #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 previously allocated by thread T0 here: #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 ``` [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114345

1 0

[PATCH v7 0/6] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v7: Creating Makefile https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 6

[PATCH v5 0/4] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v5: Creating winemenumgr https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 4

[PATCH v3 0/3] MR8857: Update fr.po
by Allan Rémy Aug. 31, 2025

Aug. 31, 2025

-- v3: Ajouter un nouveau répertoire https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 3

[PATCH v2 0/2] MR8857: Update fr.po
by Allan Rémy Aug. 30, 2025

Aug. 30, 2025

-- v2: Modifier fr.po https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

1 2

[PATCH 0/1] MR8857: Update fr.po
by Allan Rémy Aug. 30, 2025

Aug. 30, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

3 9