- Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR10318: Draft: vbscript: Allow End If on the same line as the preceding statement.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Use BodyStatements instead of StatementsNl_opt for If, ElseIf, and Else blocks so the last statement before End If does not require a trailing newline, matching native behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55196 -- v2: vbscript/tests: Add tests for trailing End If in Else and ElseIf blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10318

2 2

Re: [PATCH v3 0/1] MR10293: Fix crashes when for_ctrl->set is empty
by eric pouech (＠epo) March 13, 2026

March 13, 2026

two comments on on-going work (thanks for taking care of it): * I believe it's cleaner to dup the empty string in node_builder_parse (that would save a reallocation on every other set) * it's possible you cannot write tests as the crash happens only a) when run from a batch file, b) when echo mode in ON (and most of the tests are run with echo OFF) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10293#note_132199

1 0

[PATCH v7 0/1] MR10302: vbscript: Allow Const to be used before its declaration.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

Pre-collect all Const declarations by walking the statement tree before compiling, matching native behavior where constants are visible throughout their enclosing scope. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56931 -- v7: vbscript: Allow Const to be used before its declaration. https://gitlab.winehq.org/wine/wine/-/merge_requests/10302

2 1

Re: [PATCH v4 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

On Fri Mar 13 12:56:24 2026 +0000, Francis De Brabandere wrote: > removed and rebased -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10310#note_132187

1 0

Re: [PATCH v3 0/1] MR10310: vbscript: Allow empty Else blocks in If statements.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

On Fri Mar 13 12:56:13 2026 +0000, Francis De Brabandere wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/10310/diffs?diff_id=250773&start_sha=347d8bf1d7b7ca8470ab15cc688da06156aa980d#18a8771bf91222ebfc4599f53729c95217a5ab51_2295_2295) removed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10310#note_132184

1 0

[PATCH 0/1] MR10328: msxml3/sax: Do not attempt to add default attributes for definitions without values.
by Nikolay Sivov (＠nsivov) March 13, 2026

March 13, 2026

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10328

2 1

Re: [PATCH v2 0/6] MR10299: libs: Import C++ standard libraries.
by Anton Baskanov (＠baskanov) March 13, 2026

March 13, 2026

On Fri Mar 13 11:04:36 2026 +0000, Jacek Caban wrote: > Could you please check whether this is fixed in a newer version? The > part that was merged was a minimal update to introduce the C++ > dependency, but here is an update to a more recent version: https://gitlab.winehq.org/jacek/wine/-/tree/fluidsynth No, it's still an issue in both 2.4.8 and 2.5.3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10299#note_132181

1 0

[PATCH 0/1] MR10326: mmdevapi: Avoid copying more memory than reserved in validate_fmt (ASan).
by Bernhard Übelacker March 13, 2026

March 13, 2026

The function `validate_fmt` may receive a pointer which got just reserved memory for the `WAVEFORMATEX`. Unfortunately the assignment `fmt2 = *fmt` always copies the size of `WAVEFORMATEXTENSIBLE`. CC: @giomasce (I currently cannot point to a specific commit, but this may also be related to the recent changes?) <details> <summary>ASan details [gitlab CI](https://gitlab.winehq.org/bernhardu/wine/-/jobs/237050#L2464)</summary> ``` ==qcap_test.exe==728==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x0022c122 at pc 0x785f4342 bp 0x0022bf4c sp 0x0022bb1c READ of size 40 at 0x0022c122 thread T0 #0 0x785f4341 in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x778957a5 in validate_fmt /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 #2 0x77896d1e in client_IsFormatSupported /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:881:10 #3 0x783e3624 in IAudioClient_IsFormatSupported /builds/bernhardu/wine/build64/include/audioclient.h:406:12 #4 0x783e5cd7 in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:454:10 #5 0x783e5928 in WINMM_GetSupportedFormats /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:504:14 #6 0x783e553b in WINMM_InitMMDevice /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:524:35 #7 0x783e4e9b in WINMM_EnumDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:610:17 #8 0x783d30e8 in WINMM_InitMMDevices /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:856:10 #9 0x7be4a996 in RtlRunOnceExecuteOnce /builds/bernhardu/wine/build64/../dlls/ntdll/sync.c:462:10 ... Address 0x0022c122 is located in stack of thread T0 at offset 34 in frame #0 0x783e5c0f in WINMM_TestFormat /builds/bernhardu/wine/build64/../dlls/winmm/waveform.c:442 This frame has 2 object(s): [16, 34) 'fmt' (line 443) <== Memory access at offset 34 overflows this variable [80, 84) 'junk' (line 443) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow /builds/bernhardu/wine/build64/../dlls/mmdevapi/client.c:363:33 in validate_fmt ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10326

1 2

Re: [PATCH v2 0/6] MR10299: libs: Import C++ standard libraries.
by Jacek Caban (＠jacek) March 13, 2026

March 13, 2026

On Fri Mar 13 08:31:10 2026 +0000, Anton Baskanov wrote: > Weirdly, I get a sudden volume increase of the drums in some MIDI files. > It wasn't like this before this patch. Haven't figured out what's going > on exactly. Could you please check whether this is fixed in a newer version? The part that was merged was a minimal update to introduce the C++ dependency, but here is an update to a more recent version: https://gitlab.winehq.org/jacek/wine/-/tree/fluidsynth -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10299#note_132178

1 0

[PATCH 0/1] MR10317: vbscript: Allow Not operator as operand of comparison expressions.
by Francis De Brabandere (＠francisdb) March 13, 2026

March 13, 2026

The Not operator was only reachable from the NotExpression grammar rule, which sat above EqualityExpression in the precedence chain. This meant expressions like "a <> Not b" caused a syntax error because the right-hand side of a comparison could not contain Not. Adding Not as a unary operator in SignExpression (alongside unary minus and plus) allows it to be used within comparison operands. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55093 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10317

3 2