- Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR10261: Fix toolbar wrapping issues
by Ivan Ivlev (＠iviv) March 13, 2026

March 13, 2026

This MR resolves two bugs with toolbar wrapping I have discovered. 1. Toolbar missing four buttons when app window is maximized (wrap should not appear at all in this case). 2. Last toolbar button disappears when window size (toolbar size) is slightly narrower then button right border. Reasons of this behavior: 1. Toolbar buttons have BTNS_AUTOSIZE style, toolbar width is set using CCS_NORESIZE and equals to widths of all autosized buttons combined. cx (button width) value in TOOLBAR_WrapToolbar is set from nButtonWidth, which contains widest button width. Since buttons in toolbar have different widths, TOOLBAR_WrapToolbar miscalculates total width, because actual buttons widths are less then nButtonWidth. This results in TOOLBAR_WrapToolbar setting TBSTATE_WRAP when it is not not needed, and since app does not paint second button row, wrapped buttons just disappear. 2. After I fixed first issue, I noticed, that last button disappears, when toolbar become narrower then its right border. Then, when toolbar right border approximately in the middle of disappeared button, wrap happens. In windows system, wrapping occurs immediately when toolbar becomes narrower. Found solutions: 1. I noticed, that TOOLBAR_LayoutToolbar calculates buttons rects differently, thats because it checks if button have BTNS_AUTOSIZE style and then calculate size. So i moved this BTNS_AUTOSIZE size calculation in separate function for it to then be used in TOOLBAR_LayoutToolbar and TOOLBAR_WrapToolbar to guarantee that cx values for specific button will be equal in both functions. 2. TOOLBAR_WrapToolbar function decides to wrap in case `if ((x + cx - (infoPtr->nButtonWidth - infoPtr->nBitmapWidth) / 2 > width).` This `(infoPtr->nButtonWidth - infoPtr->nBitmapWidth) / 2` turns out, makes this gap, where button right border (x + cx) exceed toolbar right border (width), but wrap wont appear. I did not found any reasons to make this half-button gap, so I just removed it and it solved this issue. The comment above says /\* The layout makes sure the bitmap is visible, but not the button. \*/, but it was introduced in 1999, when TOOLBAR_LayoutToolbar did not existed, and I think its irrelevant now, since layout calculates cx taking both bitmap and string into account. I wrote tests for both fixes: 1. Creates CCS_NORESIZE toolbar, then add BTNS_AUTOSIZE buttons of different widths one by one and checks if wrap happened. In normal case (in windows) wrap should only happen on fourth button, but without fix wrap happens on third. 2. Creates CCS_NORESIZE toolbar with 4 BTNS_AUTOSIZE buttons. Toolbar width at the creation is calculated beforehand and equals exactly buttons widths combined. Then test reduces toolbar width by 1 and checks if wrap happened, in normal case wrap happens, without the fix its not. -- v2: comctl32/toolbar.c: Wrap toolbar immediately after width exceeded comctl32/tests/toolbar.c: Test wrapping occurs immediately when needed https://gitlab.winehq.org/wine/wine/-/merge_requests/10261

2 4

Re: [PATCH v3 0/1] MR10265: Draft: winewayland: Implement support for min/max window size hints.
by Etaash Mathamsetty (＠etaash.mathamsetty) March 13, 2026

March 13, 2026

this still has a bug (when there is a scaling factor) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10265#note_132147

1 0

Re: [PATCH v6 0/2] MR9180: win32u: Fix deadlock caused by nested locking. - closed
by Zhao Yi (＠Zhaoyi) March 13, 2026

March 13, 2026

This merge request was closed by Zhao Yi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9180

1 0

[PATCH v4 0/2] MR10321: mfsrcsnk: Parse pixel aspect ratio from the avcC atom.
by Yuxuan Shui (＠yshui) March 12, 2026

March 12, 2026

More specifically the SPS bytes in the avcC atom. Note this only fixes the problem for winedmo but not gstreamer. This is because gstreamer 1) does not parse the SPS, 2) will set pixel-aspect-ratio in caps regardless if a pasp atom is present. So there is no way for us to distinguish between 1) pasp being present and having an aspect ratio of 1:1, and 2) pasp not being present but pixel-aspect-ratio having been set to 1:1 by gstreamer as fallback. And because this is the case, I made sure winedmo is tested separately. In winedmo's case, if pasp is not present, we can set the PixelAspectRatio.Denominator in MFVIDEOFORMAT to 0 to distinguish. -- v4: mfsrcsnk: Parse pixel aspect ratio from the avcC atom. mfsrcsnk: Test how pixel aspect ratio metadata in an mp4 file are handled. https://gitlab.winehq.org/wine/wine/-/merge_requests/10321

2 3

[PATCH 0/1] MR10322: icu/tests: Add initial tests.
by Zhiyi Zhang (＠zhiyi) March 12, 2026

March 12, 2026

This is mainly to test that ICU data is loaded properly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10322

2 1

Re: [PATCH v4 0/2] MR9180: win32u: Fix deadlock caused by nested locking. - closed
by Zhao Yi (＠Zhaoyi) March 12, 2026

March 12, 2026

This merge request was closed by Zhao Yi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9180

1 0

[PATCH v18 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński March 12, 2026

March 12, 2026

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v18: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

1 4

[PATCH 0/2] MR10321: mfsrcsnk: Parse pixel aspect ratio from the avcC atom.
by Yuxuan Shui (＠yshui) March 12, 2026

March 12, 2026

More specifically the SPS bytes in the avcC atom. Note this only fixes the problem for winedmo but not gstreamer. This is because gstreamer 1) does not parse the SPS, 2) will set pixel-aspect-ratio in caps regardless if a pasp atom is present. So there is no way for us to distinguish between 1) pasp being present and having an aspect ratio of 1:1, and 2) pasp not being present but pixel-aspect-ratio having been set to 1:1 by gstreamer as fallback. And because this is the case, I made sure winedmo is tested separately. In winedmo's case, if pasp is not present, we can set the PixelAspectRatio.Denominator in MFVIDEOFORMAT to 0 to distinguish. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10321

2 2

[PATCH v2 0/1] MR10108: ntdll: Never use CLOCK_REALTIME_COARSE.
by William Horvath (＠whrvt) March 12, 2026

March 12, 2026

This is required for deterministic timekeeping, as the CLOCK_REALTIME_COARSE path depends on the scheduling tickrate (CONFIG_HZ) the kernel was built with. Increasing the kernel tickrate to 1000 or greater will then result in decreased accuracy for anything calling NtQuerySystemTime, which some anti-cheat/DRM schemes are unhappy about (see wine bug). Being in the vDSO, clock_gettime(CLOCK_REALTIME) should not meaningfully impact performance when compared to CLOCK_REALTIME_COARSE. Furthermore, the CLOCK_REALTIME_COARSE code path is completely untested in CI, because the current CI runners are configured with CONFIG_HZ < 1000. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59420 -- v2: ntdll: Never use CLOCK_REALTIME_COARSE. https://gitlab.winehq.org/wine/wine/-/merge_requests/10108

2 1

Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
by Yongjie Yao (＠yaoyongjie) March 12, 2026

March 12, 2026

@rbernon Hello Rémi Bernon, may I ask if you can help me review this merge request？ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_132135

1 0