April 15, 2026
9:15 a.m.
On Wed Apr 15 09:15:14 2026 +0000, Nikolay Sivov wrote:
Please add some tests for this. Looking at https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/shell32/tests/assoc.c, all tests rely on calling `GetString()` twice to acquire the length, rather than preallocating a likely-large-enough buffer and expecting `*pcchOut` to be updated to the returned length; will need to extend the tests for that.
It likely belongs in `test_IQueryAssociations_GetString()` although that only seems to test an initially-successful get for the length, and two failure cases with `E_NOT_SUFFICIENT_BUFFER` and `E_POINTER`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10072#note_136251