April 10, 2026
12:05 a.m.
Vibhav Pant (@vibhavp) commented about dlls/winebth.sys/dbus.c:
p_dbus_message_unref( request ); return STATUS_PENDING; failed: - p_dbus_message_iter_abandon_container_if_open( &args_iter, &dict_iter ); + if (p_dbus_message_iter_abandon_container_if_open) + p_dbus_message_iter_abandon_container_if_open( &args_iter, &dict_iter );
Wouldn't this cause a leak if `dbus_message_iter_abandon_container_if_open` is not available? I think it's better to not use this method entirely, add a boolean to track whether the container has been initialized, and call `dbus_message_iter_abandon_container` on failure if it's true. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10591#note_135771