Re: [PATCH v5 0/3] MR10504: vbscript: Implement GetLocale / SetLocale and honor locale in Format*

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> -        new_lcid = i;
> -        break;
> -    }
> +        }
> +
> +        if(!IsValidLocale(new_lcid, LCID_INSTALLED))
> +            return MAKE_VBSERROR(VBSE_LOCALE_SETTING_NOT_SUPPORTED);
>      }
>
> This->ctx->lcid = new_lcid;
> -    return_int(res, old_lcid);
> -    if(!IsValidLocale(new_lcid, LCID_INSTALLED))
> -        return MAKE_VBSERROR(VBSE_LOCALE_SETTING_NOT_SUPPORTED);
> -
> -    return S_OK;
> +    SetThreadLocale(new_lcid);
> I would expect that we should pass the LCID explicitly in more cases instead, similar to what you did in the other commit for `to_string`. You can verify this by checking the thread locale in run.c.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10504#note_137464