On Wed Jun 10 16:11:13 2026 +0000, Henri Verbeet wrote:
```diff @@ -937,7 +937,7 @@ static IDXGISwapChain *create_swapchain_(unsigned
int line, IUnknown *device, BO
get_factory(device, is_d3d12, &factory); hr = IDXGIFactory_CreateSwapChain(factory, device, &desc, &swapchain); - ok_(__FILE__, line)(hr == S_OK, "Failed to create swapchain, hr
%#lx.\n", hr);
+ ok_(__FILE__, line)(hr == S_OK || broken(hr == DXGI_ERROR_INVALID_CALL) /* Win8.1 */, "Failed to create swapchain, hr %#lx.\n", hr); IDXGIFactory_Release(factory);
return swapchain; ``` Is there a specific reason swapchain creation fails? Surely Windows 8.1 supports swapchains in general. Is this about DXGI_SWAP_EFFECT_FLIP_DISCARD (which is more or less a d3d12 thing) being unsupported? Hello, thanks for taking a look.
This line is against the crash that gets hit after avoiding the first one, visible here: https://testbot.winehq.org/JobDetails.pl?Key=163329&f203=exe32.report#k203 This shows `dxgi.c:8010: Test failed: d3d10: test 1: Failed to create swapchain, hr 0x887a0001.` So, yes, this seems to be about DXGI_SWAP_EFFECT_FLIP_DISCARD. I fear there is now to much in this MR, should I at least put the missing winetest_pop_context into a separate MR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11110#note_142656